Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp3420595pxm; Mon, 28 Feb 2022 20:09:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJwMxhI2nRQTmik6LbQ73d5VN36834IMkmLboY5NoBGJMhl9ILggSIwlq5whn3x1bbXXeUCP X-Received: by 2002:a17:903:32c1:b0:14f:8ba2:2326 with SMTP id i1-20020a17090332c100b0014f8ba22326mr23603367plr.34.1646107793464; Mon, 28 Feb 2022 20:09:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646107793; cv=none; d=google.com; s=arc-20160816; b=NvAOPlXGqXuVBnhS4Kd4GMk3J4hj3GMOrn5nRMuZj27umlLFRCJuInAxE40iWSomgk TZAwtr94cDHVtapDWlEgIy+k5aWq7++tR6jWWUKWEZ3EaUqbSKir6Cd9/4syseu9kR3f v7il9I+kD+Ke8IbrdRSMc3QZWJ4Rnk2sOMbKB3blGmcsTknIS8gW8tYwkB9Izb0jHcN7 hN8pSBoCavuKxXubCFOKrK3iawnw7r4ITk4xG90QwCQ4oxaUdiTc8YzwaTdR35h3y7PW ZdM8Uk5fPRni881C5HT7PASUYk0ipcThHNgVYuCf+X4SEEHyW11u34zdY12Ie/LXHFC8 NTQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=yXndaB8z3eG6YNhJ5eZFobssgMdzDctXQPYklrHtNbc=; b=kzxnK8x2aG9EC+7frOBTpW5oXrV375638z1NJGkN5lXjONf2QiOc+YIqn9741uZMUL fJe37QGcMxMhAtQB9Tp8mB/J9VYdqs+7WYNTU+Y1QQL2Isf28a+TyuiStZsxtyelE4au K4zx3wz1yIb+Pg0RSvqVERzph/ZzBcPt+Sxy1Fwi9RlVM3dN73Fg9nsfSVdQjj0IR6Q4 drI/UO9ux/W46sZlziPJI8gq1X+zLk0/CqIgQ6W6dUIH616aucb2kC5B2teZe3XtNQ7E jKma7riAhOQjvKsgpBCQZfkAnNjXgyO+IACl1llwzXBTD28kX/7l6eN46b4lU2SFjLGf LkYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=VuwoJhL3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dw7-20020a17090b094700b001bed39e61d7si1252745pjb.49.2022.02.28.20.09.33; Mon, 28 Feb 2022 20:09:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=VuwoJhL3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231678AbiCAAWj (ORCPT + 99 others); Mon, 28 Feb 2022 19:22:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbiCAAWh (ORCPT ); Mon, 28 Feb 2022 19:22:37 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B3B4245A1; Mon, 28 Feb 2022 16:21:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=yXndaB8z3eG6YNhJ5eZFobssgMdzDctXQPYklrHtNbc=; b=VuwoJhL3wgTaLNw7MkN4bhfn8A JQYxjKbgUItAmbCDW38bzGDEHwwkpy0OAIhyFKsvHL6ubV80U8SAuE+4JWwT5rkTNUxvM8v+U8vKw V3NwNA4I/QjmS3dv2J89GggDT6x03uohywam1vAldQFixyoBK7rFhPzKhOlTvL7P3mfAQuoqhUmel o96OaK/yasRAItDa+XR3N1WjpSjcCBxln8sz8v3yWTfxkjWMlSmm7Xhyt1qjjDncK9+46yw6egVxs VhDHWrxzN5Cak5mX9LwCATu0AvfVZ0Ucwn4G1SlvWl6TaH7HacufmVO+9VpeFRo/8qO6tlu7Zfl+/ 1WanZbHw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOqGw-00ETq0-JY; Tue, 01 Mar 2022 00:21:46 +0000 Date: Mon, 28 Feb 2022 16:21:46 -0800 From: Luis Chamberlain To: Aaron Tomlin Cc: christophe.leroy@csgroup.eu, pmladek@suse.com, cl@linux.com, mbenes@suse.cz, akpm@linux-foundation.org, jeyu@kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, void@manifault.com, atomlin@atomlin.com, allen.lkml@gmail.com, joe@perches.com, msuchanek@suse.de, oleksandr@natalenko.name, jason.wessel@windriver.com, daniel.thompson@linaro.org Subject: Re: [PATCH v9 00/14] module: core code clean up Message-ID: References: <20220228234322.2073104-1-atomlin@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220228234322.2073104-1-atomlin@redhat.com> Sender: Luis Chamberlain X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 28, 2022 at 11:43:08PM +0000, Aaron Tomlin wrote: > Hi Luis, > > As per your suggestion [1], this is an attempt to refactor and split > optional code out of core module support code into separate components. > This version is based on Linus' commit 7993e65fdd0f ("Merge tag > 'mtd/fixes-for-5.17-rc5' of > git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux"). > > Petr, > > I decided to use preempt_disable() instead to remain consistent with the > rest of the file. Unfortunately, I did not make time to boot test etc. Aaron, thanks so much for doing this! Since no boot tests are performed yet, I just pushed this to modules-testing for now, after we get some boot test results I'll push to modules-next. We should run kmod tests as well. Luis