Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <db542880-304a-f48b-2159-d0955841c8e9@gmail.com>
Date:   Mon, 28 Feb 2022 22:00:15 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 1/1] of: unittest: add program to process EXPECT messages
Content-Language: en-US
To:     Rob Herring <robh+dt@kernel.org>
Cc:     devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20220201181413.2719955-1-frowand.list@gmail.com>
 <CAL_JsqKrWQ1Jn2HCxFsPKYcPXbYUgyPytvc_YrS=sgkWHv1hZA@mail.gmail.com>
From:   Frank Rowand <frowand.list@gmail.com>
In-Reply-To: <CAL_JsqKrWQ1Jn2HCxFsPKYcPXbYUgyPytvc_YrS=sgkWHv1hZA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/28/22 15:24, Rob Herring wrote:
> On Tue, Feb 1, 2022 at 12:14 PM <frowand.list@gmail.com> wrote:
>>
>> From: Frank Rowand <frank.rowand@sony.com>
>>
>> If unittest detects a problem it will print a warning or error message
>> to the console.  Unittest also triggers warning and error messages from
>> other kernel code as a result of intentionally bad unittest data.  This
>> has led to confusion as to whether the triggered messages are an
>> expected result of a test or whether there is a real problem that is
>> independent of unittest.
>>
>> EXPECT messages were added to unittest to report each triggered message
>> that is expected, resulting in verbose console output.
>>
>> scripts/dtc/of_unittest is a new program that processes the EXPECT
>> messages to determine whether the triggered messages occurred and
>> also removes the excess verbosity of the EXPECT messages.  More
>> information is available from 'scripts/dtc/of_unittest_expect --help'.
>>
>> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
>> ---
>> permissions for scripts/dtc/of_unittest should be 770
> 
> Why? 755 is what the patch says and what most/all executables in the kernel are.

I based that on the permissions of other executables in scripts/dtc/

I do like 755 better, thanks for pointing out the wider population of
executables in the kernel.

-Frank

> 
> Rob
> 
>>
>> I will reply to this message with the usage message from
>> 'scripts/dtc/of_unittest_expect --help'.
>>
>> I will also reply with examples of raw and processed console logs.
>>
>>  Documentation/devicetree/of_unittest.rst |  27 +-
>>  scripts/dtc/of_unittest_expect           | 408 +++++++++++++++++++++++
>>  2 files changed, 432 insertions(+), 3 deletions(-)
>>  create mode 100755 scripts/dtc/of_unittest_expect