Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220226110338.77547-1-chenhuacai@loongson.cn>
 <20220226110338.77547-10-chenhuacai@loongson.cn> <CAMj1kXHWRZcjF9H2jZ+p-HNuXyPs-=9B8WiYLsrDJGpipgKo_w@mail.gmail.com>
 <YhupaVZvbipgke2Z@kroah.com> <CAAhV-H6hmvyniHP-CMxtOopRHp6XYaF58re13snMrk_Umj+wSQ@mail.gmail.com>
 <CAMj1kXFa447Z21q3uu0UFExDDDG9Y42ZHtiUppu6QpuNA_5bhA@mail.gmail.com>
 <CAAhV-H7X+Txq4HaaF49QZ9deD=Dwx_GX-2E9q_nA8P76ZRDeXg@mail.gmail.com>
 <CAMj1kXGH1AtL8_KbFkK+FRgWQPzPm1dCdvEF0A2KksREGTSeCg@mail.gmail.com>
 <CAAhV-H6fdJwbVG_m0ZL_JGROKCrCbc-fKpj3dnOowaEUA+3ujQ@mail.gmail.com>
 <CAK8P3a2hr2rjyLpkeG1EKiOVGrY4UCB61OHGj5nzft-KCS3jYA@mail.gmail.com> <CAMj1kXHGG80LdNUUA+Ug1VBXWuvtPxKpqnuChg2N=6Hf2EhY7g@mail.gmail.com>
In-Reply-To: <CAMj1kXHGG80LdNUUA+Ug1VBXWuvtPxKpqnuChg2N=6Hf2EhY7g@mail.gmail.com>
From:   Huacai Chen <chenhuacai@gmail.com>
Date:   Tue, 1 Mar 2022 12:17:03 +0800
Message-ID: <CAAhV-H6dxkdmDizd+ZVhJ_zHZ9RK8QjKU-3U-CaovLiNbEVpbg@mail.gmail.com>
Subject: Re: [PATCH V6 09/22] LoongArch: Add boot and setup routines
To:     Ard Biesheuvel <ardb@kernel.org>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Huacai Chen <chenhuacai@loongson.cn>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>, Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Airlie <airlied@linux.ie>,
        Jonathan Corbet <corbet@lwn.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-arch <linux-arch@vger.kernel.org>,
        Linux Doc Mailing List <linux-doc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Xuefeng Li <lixuefeng@loongson.cn>,
        Yanteng Si <siyanteng@loongson.cn>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        linux-efi <linux-efi@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi, Ard & Arnd,

On Mon, Feb 28, 2022 at 7:35 PM Ard Biesheuvel <ardb@kernel.org> wrote:
>
> On Mon, 28 Feb 2022 at 12:24, Arnd Bergmann <arnd@arndb.de> wrote:
> >
> > On Mon, Feb 28, 2022 at 11:42 AM Huacai Chen <chenhuacai@gmail.com> wrote:
> > > On Mon, Feb 28, 2022 at 4:52 PM Ard Biesheuvel <ardb@kernel.org> wrote:
> > > > On Mon, 28 Feb 2022 at 09:38, Huacai Chen <chenhuacai@gmail.com> wrote:
> > > > > >
> > > > > > RISC-V is a useful reference for the changes needed - this is the most
> > > > > > recent addition to the EFI stub, and avoids some legacy stuff that new
> > > > > > architectures have no need for.
> > > > > We still want to support the raw elf kernel (RISC-V also does),
> > > > > because LoongArch also has MCU and SoC and we want to support FDT (I
> > > > > think this is reasonable, because RISC-V also supports raw elf).
> > > > >
> > > >
> > > > That is fine. So perhaps the best course of action is to omit the
> > > > UEFI/ACPI parts entirely for now, and focus on the DT/embedded use
> > > > case. Once all the spec pieces are in place, the UEFI + ACPI changes
> > > > can be presented as a single coherent set.
> > > It seems that I made you confusing. :)
> > > There are big CPUs and small CPUs (MCU and SoC), big CPUs use
> > > UEFI+ACPI, while small CPUs use FDT.
> > > At present, the only matured LoongArch CPU is Loongson-3A5000 (big
> > > CPU) which uses UEFI+ACPI.
> > > We want to support raw elf because it can run on both ACPI firmware
> > > and FDT firmware, but at present we only have ACPI firmware.
> >
> > Can't you just use the UEFI protocol for kernel entry regardless
> > of the bootloader? It seems odd to use a different protocol for loading
> > grub and the kernel, especially if that means you end up having to
> > support both protocols inside of u-boot and grub, in order to chain-load
> > a uefi application like grub.
> >
>
> I think this would make sense. Now that the EFI stub has generic
> support for loading the initrd via a UEFI specific protocol (of which
> u-boot already carries an implementation), booting via UEFI only would
> mean that no Linux boot protocol would need to be defined outside of
> the kernel at all (i.e., where to load the kernel, where to put the
> command line, where to put the initrd, other arch specific rules etc
> etc) UEFI already supports both ACPI and DT boot

After one night thinking, I agree with Ard that we can use RISCV-style
fdt to support the raw elf kernel at present, and add efistub support
after new UEFI SPEC released.

If I'm right, it seems that RISC-V passes a0 (hartid) and a1 (fdt
pointer, which contains cmdline, initrd, etc.) to the raw elf kernel.
And in my opinion, the main drawback of current LoongArch method
(a0=argc a1=argv a2=bootparamsinterface pointer) is it uses a
non-standard method to pass kernel args and initrd. So, can the below
new solution be acceptable?

a0=bootparamsinterface pointer (the same as a2 in current method)
a1=fdt pointer (contains cmdline, initrd, etc., like RISC-V, I think
this is the standard method)

Huacai