Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] proc: fix documentation and description of mmap
To:     Peter Xu <peterx@redhat.com>
Cc:     akpm@linux-foundation.org, corbet@lwn.net,
        tiberiu.georgescu@nutanix.com, florian.schmidt@nutanix.com,
        ivan.teterevkov@nutanix.com, sj@kernel.org, shy828301@gmail.com,
        david@redhat.com, axelrasmussen@google.com, linmiaohe@huawei.com,
        aarcange@redhat.com, ccross@google.com, apopple@nvidia.com,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org
References: <20220301032115.384277-1-yun.zhou@windriver.com>
 <Yh2aKofkcWsLswQm@xz-m1.local>
From:   Yun Zhou <yun.zhou@windriver.com>
Message-ID: <4b23a6c4-4b69-019f-7885-d4c9f61e9503@windriver.com>
Date:   Tue, 1 Mar 2022 12:39:37 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <Yh2aKofkcWsLswQm@xz-m1.local>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGp3YjlYNmxja1lDRWJib0hSVTJWWGxWUEFraGhkYVRWNGhGRm1RanAwV0VE?=
 =?utf-8?B?ZXBteGx6dGNNWUp2bG1GNTJ4V0dLYUtBSjh5NTZOR01sZTVLUlZnUnVjalVT?=
 =?utf-8?B?OFc1Y2thVWdlYXpURnh6MDBoL1JIT094bHY1MTRuMkt1OG1EOG94REgzeFRI?=
 =?utf-8?B?ZWlob0Z6aUFiMzdnajhodkRuM2U2MmF1L1BYRXh3MUx3TlRMc3RCMkt6VWdS?=
 =?utf-8?B?V1pyNkhsV2tVYlZ1ZDhkQWFKd0tWU0pmZU1ycGZKU05pcGl2T3FKUFZhbFc3?=
 =?utf-8?B?RythVVNHWVRxQzAvc0lQYTUveVAxZlJyYnBXRmVPMVZMZlcyUHFROElXbGo3?=
 =?utf-8?B?MkJGTUx3M01BU0lOTm5iNVJuTzNzcUNkZG5URFZaOUZWUVhKMEFvL3RFM1Iz?=
 =?utf-8?B?V05Makt2OWVRaWRhNVV5bG1WSzJIclhMZDhROWxvZytCc0toak9jZkNGSHBM?=
 =?utf-8?B?TndJL3VpQU5BVERyallncjQ2YUpwVEIyNkZaVkU5YjVlV0c0czJlQU91OFZq?=
 =?utf-8?B?OXFqL3VCN09JQXpUTTI5TGdpNGJneXJIOEhNZllzMEVrcG5MVkpyTGxIenM2?=
 =?utf-8?B?WW5NMkNSdWFHQnhPdi95NVp4MDZDbUswZlprekRXenUwcXJEaC9YSEV2WnFk?=
 =?utf-8?B?RGdXSW1raGQ3SjFDVWhvVWJuYjRTUnY0eWswQUl0dlJNcDBmaEwzV1N2eWVQ?=
 =?utf-8?B?b0xNSTBwOFRPd2NvbWFrSWh2TDM0aVJTTVFEVnh5d21oL3lHcVR1aWNqR1Ri?=
 =?utf-8?B?M0V0V0RNK24yVm91RHYweTFTb2dnSnBDaEVzQ1V4b3FEQi94U1dNcDAzc0V5?=
 =?utf-8?B?VWdVaWZWVjVNc2NlT2x1eUxjTzROSjk4dW1qVnlxakJ6c1VRUjVvSnpqTFZX?=
 =?utf-8?B?dVd0S1JCc05EU3BTUTlQcDN1azF5NGwrS2ZYNXJza1ppeGJEbkFCWkhLUDNx?=
 =?utf-8?B?ODl5UGV0cWI1a0RMNldXaVkzZTkyQWV0WEdXSjFRVkJoTm9IUERMbUg1VElm?=
 =?utf-8?B?SGtjMnVFTWdyZ3VTUTVJN2NmMDJxSnhkUFRKWTVKSVdjUnpLSml1d09WMTBq?=
 =?utf-8?B?R3BFMnBScm1FWHZ4NFV0M3l4L1pTZWRodEwxSVA0QW1zYlUvSTBHWi92SjY0?=
 =?utf-8?B?NVU2YTgyV1lHcTJTc1p5cVJuQ0w1eGdwMnRySUtpYU0yM2pYeUhFV3lTblRV?=
 =?utf-8?B?cCsrZDNaOVlFblVhOHRyWWdBQ3lJSVExUTAwM05SdEZ0Y2s0QzJRV1JHdDhm?=
 =?utf-8?B?eVVqdUpiRG0rS0lhajlTaGVLMXhYcVBJZTZZUy9WQmF4aXljUGRha01sVXpl?=
 =?utf-8?B?bWVJSnVkd09hTWhReGZ3S0dKZXN1emVuOUtxMWJWQkVGa3NDUnJCUm1ZKyt2?=
 =?utf-8?B?ZXZmN3AvZFJVSkFaREpXUmxFVzBUVDh3dWZ1bUVKbmRxYXlKTklLcnZJS3pk?=
 =?utf-8?B?dm1rZkphU1h5Tm9oeUw4d0VuRkhGOGNoRExBV01hYmc3Z1JNcWFYbHB2cGZa?=
 =?utf-8?B?YnNaUEk0UWRseHVPQjNMZThDd0YxOFg2bXRRR1ZyY1pKNXRNQUtHaVFIbGY2?=
 =?utf-8?B?c21kL0RTN09FQ0NnUXdCQnE5UG9wNmthU2VGajhuLzBIMWxGZnJ2V1N1eXFZ?=
 =?utf-8?B?MitZcGtnWjVkdUsxN1hQVkRMNWR3T3d1SHh0UmQ0Q2xuNDVBaDhtd3ExR2px?=
 =?utf-8?B?N2UzZDR6dzg5M21nODlla1JBc3FaMktFeWFOR0p6cXlQejE3V2kyU0JZTm84?=
 =?utf-8?B?NnAzYmRvVUU0bmJiaVJOTjZZRzN1R01JUnB4cWJHYlZONW5MSjE4QlZaditX?=
 =?utf-8?B?RHpvclVDY2FkSmtETWZycFo1RU1ibnl2djY1QW5UVWpZaEdGMktpQ3owSDlw?=
 =?utf-8?B?NHhpV3ZyRWxCcmZjV3g2eUJnOWhOSUNiNW1XeWR4L2k4dkVoLzhHWnlhcWho?=
 =?utf-8?B?YkxKODI2dC9vYzBWMUloSjg4K205TTE0TkFub3dwN2pWclZObDNKZnM4VGtS?=
 =?utf-8?B?UE1jVjFCTktvbUM2S2xFTmJLcWlBZFJQWnVOYUQ1M2RBT2oxQVlNRFh1S0Rh?=
 =?utf-8?B?Mm8wRkh5N2lza0JpclBJRUdrbEY2RWQ5SzNCKzJoZnh3VzFyUEkzSGkwRGFC?=
 =?utf-8?B?MUN0SEh6a29QSElQbXRpbFd5T2hma0RaeHBrcFFJL1UwSDVIcGVodkVsTTZ2?=
 =?utf-8?Q?cbF3VuYm5GOANcG+sUWfMOk=3D?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cac60cb5-fd86-447b-a144-08d9fb3d82d7
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3008.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 04:39:46.2163
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d4kWiGBPtbYtH0gpHZYVfkpZcaLvv1j/1nviDazeXrhXgcLQJXQcNI9P8usI+UeH+gcmTAlj0Uu02jAoU5AZXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5433
X-Proofpoint-GUID: lygOOWBQBc661TMI8uWeTptFx3RJxo02
X-Proofpoint-ORIG-GUID: lygOOWBQBc661TMI8uWeTptFx3RJxo02
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.64.514
 definitions=2022-02-28_10,2022-02-26_01,2022-02-23_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0
 priorityscore=1501 phishscore=0 adultscore=0 malwarescore=0 suspectscore=0
 bulkscore=0 lowpriorityscore=0 mlxlogscore=764 impostorscore=0
 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2203010020
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/1/22 11:59 AM, Peter Xu wrote:
> [Please note: This e-mail is from an EXTERNAL e-mail address]
> 
> On Tue, Mar 01, 2022 at 11:21:15AM +0800, Yun Zhou wrote:
>> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
>> index 78125ef20255..75511f78075f 100644
>> --- a/fs/proc/task_mmu.c
>> +++ b/fs/proc/task_mmu.c
>> @@ -1596,7 +1596,8 @@ static const struct mm_walk_ops pagemap_ops = {
>>    * Bits 5-54  swap offset if swapped
>>    * Bit  55    pte is soft-dirty (see Documentation/admin-guide/mm/soft-dirty.rst)
>>    * Bit  56    page exclusively mapped
>> - * Bits 57-60 zero
>> + * Bit  57    pte is uffd-wp write-protected (since 5.13) (see
>                                                  ^^^^^^^^^^^^^^^^^ remove these?
Sorry for my mistake, I will follow your suggestion and send patch v2.

Thanks,
Yun