Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp3600695pxm; Tue, 1 Mar 2022 01:24:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJwhmrPXpJIEJp0UKnftml1G57k+K84mawPfCkZmEI5cFtfkakrK1MrzuNHpKjBkWKPFP06u X-Received: by 2002:a05:6402:d0d:b0:412:d49c:74d3 with SMTP id eb13-20020a0564020d0d00b00412d49c74d3mr23499986edb.207.1646126698339; Tue, 01 Mar 2022 01:24:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646126698; cv=none; d=google.com; s=arc-20160816; b=Ho2Wdm0eyDMmbdTDw3L/OOMky1koqruLBgZpKhUXPWgG8SShldjuk+d2ua7rLUla8G 2hJhCLgoRI211xDyqtKofFXJ59X/K4d582Rf6YF66RnRKjT8mq7Qi+TVvwlFYRM19rH9 chuQoVQgdgD8RFenKFTiKr+58UP7xh+sDF2w0MdUnJjAQwtp7595dTlV56fyLDYwXVz7 Ni5rdYhQiVCighMEqFkw+D9q+RGIdzE8347ZJ3IuwFsoZRTBKSkqAP7r7ZUQ3ZZu8As1 bU8IW5APQjn1nxgAi4ZQCaRukCK2vAOrNU4jjmF6k+p5qfN/lVEKxIxrh0zdTP3IRh3C +FDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=5ifgmeolyADD8+Q3MW+tztSqB/OrIu7C/gATCZCvjfA=; b=mBiAvHvMPkuDKuhryh8PZnEUPCED1uDoCcNDAhKS0o0lnbE3UgDCEqJ5G+Nl+Or5TX DntCnW7Zp0klpHtaCEspRmhf+m4fVaEnpb8QdCmjIR9BBA3qtip3RIdB4AssIIiLcMMz e7QPpjSPOiNLpHDqCaXEfGG154oevCTUQieCpOdTRh+jq5iDqAOTEHDbsv2EJOwTjmt+ TiBvFv2QyQ6KVKygEmhWYHi//PXaKmTtWxlw58g7u+Wc6Wf6/kTwSwyQt4x6KDlWk5dc gco3qHYnkEyxNdZE1Vrs6fOBwUgg6RkgREVbKYm2EzPaJPkJ14noJFe48Ue3jpscuws3 cTtQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g9-20020a170906c18900b006b259e56d18si7364230ejz.272.2022.03.01.01.24.35; Tue, 01 Mar 2022 01:24:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232460AbiCAIRG (ORCPT + 99 others); Tue, 1 Mar 2022 03:17:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230521AbiCAIRE (ORCPT ); Tue, 1 Mar 2022 03:17:04 -0500 Received: from out30-54.freemail.mail.aliyun.com (out30-54.freemail.mail.aliyun.com [115.124.30.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BF8F83026; Tue, 1 Mar 2022 00:16:23 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R461e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0V5vTaqf_1646122580; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0V5vTaqf_1646122580) by smtp.aliyun-inc.com(127.0.0.1); Tue, 01 Mar 2022 16:16:20 +0800 From: Yang Li To: sre@kernel.org Cc: support.opensource@diasemi.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot Subject: [PATCH -next] power: supply: da9150-fg: Remove unnecessary print function dev_err() Date: Tue, 1 Mar 2022 16:16:19 +0800 Message-Id: <20220301081619.121904-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The print function dev_err() is redundant because platform_get_irq_byname() already prints an error. Eliminate the follow coccicheck warning: ./drivers/power/supply/da9150-fg.c:524:2-9: line 524 is redundant because platform_get_irq() already prints an error Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/power/supply/da9150-fg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/power/supply/da9150-fg.c b/drivers/power/supply/da9150-fg.c index e63fa62d1943..8c5e2c49d6c1 100644 --- a/drivers/power/supply/da9150-fg.c +++ b/drivers/power/supply/da9150-fg.c @@ -520,10 +520,8 @@ static int da9150_fg_probe(struct platform_device *pdev) /* Register IRQ */ irq = platform_get_irq_byname(pdev, "FG"); - if (irq < 0) { - dev_err(dev, "Failed to get IRQ FG: %d\n", irq); + if (irq < 0) return irq; - } ret = devm_request_threaded_irq(dev, irq, NULL, da9150_fg_irq, IRQF_ONESHOT, "FG", fg); -- 2.20.1.7.g153144c