Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220218215531.1.I5dbf50eb1a7a6734ee727bda4a8573358c6d3ec0@changeid>
 <Yh3LC8WtLdgQNyQI@google.com>
In-Reply-To: <Yh3LC8WtLdgQNyQI@google.com>
From:   Benjamin Tissoires <benjamin.tissoires@redhat.com>
Date:   Tue, 1 Mar 2022 11:24:04 +0100
Message-ID: <CAO-hwJL2vn7-CzHAE_0S7_04oPjyfopKTD=5srwPQY0nXTxusQ@mail.gmail.com>
Subject: Re: [PATCH v3] HID: Add mapping for KEY_DICTATE
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc:     William Mahon <wmahon@chromium.org>,
        LKML <linux-kernel@vger.kernel.org>,
        William Mahon <wmahon@google.com>,
        Jiri Kosina <jikos@kernel.org>,
        "open list:HID CORE LAYER" <linux-input@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Mar 1, 2022 at 8:28 AM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> On Fri, Feb 18, 2022 at 09:59:08PM +0000, William Mahon wrote:
> > Numerous keyboards are adding dictate keys which allows for text
> > messages to be dictated by a microphone.
> >
> > This patch adds a new key definition KEY_DICTATE and maps 0x0c/0x0d8
> > usage code to this new keycode. Additionally hid-debug is adjusted to
> > recognize this new usage code as well.
>
> Jiri, Benjamin, OK for me to pick it up?

If you are happy with the mapping:
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

(and yes, please take it through your tree, same for the other one).

Cheers,
Benjamin

>
> >
> > Signed-off-by: William Mahon <wmahon@google.com>
> > ---
> >
> >  drivers/hid/hid-debug.c                | 1 +
> >  drivers/hid/hid-input.c                | 1 +
> >  include/uapi/linux/input-event-codes.h | 1 +
> >  3 files changed, 3 insertions(+)
> >
> > diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
> > index 26c31d759914..8aa68416b1d7 100644
> > --- a/drivers/hid/hid-debug.c
> > +++ b/drivers/hid/hid-debug.c
> > @@ -969,6 +969,7 @@ static const char *keys[KEY_MAX + 1] = {
> >       [KEY_ASSISTANT] = "Assistant",
> >       [KEY_KBD_LAYOUT_NEXT] = "KbdLayoutNext",
> >       [KEY_EMOJI_PICKER] = "EmojiPicker",
> > +     [KEY_DICTATE] = "Dictate",
> >       [KEY_BRIGHTNESS_MIN] = "BrightnessMin",
> >       [KEY_BRIGHTNESS_MAX] = "BrightnessMax",
> >       [KEY_BRIGHTNESS_AUTO] = "BrightnessAuto",
> > diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> > index 112901d2d8d2..ce2b75a67cb8 100644
> > --- a/drivers/hid/hid-input.c
> > +++ b/drivers/hid/hid-input.c
> > @@ -992,6 +992,7 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel
> >               case 0x0cd: map_key_clear(KEY_PLAYPAUSE);       break;
> >               case 0x0cf: map_key_clear(KEY_VOICECOMMAND);    break;
> >
> > +             case 0x0d8: map_key_clear(KEY_DICTATE);         break;
> >               case 0x0d9: map_key_clear(KEY_EMOJI_PICKER);    break;
> >
> >               case 0x0e0: map_abs_clear(ABS_VOLUME);          break;
> > diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> > index 225ec87d4f22..4db5d41848e4 100644
> > --- a/include/uapi/linux/input-event-codes.h
> > +++ b/include/uapi/linux/input-event-codes.h
> > @@ -612,6 +612,7 @@
> >  #define KEY_ASSISTANT                0x247   /* AL Context-aware desktop assistant */
> >  #define KEY_KBD_LAYOUT_NEXT  0x248   /* AC Next Keyboard Layout Select */
> >  #define KEY_EMOJI_PICKER     0x249   /* Show/hide emoji picker (HUTRR101) */
> > +#define KEY_DICTATE          0x24a   /* Start or Stop Voice Dictation Session (HUTRR99) */
> >
> >  #define KEY_BRIGHTNESS_MIN           0x250   /* Set Brightness to Minimum */
> >  #define KEY_BRIGHTNESS_MAX           0x251   /* Set Brightness to Maximum */
> > --
> > 2.35.1.473.g83b2b277ed-goog
> >
>
> --
> Dmitry
>