Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp3651959pxm; Tue, 1 Mar 2022 02:42:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJwUhfgN6WZyKqHoMEkCR362AivJ962DuOOEYGso6nhu/CuDVdBXkiSHQhBGGRyCLr2pbshn X-Received: by 2002:a05:6a00:1d0c:b0:4e1:9846:3f34 with SMTP id a12-20020a056a001d0c00b004e198463f34mr26598915pfx.59.1646131374517; Tue, 01 Mar 2022 02:42:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646131374; cv=none; d=google.com; s=arc-20160816; b=TRoH1ebVW/e3533TVmoKKsT8tNrUGQ4nJCLV7QBwmWUDv9alQraoWnsrHZxN1XulSK wX5sMtSpxFWk4FLy9KPLgYZpCKyUljNF7AzOkWjejdkmKhBFEhZ0QuhtTFmSpgeOMxpH 7ijGv89rdquNKwniBcHJGjGqD9FV7IexWk6YtAl0fG8P/MnQIs+68ZzKBFKhbjQd7Crq 6xStlUFswzIyZlzBjPLcRsoAempmi40slho6gDqV/+7kf21k0CwFRSAlrYxN3dvKOr9P Hqya+ukoCzhmMFuvQTR28lNbrE+xgxh4CV6wFQEEXYAmI/aTqwI3BI6FvStdpPRIAZim bqOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=Z8X5qYo2DI6JQFCKvMmObvfHJmhW6Xp+QIGOYQ1nhfw=; b=rA097vv42hN5fX4kSbt5nEPgZ1IVtoqbSfGL5vaD3ardA7Q4RY6GsDml0yh08Vzg+h 1Q4UmXHuVvkTm871JwhYFRtRndHn27P0/l3hVTXQR8BMVSg7/rj7m40uZKNOzddsVgmo h/X5qsWiMljsAzQHtBNCD2OU/4axG+6/e+sJP/xiTCDcbiGu+Ry89stkeO5N9FL9HAxe YZnGEqujowg9YRhxmpsZnzzvmvqaHbpPogCEuAmmToup+u4rV2eGvU4Ntmqq4sOs3R1W ZQIhrW2ksygo8rHnXXh6uVwfW8XzVFJHT9GYKizM/ExZm2sHrgL05Mu3/fKQOZeI+U27 gcLw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u14-20020a62ed0e000000b004f35ee26414si10977256pfh.97.2022.03.01.02.42.39; Tue, 01 Mar 2022 02:42:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232912AbiCAH6o (ORCPT + 99 others); Tue, 1 Mar 2022 02:58:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232482AbiCAH6m (ORCPT ); Tue, 1 Mar 2022 02:58:42 -0500 Received: from mail-sh.amlogic.com (mail-sh.amlogic.com [58.32.228.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 366A850B21; Mon, 28 Feb 2022 23:58:01 -0800 (PST) Received: from [10.18.29.173] (10.18.29.173) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 1 Mar 2022 15:57:57 +0800 Message-ID: <154c3e60-f111-6760-aa08-b9851d66b034@amlogic.com> Date: Tue, 1 Mar 2022 15:57:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH V7 0/6] Use CCF to describe the UART baud rate clock Content-Language: en-US To: Neil Armstrong , , , , CC: Greg Kroah-Hartman , Jiri Slaby , Kevin Hilman , Jerome Brunet , Martin Blumenstingl References: <20220225073922.3947-1-yu.tu@amlogic.com> <849a95fd-ae81-9a3b-0c06-dd7826af9eb2@baylibre.com> From: Yu Tu In-Reply-To: <849a95fd-ae81-9a3b-0c06-dd7826af9eb2@baylibre.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.18.29.173] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Neil, On 2022/3/1 15:25, Neil Armstrong wrote: > [ EXTERNAL EMAIL ] > > Hi, > > Le 25/02/2022 à 08:39, Yu Tu a écrit : >> Using the common Clock code to describe the UART baud rate >> clock makes it easier for the UART driver to be compatible >> with the baud rate requirements of the UART IP on different >> meson chips. Add Meson S4 SoC compatible. >> >> The test method: >> Start the console and run the following commands in turn: >> stty -F /dev/ttyAML0 115200 and stty -F /dev/ttyAML0 921600. >> >> Since most SoCs are too old, I was able to find all the platforms myself >> such as Meson6, Meson8, Meson8b, GXL and so on. I only tested it with >> G12A and S4. >> >> Yu Tu (6): >>    tty: serial: meson: Move request the register region to probe >>    tty: serial: meson: Use devm_ioremap_resource to get register mapped >>      memory >>    tty: serial: meson: Describes the calculation of the UART baud rate >>      clock using a clock frame >>    tty: serial: meson: Make some bit of the REG5 register writable >>    tty: serial: meson: The system stuck when you run the stty command on >>      the console to change the baud rate >>    tty: serial: meson: Added S4 SOC compatibility >> >> V6 -> V7: To solve the system stuck when you run the stty command on >> the console to change the baud rate. >> V5 -> V6: Change error format as discussed in the email. >> V4 -> V5: Change error format. >> V3 -> V4: Change CCF to describe the UART baud rate clock as discussed >> in the email. >> V2 -> V3: add compatible = "amlogic,meson-gx-uart". Because it must >> change >> the DTS before it can be deleted >> V1 -> V2: Use CCF to describe the UART baud rate clock.Make some >> changes as >> discussed in the email >> >> Link:https://lore.kernel.org/linux-amlogic/20220118030911.12815-4-yu.tu@amlogic.com/ >> >> >>   drivers/tty/serial/meson_uart.c | 221 ++++++++++++++++++++++---------- >>   1 file changed, 154 insertions(+), 67 deletions(-) >> >> >> base-commit: a603ca60cebff8589882427a67f870ed946b3fc8 > > Could you send the emails To Kevin, Jerome, Martin & me, and put the > various lists in CC instead ? otherwise we are not notified when the > patch is accepted by the tty maintainer. The fact is that sending is adding you up, you see Link: https://lore.kernel.org/linux-amlogic/20220225073922.3947-1-yu.tu@amlogic.com/ > > Thanks, > Neil >