Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp3680657pxm; Tue, 1 Mar 2022 03:22:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJyf0MltN/38txK1eY/bxxBhbWIwpGMDTJuSCZN6oAoLaJgFDIeTgeqW7fRbCSOcJwReeaKh X-Received: by 2002:a17:902:d504:b0:14d:846f:e7da with SMTP id b4-20020a170902d50400b0014d846fe7damr19480660plg.133.1646133743397; Tue, 01 Mar 2022 03:22:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646133743; cv=none; d=google.com; s=arc-20160816; b=gvuUXuGJrBpMo0OofkLZPxJHUMRnUvEnx4gsyTf9ywXvD48MR8Mdx+h94sL20DDnQR 3Iv9oUbbvsPGrzDXE7Js8wk49ktfzMzzcwtNDcJfeu+SeIKaXwJ3ChZ/XPYNJzzo69KP LK+/TSEtf45s7lNLNJJEKtlH4bgIF0WVC2gU/mcBkLVGJ0VGHmpOto+3p1ZI668vvv5F Pkc5r2L2f59kcSoyKwj+4XKodjCT4xB74UiyRJK6+4mjN57CXSZPum3NItF9PaAcMCO4 rT2eBqaBPBM70lrE12StQNuznX31GualSsi5YtWbaKhRE82rOzawIG43LrTjQbriaGRs RKbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=deTPdQNXqsoTBO5y3U6QN0vFPS+bvAYxf5VHbTghG9A=; b=Jyt0Tqo0OAUbAeAvWxmufAAvo9yCbRpakgo/rZMHP88YB2JCsx4r3j6DVmuYi1Lgos DtQqzN0RBhqFAWGUYWtfYI3hwDd7Fc9TL3PfCRd+gfQ0Ua4BxUR8lqlJZjEZ6QZtiRN/ qAirJuT1/aLUYzWSo2kDOEKAXCJ5kUw8pw45elGeaTSes3ikgdi2FcDoKHMnVdpe0aRs pesmK5ZumLY5QCCvtxZTukT3zMx4TreiwjTKJUj8pd++fti0ITTOIj02pLRbY7RDlPHO Yz3sdldkej2Y8t6Xlzaph5hZK3wo+vZVLqkbQSAIo6PqkBuFLwPxSF6VUMtB9qbykZ5P hZlA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 30-20020a63105e000000b003706462bf43si11479615pgq.284.2022.03.01.03.22.08; Tue, 01 Mar 2022 03:22:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232072AbiCAIs1 (ORCPT + 99 others); Tue, 1 Mar 2022 03:48:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231493AbiCAIsY (ORCPT ); Tue, 1 Mar 2022 03:48:24 -0500 Received: from mail-sh.amlogic.com (mail-sh.amlogic.com [58.32.228.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3C8E1BEB9; Tue, 1 Mar 2022 00:47:42 -0800 (PST) Received: from [10.18.29.173] (10.18.29.173) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Tue, 1 Mar 2022 16:47:39 +0800 Message-ID: <7c4c3272-4ebb-f84b-5436-f1ddc80686ff@amlogic.com> Date: Tue, 1 Mar 2022 16:47:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH V7 0/6] Use CCF to describe the UART baud rate clock Content-Language: en-US To: Neil Armstrong , , , , CC: Greg Kroah-Hartman , Jiri Slaby , Kevin Hilman , Jerome Brunet , Martin Blumenstingl References: <20220225073922.3947-1-yu.tu@amlogic.com> <849a95fd-ae81-9a3b-0c06-dd7826af9eb2@baylibre.com> <154c3e60-f111-6760-aa08-b9851d66b034@amlogic.com> <5f7d9d73-d74c-1eb6-1711-ac3de67e6203@baylibre.com> From: Yu Tu In-Reply-To: <5f7d9d73-d74c-1eb6-1711-ac3de67e6203@baylibre.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.18.29.173] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Neil, On 2022/3/1 16:37, Neil Armstrong wrote: > [ EXTERNAL EMAIL ] > > Hi, > > On 01/03/2022 08:57, Yu Tu wrote: >> Hi Neil, >> >> On 2022/3/1 15:25, Neil Armstrong wrote: >>> [ EXTERNAL EMAIL ] >>> >>> Hi, >>> >>> Le 25/02/2022 à 08:39, Yu Tu a écrit : >>>> Using the common Clock code to describe the UART baud rate >>>> clock makes it easier for the UART driver to be compatible >>>> with the baud rate requirements of the UART IP on different >>>> meson chips. Add Meson S4 SoC compatible. >>>> >>>> The test method: >>>> Start the console and run the following commands in turn: >>>> stty -F /dev/ttyAML0 115200 and stty -F /dev/ttyAML0 921600. >>>> >>>> Since most SoCs are too old, I was able to find all the platforms >>>> myself >>>> such as Meson6, Meson8, Meson8b, GXL and so on. I only tested it with >>>> G12A and S4. >>>> >>>> Yu Tu (6): >>>>    tty: serial: meson: Move request the register region to probe >>>>    tty: serial: meson: Use devm_ioremap_resource to get register mapped >>>>      memory >>>>    tty: serial: meson: Describes the calculation of the UART baud rate >>>>      clock using a clock frame >>>>    tty: serial: meson: Make some bit of the REG5 register writable >>>>    tty: serial: meson: The system stuck when you run the stty >>>> command on >>>>      the console to change the baud rate >>>>    tty: serial: meson: Added S4 SOC compatibility >>>> >>>> V6 -> V7: To solve the system stuck when you run the stty command on >>>> the console to change the baud rate. >>>> V5 -> V6: Change error format as discussed in the email. >>>> V4 -> V5: Change error format. >>>> V3 -> V4: Change CCF to describe the UART baud rate clock as discussed >>>> in the email. >>>> V2 -> V3: add compatible = "amlogic,meson-gx-uart". Because it must >>>> change >>>> the DTS before it can be deleted >>>> V1 -> V2: Use CCF to describe the UART baud rate clock.Make some >>>> changes as >>>> discussed in the email >>>> >>>> Link:https://lore.kernel.org/linux-amlogic/20220118030911.12815-4-yu.tu@amlogic.com/ >>>> >>>> >>>>   drivers/tty/serial/meson_uart.c | 221 >>>> ++++++++++++++++++++++---------- >>>>   1 file changed, 154 insertions(+), 67 deletions(-) >>>> >>>> >>>> base-commit: a603ca60cebff8589882427a67f870ed946b3fc8 >>> >>> Could you send the emails To Kevin, Jerome, Martin & me, and put the >>> various lists in CC instead ? otherwise we are not notified when the >>> patch is accepted by the tty maintainer. >> The fact is that sending is adding you up, you see >> Link: >> https://lore.kernel.org/linux-amlogic/20220225073922.3947-1-yu.tu@amlogic.com/ >> > > It's not the point, the order of recipient in Cc and To is important > since they are used > by maintainers to track patch for review and to notify when patches are > taken in their tree. > > So please make sure the recipients are correctly set before sending the > patches. > I see what you mean. Mailing lists should all use To. > Neil > >>> >>> Thanks, >>> Neil >>> >