Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp3776622pxm; Tue, 1 Mar 2022 05:21:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJxNahPYe4Fm8vzqEmCQMjxOb1Tl7FkChB3K8wS0/s9+JZ7WgyKuEbE4VHo0xGoorxjX0o2o X-Received: by 2002:a17:906:7245:b0:6cf:d3c6:8c63 with SMTP id n5-20020a170906724500b006cfd3c68c63mr18573887ejk.677.1646140880913; Tue, 01 Mar 2022 05:21:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646140880; cv=none; d=google.com; s=arc-20160816; b=SwQs8ZeFZbwUJpfBRXEx7ExSLMkkiB3n7+ZkSqDhM6v46Lq+VEanhDAopwXUfMdiAp AasPwF8en5xPOO4E5R6UFUI0RC6lWhn/R65L5z5CPByeX5NkZghMfDOJOIsp8NyQOCML EGr0T71dpVGI8TnIp4bp25f/ZDYaetn+i8xg9UwkUwUfmU6Iv66bfZH5IigqgcjtNEO/ jMH2ns8HPraINWGbxzKImvp8if8MjG4ctGutsLIenLRFvLbpc6/jMkNCNk+MxHut5rc8 3TjPX30PBG+QDbJFWI3PuGMrFnYkIyX31J7P8xjS9jfznyjGDz/3taJkezxNPErxoLZp AzSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:in-reply-to:date:sender:references:subject:cc:to:from :dkim-signature:dkim-filter; bh=kSabZj2uSQjgkFczSZMvF3bJRihRCuN2IOOpNDYapls=; b=OG2fU5Bt9c1nazUxXzuhzdQ3Ut6lAU/3zgBGBaKJQMW8La2jg9kdCNvcwCimVOsXPK amtsBUCO9gtXXyo0VpC8+PhLubPdQIpHuQNpIfia92n8N7bfUfGtMjvjUHwxKdtuP1yp 3xuCCItfeVloaUQh0V7eAja32KEl51rJvvJru4+mRwRYi7Au4cJjU9bbdmnHWg5ro2Eq syWBobTH67cnoFYq0kl/VYYnV5zShJW0OCpmlerTxQMon5ln82zW1CTOq8cMPzTsEEZB 7fVD50U+4mIBw3R9UfDiZWYHca2QSJVF0qyQs6sVyL5ASagJx+g+bvql1Lb8SPVTwflZ f3Pg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@piap.pl header.s=mail header.b=npohYuiY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=piap.pl Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h25-20020aa7c619000000b00410ddddb29asi8169960edq.451.2022.03.01.05.20.57; Tue, 01 Mar 2022 05:21:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@piap.pl header.s=mail header.b=npohYuiY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=piap.pl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234680AbiCAMUI (ORCPT + 99 others); Tue, 1 Mar 2022 07:20:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232613AbiCAMUG (ORCPT ); Tue, 1 Mar 2022 07:20:06 -0500 Received: from ni.piap.pl (ni.piap.pl [195.187.100.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10E2A56C2C; Tue, 1 Mar 2022 04:19:22 -0800 (PST) Received: from t19.piap.pl (OSB1819.piap.pl [10.0.9.19]) by ni.piap.pl (Postfix) with ESMTPSA id D81C1C3F2A54; Tue, 1 Mar 2022 13:19:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 ni.piap.pl D81C1C3F2A54 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=piap.pl; s=mail; t=1646137161; bh=kSabZj2uSQjgkFczSZMvF3bJRihRCuN2IOOpNDYapls=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=npohYuiYKQrXVL3bxAXH92cQ4bKwu1JU2dbQkAHuNe2mbrOCzB4CGM7rSyiUvFgRi 00EWp3RezZb3EjsKrDNR0lV6Q7xFr80zE3T/6Zh2dj7UkGMlu4y8y4KfYtB54dAlxX 9Qnl2Rvf+QHYzZlTkCE9cMR7N7CVV+291V3beeIM= From: =?utf-8?Q?Krzysztof_Ha=C5=82asa?= To: Jacopo Mondi Cc: Mauro Carvalho Chehab , Rob Herring , devicetree@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Sakari Ailus , Joe Perches Subject: Re: [PATCH v7 2/2] Driver for ON Semi AR0521 camera sensor References: <20220109153439.bfnfigocaeeeghmp@uno.localdomain> <20220301090132.g5xsodoeotcm6h2q@uno.localdomain> Sender: khalasa@piap.pl Date: Tue, 01 Mar 2022 13:19:20 +0100 In-Reply-To: <20220301090132.g5xsodoeotcm6h2q@uno.localdomain> (Jacopo Mondi's message of "Tue, 1 Mar 2022 10:01:32 +0100") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-KLMS-Rule-ID: 3 X-KLMS-Message-Action: skipped X-KLMS-AntiSpam-Status: not scanned, whitelist X-KLMS-AntiPhishing: not scanned, whitelist X-KLMS-AntiVirus: Kaspersky Security for Linux Mail Server, version 8.0.3.30, not scanned, whitelist X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jacopo Mondi writes: >> They can. It appears, though, that clusters aren't about controls which >> can't change independently. Both of the two are written to the hardware >> at the same time, which appears to be a valid reason to combine them >> into a cluster. > > Is there a reason to write them to hw at the same time ? :) Sure, they are written in a single merged burst on I2C. > As it doesn't seem to me you access registers during probe (to > identify the sensor in example) there's no need to power up the device > during probe, but should be enough to let runtime_pm do so when > requested. Yes, in fact I never try to read anything from the sensor :-) Unfortunately I'm not sure how to initialize the (possibly nonexistent) PM without powering it up, cleanly, in all kernel configs. I mean, I can check if PM failed and power it up "by hand", but it's a bit messy. Suggestions are welcome, though. --=20 Krzysztof "Chris" Ha=C5=82asa Sie=C4=87 Badawcza =C5=81ukasiewicz Przemys=C5=82owy Instytut Automatyki i Pomiar=C3=B3w PIAP Al. Jerozolimskie 202, 02-486 Warszawa