Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp3778615pxm; Tue, 1 Mar 2022 05:23:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJztAXpzJtbDxrx4KaEC9OuNW1TSAccUp4G76n0gTfm0wiG2vosgXjcMvTYLwg8REXP8wMgm X-Received: by 2002:a17:907:6d82:b0:6d6:da31:e542 with SMTP id sb2-20020a1709076d8200b006d6da31e542mr4718083ejc.135.1646140984246; Tue, 01 Mar 2022 05:23:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646140984; cv=none; d=google.com; s=arc-20160816; b=m2nD2eAccuJnoVV8juLmpwE4jO0ZEeB9ax939y7cX12vaZCfUnHpQWAdtsyWIX16jg n6Sgj3luVXz+9AFmdaribyldgm7fUeFR/5HTEsg9fgnpuBhj97Z8qj4Bc+EkaVK193lu 2FAMFfVTvEPbvrJpJe5eQ7tA4pRugeN8e88vVFQBzjWmq3EgJCWeZHCwgYmVpuAo2w1j VK7qm0rwKNrtHx3OarntR4qo7+uU6rhdV2OipXr3TP7mXuJraVMddLz53PWm+VMmRTMe QWOcDgRx1zqRwLc6RAVvb769NU+/BUMexKFFTiCP1GnUEmExo3XKXgTpO1Q27ttrM/Lg UZKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=qCTQvEeDzSI3MqPdpA972plkpD3y6k1Iyb6GA3oxAKA=; b=SNwO3Lpzxb2kbx+Xg8TbmdX2tOg/BkJ7exa7J2KfOFizAyFvlau1iqkbfanVaXpCTF OnViarQy1mSxUh52j7QDsFJE/2mwgr43f8t1Qz9RqNjI7dGJMtsTMvrYUHuhRNaS1RG9 wha7yd9qUMtFvtDE0hTIfVnaOWvLtF89Kma5ocoDIPOeuPQqeyotWw1ylUTnxm/J+rOu 6R29TKWXZg5W5JM2bR6yWXH0ptbjn+xIWuUOVFEy+QshBE6NvutjDvRXN9Z1BeKz1r4p 2eH0NIKZtnsnQQw6aAo/DRCQ/PFeLh/cRtFhUHEtI9JXERqUVrxDxONYL10Uz0cA8JFp tyJQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h12-20020a170906718c00b006d07a7e991csi8159192ejk.630.2022.03.01.05.22.41; Tue, 01 Mar 2022 05:23:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233929AbiCAJjk (ORCPT + 99 others); Tue, 1 Mar 2022 04:39:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231645AbiCAJji (ORCPT ); Tue, 1 Mar 2022 04:39:38 -0500 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC3591C92C; Tue, 1 Mar 2022 01:38:57 -0800 (PST) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1nOyxu-0000OC-Cj; Tue, 01 Mar 2022 10:38:42 +0100 Date: Tue, 1 Mar 2022 10:38:42 +0100 From: Florian Westphal To: cgel.zte@gmail.com Cc: pablo@netfilter.org, kadlec@netfilter.org, fw@strlen.de, davem@davemloft.net, kuba@kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Minghao Chi , Zeal Robot Subject: Re: [PATCH] net/netfilter: use memset avoid infoleaks Message-ID: <20220301093842.GE12167@breakpoint.cc> References: <20220301081824.2053310-1-chi.minghao@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220301081824.2053310-1-chi.minghao@zte.com.cn> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cgel.zte@gmail.com wrote: > From: Minghao Chi (CGEL ZTE) > > Use memset to initialize structs to preventing infoleaks > in __bpf_mt_check_bytecode What infoleak, care to elaborate? I don't see where this gets returned to userspace, its on-stack struct?