Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   =?utf-8?Q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>
To:     Jacopo Mondi <jacopo@jmondi.org>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Sakari Ailus <sakari.ailus@iki.fi>,
        Joe Perches <joe@perches.com>
Subject: Re: [PATCH v8 2/2] On Semi AR0521 sensor driver
References: <m3pmn66pie.fsf@t19.piap.pl> <m3h78i6p4t.fsf@t19.piap.pl>
        <20220301093107.ihokyp4xptkzpbpc@uno.localdomain>
Sender: khalasa@piap.pl
Date:   Tue, 01 Mar 2022 13:34:28 +0100
In-Reply-To: <20220301093107.ihokyp4xptkzpbpc@uno.localdomain> (Jacopo Mondi's
        message of "Tue, 1 Mar 2022 10:31:07 +0100")
Message-ID: <m38rtt7sx7.fsf@t19.piap.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Jacopo Mondi <jacopo@jmondi.org> writes:

> In subject
>
> "media: i2c:"
>
> Same for 1/2 where permutation of "media: dt-bindings: i2c:" are used
> when adding bindings for media i2c drivers.

You know, it's rather hard to know all these tiny requirements. Let
alone get them right all the time.

>> +	pm_runtime_set_active(&client->dev);
>> +	pm_runtime_enable(&client->dev);
>> +	pm_runtime_idle(&client->dev);
>
> Do you have an _idle() callback ? This seems a no-op to me, or am I
> mistaken ? (runtime_pm is still cryptic to me sometimes)

Do you mean only the pm_runtime_idle()? Sakari just requested I add it.

> Can't you just remove power_on() if it's not needed ?

It wouldn't work without CONFIG_PM then, would it?

> There still are a few checkpatch warnings which might be worth
> considering  but nothing huge.

Do you mean this?

WARNING: Block comments use * on subsequent lines
#411: FILE: drivers/media/i2c/ar0521.c:351:
+               /* Reset gain, the sensor may produce all white pixels with=
out
+                  this */

WARNING: Block comments use a trailing */ on a separate line
#411: FILE: drivers/media/i2c/ar0521.c:351:
+                  this */

... which are about a single comment which I had to wrap to fit in 80
columns, hardly a block comment by my standards. Not to mention Linus
saying...
--=20
Krzysztof "Chris" Ha=C5=82asa

Sie=C4=87 Badawcza =C5=81ukasiewicz
Przemys=C5=82owy Instytut Automatyki i Pomiar=C3=B3w PIAP
Al. Jerozolimskie 202, 02-486 Warszawa