Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp3844023pxm; Tue, 1 Mar 2022 06:32:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJzarSEUZoZdpbKKlLecrtTqV3SLX02JePF5nwd1EzK+PEFxmUlaJrhx+VWqdkJBpMUkmH68 X-Received: by 2002:a17:906:5e4f:b0:6d6:e3d0:e558 with SMTP id b15-20020a1709065e4f00b006d6e3d0e558mr3151008eju.118.1646145175352; Tue, 01 Mar 2022 06:32:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646145175; cv=none; d=google.com; s=arc-20160816; b=sM7FzEe7RFrBs2CzPTGlEaFVUHhQTid52hne/Ad9kNkm0a8M85+WboVM+CDx4kkpog VaVnxjksQs4AWc4WmstdkmEDwmqKhhRluJVQ9AA6VzbbrUggsj7nQhVyuGGxibdkBLuR ITiGqU8Z9cfbi6cZ6XrIN7gFlzGTNMb3Cil3BeASRsVLsoTU35bhk6T/Z5Q5qnbbXoPs Cp816c9ZQrzOB03ULTntNs6JVx6mk4X5e7TIapewwMEyYaqWyXqyl39lrhZox0JbuD4Z XlOzL5SbDPew7fPj7I/AiYINvRwkZ2yn2CcukmcQn/HCHkHxHz/t3nvyODqFOzQIDw3k nYKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=dEZeDrjsIzY0RrTo4uH6LCxsW77wAiB3aeEDQoZvGb0=; b=Na2xrwYONAR2eq7c33sUXS8HAp8o5bYm8UiPqJQZQ3I4tB9DU+8oqQe2eUiIAG4JCw aGJAlfEmbi3SMXhthVP0zkwMCwnlfhDjDC79afgJDfMdmMK8VdOM5vOHmce7LHkK7p0w 72ASKBS3o6eCcujVszFHE1+vcHLKVquk4TfgztR4zSeutjs3VomZUz2TdusmwiC+UzFz +lakfs4jkBFRuIcKc6Bab6gEtIc6YwMj+pZzsFvCYgWqmbvlJr7BVAAeIhnMJ+WXcSwy Lk+tEulYv43cbTn4veFTsNHBBdpdb2nbx31krev6BY7r5D43I1F4yf1TKpWiLarEXSlc R5+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@metanate.com header.s=stronger header.b=y26oi8DU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=metanate.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r8-20020a170906548800b006d13cc51518si8597486ejo.199.2022.03.01.06.32.30; Tue, 01 Mar 2022 06:32:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@metanate.com header.s=stronger header.b=y26oi8DU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=metanate.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234881AbiCAM6s (ORCPT + 99 others); Tue, 1 Mar 2022 07:58:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230415AbiCAM6r (ORCPT ); Tue, 1 Mar 2022 07:58:47 -0500 Received: from metanate.com (unknown [IPv6:2001:8b0:1628:5005::111]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 673C013F2F; Tue, 1 Mar 2022 04:58:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=metanate.com; s=stronger; h=In-Reply-To:Content-Type:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description; bh=dEZeDrjsIzY0RrTo4uH6LCxsW77wAiB3aeEDQoZvGb0=; b=y26oi 8DUfY7wPVY+Btl2Z6xXD1TtHWrqBS1unDolNzksxqZxi3zr8h7YoSNuGHxoSRtPUmssh7+OQXZnYx 3+RGVbJnV1oaYxSAVkQPJSVOKou2Z9XBxPfSE0B8SP/DYjBBo0lQ+0WEn7iZ/SBpM+O9zO7cx10DZ rJuvoFVtc+Trtu1PTmPEFos0fj1SuHz0HADTZCl30sV/GnUIy/xiP0i6vLggJ9IpGdHj3gktvX8wg HZCwx3ohPfypPIFhCwrtTa95V3S5s3FsbQ/T44lQ4uVrEfblktLXmkDopeAZPcApWFLco3QMIXlQF jgNS7o3Ggqpu2opvedY9VqDJxSb9w==; Received: from [81.174.171.191] (helo=donbot) by email.metanate.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1nP249-0007q7-6Q; Tue, 01 Mar 2022 12:57:21 +0000 Date: Tue, 1 Mar 2022 12:57:16 +0000 From: John Keeping To: Corentin Labbe Cc: heiko@sntech.de, herbert@gondor.apana.org.au, krzysztof.kozlowski@canonical.com, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH 10/16] crypto: rockchip: rework by using crypto_engine Message-ID: References: <20220228194037.1600509-1-clabbe@baylibre.com> <20220228194037.1600509-11-clabbe@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220228194037.1600509-11-clabbe@baylibre.com> X-Authenticated: YES X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RDNS_NONE,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 28, 2022 at 07:40:31PM +0000, Corentin Labbe wrote: > Instead of doing manual queue management, let's use the crypto/engine > for that. > In the same time, rework the requests handling to be easier to > understand (and fix all bugs related to them). > > Fixes: ce0183cb6464b ("crypto: rockchip - switch to skcipher API") > Signed-off-by: Corentin Labbe > --- In addition to the warnings reported by the kernel test robot, this needs to add select CRYPTO_ENGINE to Kconfig for the Rockchip driver. Regards, John