Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d38a8950-af24-6b8a-c09f-24f539328a95@wolfvision.net>
Date:   Tue, 1 Mar 2022 15:30:01 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH v4 0/8] enable usb support on rk356x
Content-Language: en-US
To:     Peter Geis <pgwipeout@gmail.com>
Cc:     linux-rockchip@lists.infradead.org, heiko@sntech.de,
        jbx6244@gmail.com, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
        Felipe Balbi <balbi@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
References: <20220228135700.1089526-1-pgwipeout@gmail.com>
From:   Michael Riesch <michael.riesch@wolfvision.net>
In-Reply-To: <20220228135700.1089526-1-pgwipeout@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHJJbS9HZWl1VVVyM1N0aG5jQXBhQkhKT0Z6NlpacnNBL2QyV0NPQ2s0TEt4?=
 =?utf-8?B?SUdYVklPbVVUS3FGYjVMS3pGOWtVNWZJOHU3dDA1dWdOOEx6dG9nWGpUM2lo?=
 =?utf-8?B?WE1jV05VQnJZWHUxd3hRYUEveEgwVDFpT2dhVngvVnZpUkpoeUN5VkpxT1A0?=
 =?utf-8?B?QUtNb0JRUlp0OERFVnJGNVU2RzBSYmN5UVM4enFvY3pXS29wbVFmNlRSMG9j?=
 =?utf-8?B?N0VDRTlLV2JkZm8wcCtGdXNJdWtJNEx4eXBLczhrU0g2SjJ4M285d0NmM2M1?=
 =?utf-8?B?YzFuMFRZb2J6bGRoYStFcG9XOEtHT0NlUEZhakpjVnIxRm16azM2elNISUE4?=
 =?utf-8?B?SEdKZXlpc3hLQldmdGN3VWhNL2o5MFNNWEY3cGd6aTZxcjBESFIxOWxaTjI5?=
 =?utf-8?B?WUdOVllHQktPUXhYdm9JbjR3SjRDc1BMMVRxMzJGc2o1ZHlGTDBGM2Q0dHRy?=
 =?utf-8?B?ZGRmZ2s2Tlhkd2dobG1jZmJNcEFtZ2RxeGFvV2ZpenhjbEt5RGs1VmJWVFZI?=
 =?utf-8?B?YSt6NDh0ZmtTZUdNcEFNSHg3d2x3aytIc0ZlcHRIVCtKRUNZdE9SY2h0YkNn?=
 =?utf-8?B?bGJHMjI3QmkyTkgxZ3QzYlpXSHJEU0hmK05oTGU2UWx5eWpLaFdkek5Eb0t3?=
 =?utf-8?B?cmI4MDFoYXpZYnV2TFlUZ0JBMDBDRUdUZWZ2NDJLTk5Qc29heWNKYUhhS3pz?=
 =?utf-8?B?OWlYOEg0SzFIL0F3a1lvN1o4ZzJVbzJWamI1M3c4a3R1emdZZzV4NWFudVhE?=
 =?utf-8?B?TWZlSlJVc0dJNEhxVXJZaVVpNzdUdHd1QWViQVR1cGpKU1lkZ2UxeVkxbTFN?=
 =?utf-8?B?N1VhWVpQeUw2R2NuZnhQN2RWSG53bkx3czRhcVBVMDZjMGlVaDJEaTRrR3NL?=
 =?utf-8?B?RU9VWFF5L3lpUlBaRVE0b1AyYVc2R0hTMkFUZlpLdHdvYUIzVEh4SkFDUktO?=
 =?utf-8?B?eVgrYWdyWG5Qbzl2RXdrWUtpL0Npck5TQTdrbmExRzl3ejhlS0VEN0lkSkJI?=
 =?utf-8?B?d0NkU2NFSEZZZVhPTVlVVlpnelN0bmZlTjJiN0tEdSt6OG9HbHhZQ25qLy9k?=
 =?utf-8?B?bXIzN3J4cVBPL0dtYTc5R3F5a0JyQ3pkdGdwT0IvRmJNc0grTkNGb2EyV3VS?=
 =?utf-8?B?RDFBamVqNXpKM0lYRVQzcU5ySms0dzdFMzhRNmFwY2hZZnlGL2pYQmNSMnYy?=
 =?utf-8?B?ZnRqTURvcFVYVTRHMEJTYUEva2lLYTc0TWlRajZXeXVqQ0cyT2k3bExuUEVO?=
 =?utf-8?B?aUdhV1NCN2ZzMU84MHJ6M3crSStMQ0psNEpGNERIanFGTzh0ZC96VGsyY0JS?=
 =?utf-8?B?bGYzY0xZalg2UTQ0K0VTSkdYUEVLQTRHWnorME9CQ0NaOC9IT05LVXJTUDNw?=
 =?utf-8?B?M3dVY0tHNE8ycFZyRDdwc0FBRTViaFUrOXl0bmdqY3NPOGJiOHQzdU5VdWpi?=
 =?utf-8?B?MjJXSEVUdnVXWXM5ZWMzK1ZxN3ZGY0VUb0pHcHBhTTdpVVR1NE9NdlVDZTlF?=
 =?utf-8?B?NjRWb0xMcENNWkZ1bFBTRjh4L2NHbXRKN0gxczZoMUJzQVA5MDcrSTBlVzJE?=
 =?utf-8?B?ZExWQklHS29GWGxCUjFrbkgzdzVTeUx0a1JobTlQbXA3WEVibVhhaTFpQkdp?=
 =?utf-8?B?SFdiV3ZEMC9IdFpiTkNJSzJSOTJEeUs0M1puSGNucGZYS2UxT3ZaVmsvcnJ6?=
 =?utf-8?B?dm9icHc5Y01CaHNscUJmZ0t0UXNHK0gxUzF4dWhtclRncVkvZzBreU5VbHhy?=
 =?utf-8?B?bEZRYlZZN3BSNUdTOEs5WFVYbnp3eTRya0VNU2lYSklkRjh1aUtlMWRoaWZx?=
 =?utf-8?B?Q3MrNm9qN0VIZDBmalZ1VHJaajRoR09zd1V4WDd3K2k3YkNZZ2tlTmd5dmtI?=
 =?utf-8?B?TGFjekhqbmxVVXBiWUxKZEFTNVZsaW01eE16ODMzTDI5dUkzdmJRTXJsaUE2?=
 =?utf-8?B?c1R3SjZ4amNKMSswNGUvdGJvOEh3amdZRGhqUVFxLzlyTGFjejFTMzQrd0pC?=
 =?utf-8?B?c1lURWlBMWtOUWx5Q0lMV0s0QWtYSFlDZ2YzajZlbjI1VmQvMkRrMXBDZ0l2?=
 =?utf-8?B?a1BoVFJzN1NPbmZQY0FDZHpZRlBLV3RtM0cwN3JvYjMvUVFqaXByWWQzRlFP?=
 =?utf-8?B?bjVEa29HR2NBT3AwWDltU21TZHoxbWpCSlBnbDdlelNoM3VYRHkrdW9rcW5K?=
 =?utf-8?B?bGpXanZYWXdDMHpNRUpyUkFJUnJYWCtKUHpnNkFqQjY3VGNIMDN1TUVYMEJJ?=
 =?utf-8?B?M01sZjR4Tk83ZFhVM0pRelJ0RndTdDVtcW9CYTlkaFlYOGVwQmNGT1RGVjlH?=
 =?utf-8?B?WUZSNVBSeWF3a2dOM0NoSlk2MmhKOVZreFJTcWNXZlZIaTJrWk8zbzJEYjl1?=
 =?utf-8?Q?DS2lTA7Np6470k1k=3D?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 55a2a2f6-4217-435e-9d04-08d9fb8ff96a
X-MS-Exchange-CrossTenant-AuthSource: HE1PR0802MB2426.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 14:30:03.5075
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4lrHA5z5eYh5HvHK984R73OaRi5xPxwRr5CLl3+k9WH24CVQFk8V6UNGcGrEjmBn7l8eNmjxox1HL54Dqij00uwR5DkpdYY8rS15A1VaKnE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4436
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

On 2/28/22 14:56, Peter Geis wrote:
> Good Morning,
> 
> This is my patch series that I have maintained out of tree until the
> combophy driver landed.
> 
> Patch 1 fixes the grf dt binding from the combophy merge.
> Patch 2 adds the dt bindings for the grf changes necessary.
> Patch 3 adds the SoC specific binding.
> Patch 4 adds support to the grf driver to set the rk3566 otg clock
> source.
> Patch 5 is a downstream patch ported forward to shut down the usb3 clock
> when the controller is operating in usb2 mode.
> Patch 6 adds the dwc3 nodes to the rk356x device tree includes.
> Patch 7 enables the dwc3 nodes on the Quartz64 Model A.
> Patch 8 enables the dwc3 nodes on the rk3568-evb.

As far as the RK3568 EVB1 is concerned:

Tested-by: Michael Riesch <michael.riesch@wolfvision.net>

for the v4 of this series.

Thanks and best regards,
Michael

> 
> Note, there are functional changes from previous versions.
> 
> Please review and apply.
> 
> Very Respectfully,
> Peter Geis
> 
> Changelog:
> v4:
> - Add SoC specific binding, fall back to core.
>  
> v3:
> - Drop the dwc-of-simple method in favor of using dwc core.
> - Drop all quirks except snps,dis_u2_susphy_quirk, which is necessary to
>   prevent device detection failures in some states.
> - Drop the reset-names.
> 
> v2:
> - Add a dt-bindings fix for grf.yaml
> - Unify the reset names.
> - Constrain the force usb2 clock dwc3 patch to only supported variants of
> the ip.
> - Change dwc3-of-simple to support of-match-data.
> - Drop the PCLK-PIPE clk.
> - Rename the usb nodes to be more friendly.
> - Add the rk3568-evb enable patch.
> 
> Bin Yang (1):
>   usb: dwc3: core: do not use 3.0 clock when operating in 2.0 mode
> 
> Michael Riesch (2):
>   dt-bindings: usb: add rk3568 compatible to rockchip, dwc3
>   arm64: dts: rockchip: add usb3 support to rk3568-evb1-v10
> 
> Peter Geis (5):
>   dt-bindings: soc: grf: fix rk3568 usb definitions
>   dt-bindings: soc: grf: add rk3566-pipe-grf compatible
>   soc: rockchip: set dwc3 clock for rk3566
>   arm64: dts: rockchip: add rk356x dwc3 usb3 nodes
>   arm64: dts: rockchip: enable dwc3 on quartz64-a
> 
>  .../devicetree/bindings/soc/rockchip/grf.yaml |  5 +-
>  .../bindings/usb/rockchip,dwc3.yaml           |  2 +
>  .../boot/dts/rockchip/rk3566-quartz64-a.dts   | 37 +++++++++++++++
>  arch/arm64/boot/dts/rockchip/rk3566.dtsi      | 11 +++++
>  .../boot/dts/rockchip/rk3568-evb1-v10.dts     | 46 +++++++++++++++++++
>  arch/arm64/boot/dts/rockchip/rk3568.dtsi      |  9 ++++
>  arch/arm64/boot/dts/rockchip/rk356x.dtsi      | 35 +++++++++++++-
>  drivers/soc/rockchip/grf.c                    | 17 +++++++
>  drivers/usb/dwc3/core.c                       |  5 ++
>  drivers/usb/dwc3/core.h                       |  1 +
>  10 files changed, 165 insertions(+), 3 deletions(-)
>