Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Mar 2022 16:15:57 +0100
From:   Wolfram Sang <wsa@kernel.org>
To:     Jan Dabros <jsd@semihalf.com>
Cc:     linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
        jarkko.nikula@linux.intel.com, andriy.shevchenko@linux.intel.com,
        rrangel@chromium.org, upstream@semihalf.com,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH -next] i2c: designware: Fix improper usage of readl
Message-ID: <Yh44rYi6m9csyF28@ninjato>
Mail-Followup-To: Wolfram Sang <wsa@kernel.org>,
        Jan Dabros <jsd@semihalf.com>, linux-kernel@vger.kernel.org,
        linux-i2c@vger.kernel.org, jarkko.nikula@linux.intel.com,
        andriy.shevchenko@linux.intel.com, rrangel@chromium.org,
        upstream@semihalf.com, kernel test robot <lkp@intel.com>
References: <20220218133348.628962-1-jsd@semihalf.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Mo3c/bK1NDR43rDM"
Content-Disposition: inline
In-Reply-To: <20220218133348.628962-1-jsd@semihalf.com>
Precedence: bulk


--Mo3c/bK1NDR43rDM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 18, 2022 at 02:33:48PM +0100, Jan Dabros wrote:
> Kernel test robot reported incorrect type in argument 1 of readl(), but
> more importantly it brought attention that MMIO accessor shouldn't be
> used in this case, since req->hdr.status is part of a command-response
> buffer in system memory.
>=20
> Since its value may be altered by PSP outside of the scope of current
> thread (somehow similar to IRQ handler case), we need to use
> READ_ONCE() to ensure compiler won't optimize this call.
>=20
> Fix also 'status' variable type to reflect that corresponding field in
> command-response buffer is platform-independent u32.
>=20
> Signed-off-by: Jan Dabros <jsd@semihalf.com>
> Reported-by: kernel test robot <lkp@intel.com>

Applied to for-next, thanks!

Jan, I wonder if you want to be the maintainer for this driver? If you'd
like, then please send me the patch adding you to MAINTAINERS. So, you
will get notified if people want to enhance this driver.


--Mo3c/bK1NDR43rDM
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmIeOK0ACgkQFA3kzBSg
KbYsVA/9HFQWuNzVftyOlBekgZX9AAG3C/txBAtaKdpgvKzr8E3hsqUMmsEc1aVq
e2U8Ff81F1sM16kcq6uvSFVU2ExltUteo9moU6Uf2VZ2QPRkOgd57AfJGiWTAPDm
drGCNfiDqCpMe0fpLTjifI7Xz6vUW9vQr24TLAN0ivnyrVXIJKL9EQZXqUW5OsWB
eYbU4VIOgYMhIOcadobj0H/6dOSFCuvb/Er8YVFqpfYjqMRib6bykWFSjAyokQ+s
vbUgcJBMq8XuMSCPpvgDnL9F3Bwmv0Qy7kPUeLqCdaOkKubCOdkLOLWwACB5HU17
ks6E2IJyVu66ZG4Auvyhgt0A5m+uDnsV441ulFSa6+BXCbZQcxo/uBFfW3mnooSq
TMNY2E5k8EldMWg55qvrHPjvVQNsGVVNOiEYBzApGuIC8aPXpx7GqUWmopNI4qoA
nLc7bw3DznWOfFV7GT60k21oGLZOcTjTiAgyg6XYAjO+WjwwWgp/YqGwRhHdUyVr
28Vuh0u4t1FDr+ZxKzJHBZkIxqw3X+TTGd0Ia1mvknxNuI3Rb+xokHV8t8jIqSa+
krvEzSU/HOXDOhfV52BmzyvLhVFLaVE8M+wiTwqDoxb80PhTFct4ijnmmQsufF1C
AmoriBAaru4OG5dFNm5ODRGIE01JPq95dtb0uMg4yHXuvLSqusE=
=z0SK
-----END PGP SIGNATURE-----

--Mo3c/bK1NDR43rDM--