Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
References: <20220228135530.6918-1-yu.tu@amlogic.com>
 <29b34655-f820-39c9-4363-878481cd3f63@baylibre.com>
 <Yh087tJhakKHs88e@kroah.com>
 <8747c5c6-a129-3a26-8ebb-9e21a18236ec@baylibre.com>
 <96dc5932-7a4c-4f92-b33b-bfd7fc4477e8@amlogic.com>
User-agent: mu4e 1.6.10; emacs 27.1
From:   Jerome Brunet <jbrunet@baylibre.com>
To:     Yu Tu <yu.tu@amlogic.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
        Jiri Slaby <jirislaby@kernel.org>,
        Kevin Hilman <khilman@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
        kernel test robot <lkp@intel.com>,
        Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH V3] tty: serial: meson: Fix the compile link error
 reported by kernel test robot
Date:   Tue, 01 Mar 2022 09:33:15 +0100
In-reply-to: <96dc5932-7a4c-4f92-b33b-bfd7fc4477e8@amlogic.com>
Message-ID: <1jmtiavznx.fsf@starbuckisacylon.baylibre.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On Tue 01 Mar 2022 at 15:47, Yu Tu <yu.tu@amlogic.com> wrote:

> Hi Neil,
>
> On 2022/3/1 15:23, Neil Armstrong wrote:
>> [ EXTERNAL EMAIL ]
>> Hi Greg,
>> Le 28/02/2022 =C3=A0 22:21, Greg Kroah-Hartman a =C3=A9crit=C2=A0:
>>> On Mon, Feb 28, 2022 at 03:13:48PM +0100, Neil Armstrong wrote:
>>>> Hi,
>>>>
>>>> On 28/02/2022 14:55, Yu Tu wrote:
>>>>> Describes the calculation of the UART baud rate clock using a clock
>>>>> frame. Forgot to add in Kconfig kernel test Robot compilation error
>>>>> due to COMMON_CLK dependency.
>>>>>
>>>>> Fixes: ("tty: serial:meson: Describes the calculation of the UART baud
>>>>> rate clock using a clock frame=E2=80=9C)
>>>>
>>>> As I already replied on V2 of this patch, you're invited to apply these
>>>> fixes directly
>>>> on the next version of your "Use CCF to describe the UART baud rate
>>>> clock" patchset
>>>> and not as a separate patch.
>>>
>>> No, this is broken in linux-next now as the path listed here is in my
>>> tree right now.
>> Oh, I wasn't aware you took this patchset.
>>=20
>>>
>>> I need a fix for it, or I can revert the original.
>> Please revert the whole patchset, it's not ready yet, neither fully=20
>> reviewed ands buggy
>> on old SoCs.
> I have tested that there is no problem with G12A and S4 boards. Can I mer=
ge
> them first and fix them later if there is any problem?

That's called a regression. That is not how we do things in mainline
There is still a lot of people using GXL boards. Those are still sold even.

>> Thanks,
>> Neil
>>=20
>>>
>>> thanks,
>>>
>>> greg k-h
>>=20