Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Mar 2022 12:46:25 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc:     Jiasheng Jiang <jiasheng@iscas.ac.cn>,
        codrin.ciubotariu@microchip.com, lgirdwood@gmail.com,
        perex@perex.cz, tiwai@suse.com, nicolas.ferre@microchip.com,
        claudiu.beznea@microchip.com, alsa-devel@alsa-project.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: atmel_ssc_dai: Handle errors for clk_enable
Message-ID: <Yh4VoWfDxUOBGRBg@sirena.org.uk>
References: <20220301090637.3776558-1-jiasheng@iscas.ac.cn>
 <Yh4BCPqPngcsvER1@piout.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="T6jZRfUnVsfwpi4G"
Content-Disposition: inline
In-Reply-To: <Yh4BCPqPngcsvER1@piout.net>
Precedence: bulk


--T6jZRfUnVsfwpi4G
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Mar 01, 2022 at 12:18:32PM +0100, Alexandre Belloni wrote:
> On 01/03/2022 17:06:37+0800, Jiasheng Jiang wrote:
> > As the potential failure of the clk_enable(),
> > it should be better to check it and return error if fals.

> As I already replied to an earlier patch, this will never, ever fail,
> this patch doesn't fix anything.

OTOH it doesn't do too much harm to have the error checking and it means
people don't have to check if this is a case where it doesn't matter.

--T6jZRfUnVsfwpi4G
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmIeFaAACgkQJNaLcl1U
h9A12gf/Z2ih09vgW44eyJevr+GSx5BKo89juYbnargXWju4kIefBm99v9d/V/iV
H72bbmH2hR1Ja5mbDlSKPvEnpQGknmuQl+CCcgMujjPOZ2xtnkriHaszCUkilvnq
sRswa4l2SYSXGAsz440VEgUA+QDAbObEn02uTqBv0Nf+kudu2WHqioSR6A75xlZ5
G3FTauzL+KDsFXhHQ36PydQUWb6W17kxYvvja/46qHvmNg2BejvbWCL/6T/j2myr
lnSc+4rw5jD6lB4ItVuUCS87enl5fqKkTZ7E4W5FciqpenCP7SGA8OsjuLSJ3roB
pRJmnX1i7THYcqMsjsjwAckc5MUE9g==
=s96X
-----END PGP SIGNATURE-----

--T6jZRfUnVsfwpi4G--