Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Mar 2022 15:16:05 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     "Michael Kelley (LINUX)" <mikelley@microsoft.com>
Cc:     Anssi Hannula <anssi.hannula@bitwise.fi>,
        KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hv_balloon: rate-limit "Unhandled message" warning
Message-ID: <20220301151605.j5zymunttpylphyn@liuwe-devbox-debian-v2>
References: <20220222141400.98160-1-anssi.hannula@bitwise.fi>
 <MN0PR21MB3098049BCEFAAEE5C61F589AD73E9@MN0PR21MB3098.namprd21.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <MN0PR21MB3098049BCEFAAEE5C61F589AD73E9@MN0PR21MB3098.namprd21.prod.outlook.com>
Precedence: bulk

On Fri, Feb 25, 2022 at 06:59:18PM +0000, Michael Kelley (LINUX) wrote:
> From: Anssi Hannula <anssi.hannula@bitwise.fi> Sent: Tuesday, February 22, 2022 6:14 AM
> > 
> > For a couple of times I have encountered a situation where
> > 
> >   hv_balloon: Unhandled message: type: 12447
> > 
> > is being flooded over 1 million times per second with various values,
> > filling the log and consuming cycles, making debugging difficult.
> > 
> > Add rate limiting to the message.
> > 
> > Most other Hyper-V drivers already have similar rate limiting in their
> > message callbacks.
> > 
> > The cause of the floods in my case was probably fixed by 96d9d1fa5cd5
> > ("Drivers: hv: balloon: account for vmbus packet header in
> > max_pkt_size").
> > 
> > Fixes: 9aa8b50b2b3d ("Drivers: hv: Add Hyper-V balloon driver")
> > Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi>
[...]
> 
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>

Applied to hyperv-next. Thanks.