Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ioana Ciornei <ioana.ciornei@nxp.com>
To:     Yeqi Fu <fufuyqqqqqq@gmail.com>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Yongzhi Liu <lyz_cs@pku.edu.cn>
Subject: Re: [PATCH v1] dpaa2-switch: fix memory leak of
 dpaa2_switch_acl_entry_add
Thread-Topic: [PATCH v1] dpaa2-switch: fix memory leak of
 dpaa2_switch_acl_entry_add
Thread-Index: AQHYLXbrpNoj7tadT06hGmO+VilhEKyqwXqA
Date:   Tue, 1 Mar 2022 17:03:00 +0000
Message-ID: <20220301170259.zvcriwpmz2j73gyi@skbuf>
References: <a87a691a-62c2-5b42-3be8-ee1161281ad8@suse.de>
 <20220301141544.13411-1-fufuyqqqqqq@gmail.com>
In-Reply-To: <20220301141544.13411-1-fufuyqqqqqq@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wNKzhRrQwzBHRzV7CWLkX7b5FTo7BodIMbUN+8DKzMvwOn/qacQXE8qfZM/w?=
 =?us-ascii?Q?4mPlb+79KtRQDWbN8O5BOwyS2IVBSTpQ3+1971pk7g+D2CD/6PKgu29eksve?=
 =?us-ascii?Q?AZeprDzfYfFBmdiUKK3ae7YbCqbf3zvkhXtuZqviOVdfsOsvtqrVqYw05agg?=
 =?us-ascii?Q?jZDOCD24dhx7d+1AKukx1DsobnXKpMQTUsUkzwBoOC56EiafPipnu0/mLsN6?=
 =?us-ascii?Q?d3i3sy+UB9xj0KYnFAXkJbyMKTAOSdZickDcN/MscVSZ9+Xr9pB7WLEzkjiK?=
 =?us-ascii?Q?00NGVE/v62GNfMuJ9dWdLJr7qcLhvNhZoljKWWauiKed4DP9GbYk3dezYUN9?=
 =?us-ascii?Q?j3CaS6pofJu6wbkZp1EeX2XLeBddM2MJ/B+nxfxDiKb+Y96KTRzb1shcz9Jd?=
 =?us-ascii?Q?vVBrWBwYKvglafqwH3KVYIaOdpkDc7bQQQygVFtYiwxcgl/Mp6cb87A47tgD?=
 =?us-ascii?Q?vaQ0wlrYJPrw7pBUm3VyTgdkNd2KKWIth1lF9Nf8ZAFGh0YKLo6l+IeGGp+J?=
 =?us-ascii?Q?wjpoYF2TLKJQWOrMnnFNWJQyzhL48TNDZzN9/BXwBan5sRZjdi1fQOT1swpZ?=
 =?us-ascii?Q?Iic/dysX50qcfSwcOGzeX95Uswa22h6T+CHQUuU/H6FN3gwnbjHU2ONE6LAp?=
 =?us-ascii?Q?S8TcGURy5WIMGGdJWS+tkIgbk4neoHWPmscJLXFoWyulFiupvw6uwGJhQGGq?=
 =?us-ascii?Q?5C4LI2vMMEJiIg5IhEZw2Afk1XQs7mVf5eEggs9kEPEyqnkfo75d7TP9fOTv?=
 =?us-ascii?Q?7iyKlYXMKylcY0JUDn5Ih3PPL6bQ5gZWRzXdv2/m/98XhIXy5YxkD3VLPaGe?=
 =?us-ascii?Q?wVoxTFS06NCHl4wxuVbcp4Cm7Sil2K0FWu4nE15MVOfNlVLIKw/S8HMifpcg?=
 =?us-ascii?Q?4lVBMjRlkwl9x0zkcqU/kXUSXE3TybPJe6KyFSaApZKWg8aWtJ96bmbOnucM?=
 =?us-ascii?Q?+Tuk30v06ZquxdvLjpg4UUHD//Qtfe5RC0odPSj3DNFkPeIXDycU3/OWkmut?=
 =?us-ascii?Q?9QAguSDmolwboZl0o3Bm5+hwtaqDJnRH1K+SxLOBVn58IzI2XK4Z+I8mLE7l?=
 =?us-ascii?Q?bXoZV1t37yV8H1CD2aYttSYbutfE3nqNoEP64s2FwETG6hs/h0iQVvttbJG0?=
 =?us-ascii?Q?pmyU0Q65Q9uUcG24k+d3qtrF7ADEj6EhJhlBbEC5aq4Uj1L4+I1ZwbzXRK/J?=
 =?us-ascii?Q?pgLsuvbuAiG93ksquCmyhOEYHfvpqdcq4LMg3nZJKl58knEQWY3fuPxMI4LN?=
 =?us-ascii?Q?Cv8FvdB+M+vF/IOtGmkJw/JfROhxyZW2zqYVnO+p9PEkHuENjb2nf7kXYamD?=
 =?us-ascii?Q?OYdSjhF95laLQt/SnsXkKt98YThPLT3FfaZCyvEzdrS/vXIH4kJbO5NPtQkk?=
 =?us-ascii?Q?ZDFmMdOfzoGDCpH2c7PYrzmWxnOqo6ounePj7l98UohFbEosM5feJkOpCH3Y?=
 =?us-ascii?Q?Rqtgb1FAv2O+txnIhoPBngtORv0N/+ZT3p1GTaCDmfcxubiVxpnLaqUqYmVz?=
 =?us-ascii?Q?xndAFnTZ8OYur+WwcVo1WStlm+jRXW6Lxo3G+M4hplKFzS/V2FSelOve4Gm0?=
 =?us-ascii?Q?uxZVtrv2I1znDPCaLIwwS4u9Sa6fyyrzeMy30MtbVuB7pkyJ8aCoBIZomjZT?=
 =?us-ascii?Q?zO3XSTfedE2wbvZmchJm4mY=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5B40B3B38ADC14488D46113D484578FB@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8555.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c7296c38-f0bc-4f83-3fd0-08d9fba5573f
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2022 17:03:00.0480
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZwLLeDliIcCTbYeIwAnctfVWh9BfBwnGQLWsxWzgq4Xp90vAxZrno/k1JjTaL7oeiOmnX+QnZkwtsyrd7XzFfw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9507
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 01, 2022 at 10:15:44PM +0800, Yeqi Fu wrote:
> The error handling branch did not properly free the memory of cmd_buf
> before return, which would cause memory leak. So fix this by adding
> kfree to the error handling branch.
>=20
> Fixes: 1110318d83e8 ("dpaa2-switch: add tc flower hardware offload on ing=
ress traffic")
> Signed-off-by: Yeqi Fu <fufuyqqqqqq@gmail.com>
> Signed-off-by: Yongzhi Liu <lyz_cs@pku.edu.cn>

Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>

Just as a note, this should have been [PATCH v2] and not v1.

Ioana=