Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Mar 2022 12:39:52 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
        tangmeng@uniontech.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] ASoC: amd: Fix an ignored error return from
 platform_get_irq_byname()
Message-ID: <Yh4UGGuspsc/gAyY@sirena.org.uk>
References: <20220301064920.37788-1-yang.lee@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="uxmg+A5/E9EeDZt4"
Content-Disposition: inline
In-Reply-To: <20220301064920.37788-1-yang.lee@linux.alibaba.com>
Precedence: bulk


--uxmg+A5/E9EeDZt4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Mar 01, 2022 at 02:49:20PM +0800, Yang Li wrote:

> -	adata->i2s_irq = platform_get_irq_byname(pdev, "acp_dai_irq");
> -	if (adata->i2s_irq < 0)
> +	adata->i2s_irq = ret = platform_get_irq_byname(pdev, "acp_dai_irq");
> +	if (ret < 0)
>  		return -ENODEV;

If an error code is being returned we should report that error code
rather than squashing it down to -ENODEV.

--uxmg+A5/E9EeDZt4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmIeFBcACgkQJNaLcl1U
h9CFbgf/UYP8faM7a5tWC5+cSxh/9F9ahjHk7TXhiiQvjPIoYkrlThUWycOcaTSX
HJieKH2i6j9k3IjeZZcz37jTDi7xrczrqDXCe4KKEd8yx3+Ez7fnVdZIf71ffzKI
mZfaVT4VxwwImIaJRoDnHbx1a607Yj1AjiJz6fCA+s9LpXq8bF/cGd9TDtbdLm25
ya7GoTU3S/tasM1nU30vcvqXc0hBbZtwvt6I99WM24B5V1dxyUw0SUO4lXj59hSe
HipddydH6lpW/GojwROrEyaxawBNaB0W6GXhXkaXOFHw+nUzrILNp+Okjgf1HUS7
w8ZY4LHBFQ70HxHCzWC5/CRChrVCCw==
=rnGn
-----END PGP SIGNATURE-----

--uxmg+A5/E9EeDZt4--