Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp4153153pxm; Tue, 1 Mar 2022 12:24:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJwpKAVnITZpB5LV4U99gz4MGta9N/HL9p6L8BuA8CDWAi6qSl3fkaCjyIGeDkIm7mjdxiSa X-Received: by 2002:a17:90a:6c66:b0:1bc:52a2:18e8 with SMTP id x93-20020a17090a6c6600b001bc52a218e8mr23689095pjj.180.1646166284560; Tue, 01 Mar 2022 12:24:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646166284; cv=none; d=google.com; s=arc-20160816; b=arB4V70OgiqYANLjF4W9zbKDeDJ0Sliol2XKCd3xeHpBmcnO3DFuMVOWvv2iC92PMH ogTfoyw5haUQuEu7+O6K4ZcoyZqMYqd1m5uQytY0RAj9jJYDrOLcFBlx2aH9AqPXrsMp l1AwZCKA1YB//ADXqI6DNgSpecCeN7toIX47i/bRb+Ws4Ly7kKaP4wyEXeUoTnnVBEnX jTfvWAVoW92GMkI0yFIXgIqA4fc0+DCamMWZTtZysQknMauqRxbbU6Cla2uNlhf3STP+ 49l596fvNxfxETawUxSoGCdOYJVh8RL6SSxDCk9N/8yXpFhT8wSOwJj0IjBcfdbQLfrP KQhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=A7uGWoF4BIX4G7uGlBaz7mIppQlmmmgZ3uVpE0YdxbE=; b=q3vOBQ6rjQ9vDSqhmpBs/UVUKUBG4MBDnytqvfkx6v7uSvZDi7MOr4lQyHco4Z74mN Ay/tVLXL1kCh22NhJGmpdyhucsoAoOfxBwjhrgYg5+Xs1eF93FFXqY5b8t2VRrhuZ7PE A0GLDQHT1K8XiGPufTzzidWu7uFp3cqIof0OZNJgHrqsdHo2GVx4pmThoCPc/+axVPx/ 438HqifOwYUnmaecZkgsaVN/3W2zk+LdAUXFk9RXY+pGbLzX9igSwsuBsatoWYDA80SW sEc/7fXESt7Q/LZTrtmEQZj+6iWiJgHm3TmBFxfgRuUxyEYmzTtafVYgfwliul0H3dta rSfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Rnkv/AJd"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y25-20020a637d19000000b003742002abc1si13445604pgc.594.2022.03.01.12.24.27; Tue, 01 Mar 2022 12:24:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="Rnkv/AJd"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237162AbiCASql (ORCPT + 99 others); Tue, 1 Mar 2022 13:46:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237100AbiCASqb (ORCPT ); Tue, 1 Mar 2022 13:46:31 -0500 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D7FB6C93B for ; Tue, 1 Mar 2022 10:45:00 -0800 (PST) Received: by mail-pj1-x1029.google.com with SMTP id p3-20020a17090a680300b001bbfb9d760eso2668699pjj.2 for ; Tue, 01 Mar 2022 10:45:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=A7uGWoF4BIX4G7uGlBaz7mIppQlmmmgZ3uVpE0YdxbE=; b=Rnkv/AJd+5iy30mZzep7QXo8K/F/3SaVyLdc8rbCGNMsgsFv5IBT1c+gvLBRE6ku+w UwW2B20QOyzUAV/WYlAr69F6Ds/mAVIdJyKKpuGlLqQmrX0kscnL0Ee1JYzrWtxMXuxC HuFImbbTD3Ptoddk79DLRbZ5xEvhH6hzEqxwA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=A7uGWoF4BIX4G7uGlBaz7mIppQlmmmgZ3uVpE0YdxbE=; b=yTvaE3VIZDbjQwUSqaU3P05qQSsfYH779KzFBCshKOf6fbx3ne278Dus96ZfNQ46y7 u5hWwZNo3hrYkjPDUvZo2fR7UeGwUyCGsLTxef5NypAazvkxL/8pFschYj9a/wrQacpR qAY6z7zzQ7VC8Y+D6h6CQlfYtSlNAy+23PBjmVdb1ITJmcxtF5B54PGfEtalDRHjvF0u 99FJPwUpQv2crnfl14hlqs2VayV0IvgCaZSiWCserLsgk8diIaxMtWVUV6+d67iEj2ci tbBWiwegsh86JfXkJMTFhu47IuTBcVwvD/K6+A5LFFNJnd3U6v8IsCpha18jY3yoHVZo e+9g== X-Gm-Message-State: AOAM530UwrrhVXq16A/bCjovRTBjCDS998VRZHMWjOYQJS3123GkRk/E tv+I2u7ABNb9Yo0HHxjOTij83Sw0k7BybA== X-Received: by 2002:a17:903:1206:b0:151:7d67:2924 with SMTP id l6-20020a170903120600b001517d672924mr5587186plh.45.1646160299905; Tue, 01 Mar 2022 10:44:59 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id q7-20020a056a0002a700b004f357e3e42fsm17323387pfs.36.2022.03.01.10.44.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Mar 2022 10:44:59 -0800 (PST) From: Kees Cook To: Anton Vorontsov , Tony Luck , Colin Cross , Vincent Whitchurch Cc: Kees Cook , kernel@axis.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pstore: Add prefix to ECC messages Date: Tue, 1 Mar 2022 10:44:35 -0800 Message-Id: <164616027128.2800203.5940158670244885252.b4-ty@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220301144932.89549-1-vincent.whitchurch@axis.com> References: <20220301144932.89549-1-vincent.whitchurch@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Mar 2022 15:49:32 +0100, Vincent Whitchurch wrote: > The "No errors detected" message from the ECC code is shown at the end > of the pstore log and can be confusing or misleading, especially since > it usually appears just after a kernel crash log which normally means > quite the opposite of "no errors". Prefix the message to clarify that > this message is only about ECC-detected errors. > > > [...] Excellent point. :) Applied to for-next/pstore, thanks! [1/1] pstore: Add prefix to ECC messages https://git.kernel.org/kees/c/023bbde3db41 -- Kees Cook