Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <9f9107c06f7d065ae6581e5290ef5d72f7298fd1.1646132835.git.geert+renesas@glider.be>
In-Reply-To: <9f9107c06f7d065ae6581e5290ef5d72f7298fd1.1646132835.git.geert+renesas@glider.be>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Tue, 1 Mar 2022 14:16:28 +0100
Message-ID: <CAK8P3a3JvY=jcXGRRG+Eck2bkGRvb6_FTYZK+9RZS4Fw8y4eHA@mail.gmail.com>
Subject: Re: [PATCH] base: soc: Make soc_device_match() simpler and easier to read
To:     Geert Uytterhoeven <geert+renesas@glider.be>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Lee Jones <lee.jones@linaro.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Mar 1, 2022 at 12:10 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> The function soc_device_match() is difficult to read for various
> reasons:
>   - There are two loop conditions using different styles: "while (...)"
>     (which is BTW always true) vs. "if ... break",
>   - The are two return condition using different logic: "if ... return
>     foo" vs. "if ... else return bar".
>
> Make the code easier to read by:
>   1. Removing the always-true "!ret" loop condition, and dropping the
>      now unneeded pre-initialization of "ret",
>   2. Converting "if ... break" to a proper "while (...)" loop condition,
>   3. Inverting the logic of the second return condition.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---

Reviewed-by: Arnd Bergmann <arnd@arndb.de>