Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a87a691a-62c2-5b42-3be8-ee1161281ad8@suse.de>
Date:   Tue, 1 Mar 2022 15:14:16 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH] dpaa2 ethernet switch driver: Fix memory leak in
 dpaa2_switch_acl_entry_add()
Content-Language: ru
To:     Q1IQ <fufuyqqqqqq@gmail.com>, ioana.ciornei@nxp.com,
        davem@davemloft.net, kuba@kernel.org
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        lyz_cs@pku.edu.cn
References: <20220301093444.66863-1-fufuyqqqqqq@gmail.com>
From:   Denis Kirjanov <dkirjanov@suse.de>
In-Reply-To: <20220301093444.66863-1-fufuyqqqqqq@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


3/1/22 12:34, Q1IQ пишет:
> [why]
> The error handling branch did not properly free the memory of cmd_buf
> before return, which would cause memory leak.
> 
> [how]
> Fix this by adding kfree to the error handling branch.
> 
> Signed-off-by: Q1IQ <fufuyqqqqqq@gmail.com>

You should use your real name and please add Fixes tag

> ---
>   drivers/net/ethernet/freescale/dpaa2/dpaa2-switch-flower.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch-flower.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch-flower.c
> index cacd454ac696..4d07aee07f4c 100644
> --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch-flower.c
> +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-switch-flower.c
> @@ -132,6 +132,7 @@ int dpaa2_switch_acl_entry_add(struct dpaa2_switch_filter_block *filter_block,
>   						 DMA_TO_DEVICE);
>   	if (unlikely(dma_mapping_error(dev, acl_entry_cfg->key_iova))) {
>   		dev_err(dev, "DMA mapping failed\n");
> +		kfree(cmd_buff);
>   		return -EFAULT;
>   	}
>   
> @@ -142,6 +143,7 @@ int dpaa2_switch_acl_entry_add(struct dpaa2_switch_filter_block *filter_block,
>   			 DMA_TO_DEVICE);
>   	if (err) {
>   		dev_err(dev, "dpsw_acl_add_entry() failed %d\n", err);
> +		kfree(cmd_buff);
>   		return err;
>   	}
>