Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp196776pxm; Tue, 1 Mar 2022 18:26:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJyrvZvs5hlUMMxTYPaPnitVgTkkKkenNTFLsixOyAhd/EhB6fAP7ElhPcyh6aUyxqKrLWFO X-Received: by 2002:a17:906:a20c:b0:6ce:a87e:5013 with SMTP id r12-20020a170906a20c00b006cea87e5013mr20245229ejy.379.1646187967745; Tue, 01 Mar 2022 18:26:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646187967; cv=none; d=google.com; s=arc-20160816; b=WKSND9ZcQtH9VDuBuV0e7xk7xyYPwgmPKfL7n0ZjuMiqYpoVRlKg1Y/CQIO0DI7o1G Oxk81R0QGuQ6at+7cOy3xkRITnidjXYwBPotaRP/IcIEB7k1G7TJgeMDAQVYgFzmhy0E HXLLLbuHmKKBT0PESy9E7+gQMWFcn2hdL022Qumc4o6BKOn2xLUjWdcqXFUztRKv9Nor ls0gkcxr0ksc64l9s3LRUZuxv0XpWoohPJ70ZOevAEioqmi/miSazmr/0M+2f/oP9Q6e S38ZfWQt/aqXbW2pH2tLXHxbYmgxPg1t/ptwoZabG+3+qb/LceObIgMVYvrEl/8Y3b6l jpfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=YmaI1iZjYJQLLlwc10/LT8fdya0GVs5aArSct0D9LlE=; b=hyCnBHI+AohkDi79FRoIEVIeOpEoy0MdBMaAD5dq8VV1g82uPwMzuiH0Ck2O/PkkW0 PQylHKWjIkEPHgbjBHqzTmMfmignZyS+OVZYDn2ULZHWlXjreKxfi2HONDHNdxE8lPZ3 234OOIVeOSE8wy8KgWySq2t2SUIEf/ylW+Li9Xexu27GYnwmtVo14Qqx9uBT536UEAt8 DQfxX8HVLhuV5MzznrP5FKd0HCULAFmDH2TY9H25sztm4ax4alGHT+9+GwMEslwxkk7B 8mI4Oh1k5hA4QJP/FWljhFl04o8+dx8y6xCIAByE3/hj/ftTnyq40wA7udyASvButiUW 7YCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f5R3K7LQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m27-20020a50d7db000000b00415a1469e0asi1225738edj.364.2022.03.01.18.25.44; Tue, 01 Mar 2022 18:26:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f5R3K7LQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239011AbiCBCF5 (ORCPT + 99 others); Tue, 1 Mar 2022 21:05:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232069AbiCBCF4 (ORCPT ); Tue, 1 Mar 2022 21:05:56 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1753D5F241; Tue, 1 Mar 2022 18:05:15 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A7635615D3; Wed, 2 Mar 2022 02:05:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8382AC340EE; Wed, 2 Mar 2022 02:05:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646186714; bh=5i8Y5+dBeeL89jeI9/AO5sLou/tQrxrcO+QtYbCCKUc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=f5R3K7LQpxliNR5Lci0onOHclKiqth1ZuwJE+DSpmjDqYk+O6stDhcRJ5MX65Zioe NPTzlzD1OekD3KsA86i3EqwvToKi1cDnAUI4gVpVAd13m9DeT8al538iFv80R9/5bU 92oYPHZjTkfdOSoB6oyMevjeC3si3MaMeC7uCuqAzgg4OrpSlytHbenOyU4xV1S4vE bGy5KhHr0o9kkzbkSpNxG+TVpVElHfkkgucfpNfLYLDNTxdkLmNTpGHj/6i/UX2NeO fDGriUvcdbAh8sQwaF1U59Cu30oVk761nMWSG8RNn7GK/yK1TCXs+kFvJxUcAD9CDn tla4rME8QEXYg== Date: Tue, 1 Mar 2022 18:05:12 -0800 From: Jakub Kicinski To: Harold Huang Cc: netdev@vger.kernel.org, jasowang@redhat.com, edumazet@google.com, Eric Dumazet , "David S. Miller" , "Michael S. Tsirkin" , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-kernel@vger.kernel.org (open list), kvm@vger.kernel.org (open list:VIRTIO HOST (VHOST)), virtualization@lists.linux-foundation.org (open list:VIRTIO HOST (VHOST)), bpf@vger.kernel.org (open list:XDP (eXpress Data Path)) Subject: Re: [PATCH net-next] tuntap: add sanity checks about msg_controllen in sendmsg Message-ID: <20220301180512.06f7f6dc@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20220301064314.2028737-1-baymaxhuang@gmail.com> References: <20220301064314.2028737-1-baymaxhuang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Mar 2022 14:43:14 +0800 Harold Huang wrote: > In patch [1], tun_msg_ctl was added to allow pass batched xdp buffers to > tun_sendmsg. Although we donot use msg_controllen in this path, we should > check msg_controllen to make sure the caller pass a valid msg_ctl. > > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fe8dd45bb7556246c6b76277b1ba4296c91c2505 > > Reported-by: Eric Dumazet > Suggested-by: Jason Wang > Signed-off-by: Harold Huang Would you mind resending the same patch? It looks like it depended on your other change so the build bot was unable to apply and test it.