Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5d3acf32-9875-de6d-7495-5e4860fb88f1@nvidia.com>
Date:   Tue, 1 Mar 2022 17:53:49 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH v2 net-next 03/10] net: bridge: mst: Support setting and
 reporting MST port states
Content-Language: en-US
To:     Nikolay Aleksandrov <razor@blackwall.org>,
        Tobias Waldekranz <tobias@waldekranz.com>, davem@davemloft.net,
        kuba@kernel.org
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Ivan Vecera <ivecera@redhat.com>,
        Russell King <linux@armlinux.org.uk>,
        Petr Machata <petrm@nvidia.com>,
        Cooper Lees <me@cooperlees.com>,
        Ido Schimmel <idosch@nvidia.com>,
        Matt Johnston <matt@codeconstruct.com.au>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        bridge@lists.linux-foundation.org
References: <20220301100321.951175-1-tobias@waldekranz.com>
 <20220301100321.951175-4-tobias@waldekranz.com>
 <53EED92D-FEAC-4CC6-AF2A-52E73F839AB5@blackwall.org>
From:   Roopa Prabhu <roopa@nvidia.com>
In-Reply-To: <53EED92D-FEAC-4CC6-AF2A-52E73F839AB5@blackwall.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UDB5U3BJTDJLUDVSbCszQ0loaU95MUlOeW5pTmx3d1dyRjVSb0EyWVV5Ti95?=
 =?utf-8?B?YmxnK3hQaUVDb3MyU1R2T0NzaWJoU1hjVENxMzNMUVE3WUsyc0xyajdELzlW?=
 =?utf-8?B?UkgwT2t2eTd4bXY1d2ZaSFFhZDZNdnFsU0hOTjQxZEdsRUZxSGwwVFJMc0gr?=
 =?utf-8?B?UTUxUFhJa1ppVHA0QmVjTnZ1RlM2V1BxeVNPd1RBVG5YQUxtWnNBeWV6NExX?=
 =?utf-8?B?THdTYUFtRHphTFJmeFFvNTFIR2xqVlMxdlU4SS9vZXpWTlNQUUdjelhySXNa?=
 =?utf-8?B?dkkySTJKZ3AvcXpka3ZpUFFQWk5kbmVid25XbHRycTZMSGZhNGxIbW9Ja2Zl?=
 =?utf-8?B?Qmt2SWJVSUxtNUUzeThFakN0N0xUZXZFR1ozdEpER3FwSnJWOUpxMEJZVysw?=
 =?utf-8?B?MDFVZklxVzdlWnoyTmJVTDd5VzR6cG9LeC9ndnVLYTR1WXptbGlLMTlweTRj?=
 =?utf-8?B?cTlqZGthOWJINWFScEZHTkZrSTlKZ1JTUnF1QzJDZXlUL08yUDJWNXZpUnZB?=
 =?utf-8?B?bmdQcVZZc1o1NVp0eUl0OWRnbGJsYWdkY3ZIYXJXWm8xdFdNR0tyVUxtc2lX?=
 =?utf-8?B?ZytvczJOYjYyemVERlNnNkl6ZVF3dzYydnc4WlFjNjlKUWs1VGk5YWcvU20v?=
 =?utf-8?B?cnZSU2FlRWI3T2pLTXZkTmVBY2w0WUVNWFYrSjJWVVZNYWY5ZzFFSzFMZWlG?=
 =?utf-8?B?YURwdmVpL2ZyMU1uQUVPUnZPYzQ0UUtsVGFxNTRFSlFCUkhabU5WdEN2YUtU?=
 =?utf-8?B?QTl4dXBPSDA3NzdvKzAzMnNWdUQ5T1JEblY3bER2Y3VZc0plNkYxN2lBZUFY?=
 =?utf-8?B?d1hVWW45VS95Y0lBaU1kSmdwSGpleEd5OCtuMFFDUmxuN0U5YzlPTGsvTTh6?=
 =?utf-8?B?cXIvbUtxK2dWdkNYUFFZSnlnenp4U2ltQXBjYXBVajNNc1ozRUxLaE0rOW9t?=
 =?utf-8?B?aUxRSTB0aWViVzgzTUU3QmZhSXZ1OENLeHg4M3VPczlhTm9WK01NbW1rd0ZK?=
 =?utf-8?B?c0lsK3M1K3lGaGRLbXczcmlsd2xhK0NRQ204czZuNkFKTzd1cVY2eXA1VGEv?=
 =?utf-8?B?MjVVVkl5NzFpaHJUQjIvTXdCRzFZS3BLQnAyOHdWcmdwTWpXY0ZLR0gzekhI?=
 =?utf-8?B?UkxiK1kya3BXM3Q3Vk1tWEI2VDFaTnFndjFQQUhsTS9pem0ySDlSSGRGSHlI?=
 =?utf-8?B?RkkvZnlMUC9sZTM2bXpBaHFuU21VUVUxVHQ0dVVUOHBTWnloTEVUeUZ0ME1s?=
 =?utf-8?B?MnVSZGpwVmRydHNZUDhoSUpMazdnMzNGZVhScUVYSitYbld2RmxSMEtYMDJ5?=
 =?utf-8?B?aDZ1N3pYR2ltVis3WVJqS2Z2c0V0b0VaTjlrS011NWFIME5WU2pCLzU1eGVJ?=
 =?utf-8?B?cW1CSmMvMTlPMXh6YnIwbUk0VVozclFVa0dPanRHbzRlR3VYZFdDUjBQYjRI?=
 =?utf-8?B?N0tKMHkyMjdYUGVtVkkveDFkbTREeUZDdHplNnBhWmVydTliM25aZHJYd3Yz?=
 =?utf-8?B?bjFOUDFodXMvZEJFWU80bDErcTVwUTBVZ2pDMTdNb2o4c0hxVzk5UzdHYlBu?=
 =?utf-8?B?VStHdmx1cW1qLys5UUFlZkliRkhZM1VyVHd3VW1mUEZMejJpZXlQT3RmemRT?=
 =?utf-8?B?WktIOXZna0NVSDArRlk2N2pMYnpiT0FJM1JDK3BUWmxGVCtkYTN1ZUdITnVi?=
 =?utf-8?B?OWVNczYwcDZ2WmpjcXo2ZlZLckdjclo5V2VWbjJBdVpudjR5cUJPSmpXL3ZU?=
 =?utf-8?B?dWYxQU9XbWh6RjdOR2F5Q09WK2Mwb2NjdzdsbDZPRjNOU2lJZmF4MWpXYUo1?=
 =?utf-8?B?ejBMRzYweDBaUDdnVm9rNEJEZjN4QUJYb2JIeHRVcVROTVpFRWdRVlQxVEV4?=
 =?utf-8?B?dVJwbFUyak5uSjl0ZkxHeTB0T2tuekViaC9wT3FIdzZjakliMit4MWwwdnlH?=
 =?utf-8?B?d01BbTFobXhrd1o5dFA5bUhCMUtraW5FUk5rVW5HS1ZmcXpvU2NrUm5RQVBx?=
 =?utf-8?B?bWNTdmxwdDJOSEJ3SXlIczBSbGFtOFY2YWxvLzdEZG9wLy9UMVFBSXFrajBp?=
 =?utf-8?B?TW9LNXJ2Z2VXbE9VU051Vms5bE1BYUZZbVRPWERvbHN5ZUg0WlcyajlzQTNv?=
 =?utf-8?B?WWZIZDFFQmhEbVZMR1QrYkgrRlorV2pkUnd1RVIvODVoUTROc0FIV0FJd2hl?=
 =?utf-8?Q?Szi3CivIQOKyYfF/uXNq3ro=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7315bb90-98b5-4ac2-2363-08d9fbef7fb8
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR12MB5504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 01:53:51.0352
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YqJCfvUibkpMBVnkJmPiAxjrjUzxHRE1L/oVbxQ9LxrukLei+uvIgeR/zpDBDU+6qGewINSxlqp0DAURRz3xXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4061
X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/1/22 15:19, Nikolay Aleksandrov wrote:
> On 1 March 2022 11:03:14 CET, Tobias Waldekranz <tobias@waldekranz.com> wrote:
>> Make it possible to change the port state in a given MSTI. This is
>> done through a new netlink interface, since the MSTIs are objects in
>> their own right. The proposed iproute2 interface would be:
>>
>>     bridge mst set dev <PORT> msti <MSTI> state <STATE>
>>
>> Current states in all applicable MSTIs can also be dumped. The
>> proposed iproute interface looks like this:
>>
>> $ bridge mst
>> port              msti
>> vb1               0
>> 		    state forwarding
>> 		  100
>> 		    state disabled
>> vb2               0
>> 		    state forwarding
>> 		  100
>> 		    state forwarding
>>
>> The preexisting per-VLAN states are still valid in the MST
>> mode (although they are read-only), and can be queried as usual if one
>> is interested in knowing a particular VLAN's state without having to
>> care about the VID to MSTI mapping (in this example VLAN 20 and 30 are
>> bound to MSTI 100):
>>
>> $ bridge -d vlan
>> port              vlan-id
>> vb1               10
>> 		    state forwarding mcast_router 1
>> 		  20
>> 		    state disabled mcast_router 1
>> 		  30
>> 		    state disabled mcast_router 1
>> 		  40
>> 		    state forwarding mcast_router 1
>> vb2               10
>> 		    state forwarding mcast_router 1
>> 		  20
>> 		    state forwarding mcast_router 1
>> 		  30
>> 		    state forwarding mcast_router 1
>> 		  40
>> 		    state forwarding mcast_router 1
>>
>> Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>
>> ---
>> include/uapi/linux/if_bridge.h |  16 +++
>> include/uapi/linux/rtnetlink.h |   5 +
>> net/bridge/br_mst.c            | 244 +++++++++++++++++++++++++++++++++
>> net/bridge/br_netlink.c        |   3 +
>> net/bridge/br_private.h        |   4 +
>> 5 files changed, 272 insertions(+)
>>
>> diff --git a/include/uapi/linux/if_bridge.h b/include/uapi/linux/if_bridge.h
>> index b68016f625b7..784482527861 100644
>> --- a/include/uapi/linux/if_bridge.h
>> +++ b/include/uapi/linux/if_bridge.h
>> @@ -785,4 +785,20 @@ enum {
>> 	__BRIDGE_QUERIER_MAX
>> };
>> #define BRIDGE_QUERIER_MAX (__BRIDGE_QUERIER_MAX - 1)
>> +
>> +enum {
>> +	BRIDGE_MST_UNSPEC,
>> +	BRIDGE_MST_ENTRY,
>> +	__BRIDGE_MST_MAX,
>> +};
>> +#define BRIDGE_MST_MAX (__BRIDGE_MST_MAX - 1)
>> +
>> +enum {
>> +	BRIDGE_MST_ENTRY_UNSPEC,
>> +	BRIDGE_MST_ENTRY_MSTI,
>> +	BRIDGE_MST_ENTRY_STATE,
>> +	__BRIDGE_MST_ENTRY_MAX,
>> +};
>> +#define BRIDGE_MST_ENTRY_MAX (__BRIDGE_MST_ENTRY_MAX - 1)
>> +
>> #endif /* _UAPI_LINUX_IF_BRIDGE_H */
>> diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
>> index 0970cb4b1b88..4a48f3ce862c 100644
>> --- a/include/uapi/linux/rtnetlink.h
>> +++ b/include/uapi/linux/rtnetlink.h
>> @@ -192,6 +192,11 @@ enum {
>> 	RTM_GETTUNNEL,
>> #define RTM_GETTUNNEL	RTM_GETTUNNEL
>>
>> +	RTM_GETMST = 124 + 2,
>> +#define RTM_GETMST	RTM_GETMST
>> +	RTM_SETMST,
>> +#define RTM_SETMST	RTM_SETMST
>> +
> I think you should also update selinux  (see nlmsgtab.c)
> I'll think about this one, if there is some nice way to avoid the new rtm types.

yes, since these are all port attributes, seems like 'bridge link set' 
should work

Tobias, can you pls check if extending RTM_SETLINK (with AF_BRIDGE) is 
an option here ?

ie via br_setlink