Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Mar 2022 15:17:44 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Jithu Joseph <jithu.joseph@intel.com>
Cc:     hdegoede@redhat.com, markgross@kernel.org, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        x86@kernel.org, hpa@zytor.com, corbet@lwn.net,
        gregkh@linuxfoundation.org, andriy.shevchenko@linux.intel.com,
        ashok.raj@intel.com, tony.luck@intel.com,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        platform-driver-x86@vger.kernel.org, patches@lists.linux.dev,
        ravi.v.shankar@intel.com
Subject: Re: [RFC 10/10] trace: platform/x86/intel/ifs: Add trace point to
 track Intel IFS operations
Message-ID: <20220301151744.1ad5e11a@gandalf.local.home>
In-Reply-To: <20220301195457.21152-11-jithu.joseph@intel.com>
References: <20220301195457.21152-1-jithu.joseph@intel.com>
        <20220301195457.21152-11-jithu.joseph@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue,  1 Mar 2022 11:54:57 -0800
Jithu Joseph <jithu.joseph@intel.com> wrote:

> +	TP_STRUCT__entry(
> +		__field(	u8,	start	)
> +		__field(	u8,	stop	)
> +		__field(	u64,	status	)
> +	),

I'd suggest swapping this to:

		__field(	u64,	status	)
		__field(	u8,	start	)
		__field(	u8,	stop	)

As trace events are usually aligned by 4 bytes (sometimes 8 for archs that
require 8byte alignment for 8 byte words), but any event, putting the
padding at the end of the event is better than in the middle of the event.

Having the u64 come after two u8 (two byes) will pretty much guarantee a 6
bytes hole in the middle of the event.

-- Steve