Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220223160708.88100-1-mark@yotsuba.nl> <303dc74a-4d63-70a2-9891-af3e3d8baf26@redhat.com>
In-Reply-To: <303dc74a-4d63-70a2-9891-af3e3d8baf26@redhat.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Tue, 1 Mar 2022 20:34:05 +0100
Message-ID: <CAJZ5v0gVN_nsB5eqfWzyG3+LyvAmOJKsVbA4_sOiAV+RnjG64w@mail.gmail.com>
Subject: Re: [PATCH] x86/acpi: Work around broken XSDT on SEGA AALE board
To:     Hans de Goede <hdegoede@redhat.com>,
        Mark Cilissen <mark@yotsuba.nl>
Cc:     ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        x86@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <len.brown@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Feb 24, 2022 at 9:41 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi Mark,
>
> On 2/23/22 17:07, Mark Cilissen wrote:
> > On this board the ACPI RSDP structure points to both a RSDT and an XSDT,
> > but the XSDT points to a truncated FADT. This causes all sorts of trouble
> > and usually a complete failure to boot after the following error occurs:
> >
> >   ACPI Error: Unsupported address space: 0x20 (*/hwregs-*)
> >   ACPI Error: AE_SUPPORT, Unable to initialize fixed events (*/evevent-*)
> >   ACPI: Unable to start ACPI Interpreter
> >
> > This leaves the ACPI implementation in such a broken state that subsequent
> > kernel subsystem initialisations go wrong, resulting in among others
> > mismapped PCI memory, SATA and USB enumeration failures, and freezes.
> >
> > As this is an older embedded platform that will likely never see any BIOS
> > updates to address this issue and its default shipping OS only complies to
> > ACPI 1.0, work around this by forcing `acpi=rsdt`. This patch, applied on
> > top of Linux 5.10.102, was confirmed on real hardware to fix the issue.
> >
> > Signed-off-by: Mark Cilissen <mark@yotsuba.nl>
> > Cc: stable@vger.kernel.org
>
> Wow, you got it working, cool!
>
> The patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Applied as 5.18 material, thanks!

> > ---
> >  arch/x86/kernel/acpi/boot.c | 25 +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> >
> > diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
> > index 5b6d1a95776f..7caf4da075cd 100644
> > --- a/arch/x86/kernel/acpi/boot.c
> > +++ b/arch/x86/kernel/acpi/boot.c
> > @@ -1328,6 +1328,17 @@ static int __init disable_acpi_pci(const struct dmi_system_id *d)
> >       return 0;
> >  }
> >
> > +static int __init disable_acpi_xsdt(const struct dmi_system_id *d)
> > +{
> > +     if (!acpi_force) {
> > +             pr_notice("%s detected: force use of acpi=rsdt\n", d->ident);
> > +             acpi_gbl_do_not_use_xsdt = TRUE;
> > +     } else {
> > +             pr_notice("Warning: DMI blacklist says broken, but acpi XSDT forced\n");
> > +     }
> > +     return 0;
> > +}
> > +
> >  static int __init dmi_disable_acpi(const struct dmi_system_id *d)
> >  {
> >       if (!acpi_force) {
> > @@ -1451,6 +1462,20 @@ static const struct dmi_system_id acpi_dmi_table[] __initconst = {
> >                    DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 360"),
> >                    },
> >        },
> > +     /*
> > +      * Boxes that need ACPI XSDT use disabled due to corrupted tables
> > +      */
> > +     {
> > +      .callback = disable_acpi_xsdt,
> > +      .ident = "SEGA AALE",
> > +      .matches = {
> > +                  DMI_MATCH(DMI_SYS_VENDOR, "NEC"),
> > +                  DMI_MATCH(DMI_PRODUCT_NAME, "Bearlake CRB Board"),
> > +                  DMI_MATCH(DMI_BIOS_VENDOR, "Phoenix Technologies LTD"),
> > +                  DMI_MATCH(DMI_BIOS_VERSION, "V1.12"),
> > +                  DMI_MATCH(DMI_BIOS_DATE, "02/01/2011"),
> > +                  },
> > +     },
> >       {}
> >  };
> >
> >
> > base-commit: cfb92440ee71adcc2105b0890bb01ac3cddb8507
>