DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
        b=kbGsoBwQvvkA5Hv4sALF3Vo/zKEzJyUbegPtGxuQHdcCusXWOyBV0RpgmURFN6s6JSk9ljhse5ZHv66C69myPInnQTIoXKGxW2gDc56KJtbHmzeVEfG6MJdcn1gVdHSqAyKQHuSZULGAE7QlTdEAob9ZOup7GBCzvYpywuYNhJM=
Message-ID: <84144f020702190313m38b670eew204a5017e777851e@mail.gmail.com>
Date: Mon, 19 Feb 2007 13:13:23 +0200
From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Artem Bityutskiy" <dedekind@infradead.org>
Subject: Re: [PATCH 12/44 take 2] [UBI] allocation unit implementation
Cc: "Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
       "Christoph Hellwig" <hch@infradead.org>,
       "Frank Haverkamp" <haver@vnet.ibm.com>,
       "Thomas Gleixner" <tglx@linutronix.de>,
       "David Woodhouse" <dwmw2@infradead.org>,
       "Josh Boyer" <jwboyer@linux.vnet.ibm.com>
In-Reply-To: <20070217165525.5845.78155.sendpatchset@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20070217165424.5845.4390.sendpatchset@localhost.localdomain>
	 <20070217165525.5845.78155.sendpatchset@localhost.localdomain>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 770
Lines: 26

On 2/17/07, Artem Bityutskiy <dedekind@infradead.org> wrote:
> +void *ubi_kzalloc(size_t size)
> +{
> +       void *ret;
> +
> +       ret = kzalloc(size, GFP_KERNEL);
> +       if (unlikely(!ret)) {
> +               ubi_err("cannot allocate %zd bytes", size);
> +               dump_stack();
> +               return NULL;
> +       }
> +
> +       return ret;
> +}

[snip, snip]

NAK. Please drop all of these utterly pointless kmalloc() and
kmem_cache_alloc() wrappers.

                                             Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/