Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp339920pxm; Tue, 1 Mar 2022 22:36:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJyuP4LlY/cwk2ut69zRqPZD5Z9WO/1ERmlIFKMKtBolB57kZ7c7iZmEpxpMDweJvNl+EN/D X-Received: by 2002:a17:90a:bb8d:b0:1bc:72a9:a07d with SMTP id v13-20020a17090abb8d00b001bc72a9a07dmr25311051pjr.9.1646203015763; Tue, 01 Mar 2022 22:36:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646203015; cv=none; d=google.com; s=arc-20160816; b=afUaK1kwRqxBoyN2Oa+tpbt2VZcZTLeV2l5kma0IXrDGSqOie3hmYWujhjgPWPIyWl De+F7Vg7RJMqGIIOqdRpvn8Vkhzb2pqYwUus3WtIDIs4wykL/y5fZqeZXrICqn0vOGjV E0rwsQBawCowGGBTPS99i2ta0BOGISIRrQ0fUk2y81JIUHl1Xa6L9vF85snehev3vMpA XeEvXyTbQ9asfMsxvjVJiB9IP3m80LJG1FywGJVMvjB3wVbEeRBcSpQBh0vNO1yzoEG7 IUw+Ls/p7IpUNMR8lX859N94Zpha6rafzx5jcLYVFYXhYs6dhR0GKxliXsQ9J47KQ7hM K/uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=okKXdzxNYrBkt9Gr9a7k02ZDdBXu/IZowtedgIowZms=; b=nI/27uA6NQntA6BqM3Dwd+AoMaWBjXo5doHenyDP3Z7RS8pByIchgbhDzcgnzVHJc/ VUvl95Ez+7xmMNQ3EDRVQNvD6G3OX7yvm5ETMIIz3cdBIrwaqNeGxzVXVhwDQtrd6OuI p+CUyGaeFAC2JXKISIA/S+wB/CEouP0azWyMMoOHYebSzpH+w4E29qd3Ln+dNOcZm6kq XrEGfZBDJcRP4BEDCCGbqO3JI7mmSZfzHtKIxg/KmSBFhcRy7HK+GQZbDPyqpVbeX4d9 EkR9VUTRv2KPMPiIymi0YgxRGtgUYlxOfkVOzo+B/qbizr0UnJX7cIIXrHHyJsWu/e75 7CCw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i8-20020a170902c94800b001513cd8eff3si13936973pla.125.2022.03.01.22.36.32; Tue, 01 Mar 2022 22:36:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239680AbiCBG0Q (ORCPT + 99 others); Wed, 2 Mar 2022 01:26:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230460AbiCBG0N (ORCPT ); Wed, 2 Mar 2022 01:26:13 -0500 Received: from cstnet.cn (smtp21.cstnet.cn [159.226.251.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 32A2856772; Tue, 1 Mar 2022 22:25:29 -0800 (PST) Received: from localhost.localdomain (unknown [124.16.138.126]) by APP-01 (Coremail) with SMTP id qwCowACHjPjCDR9iPrUDAg--.19038S2; Wed, 02 Mar 2022 14:25:09 +0800 (CST) From: Jiasheng Jiang To: kuninori.morimoto.gx@renesas.com Cc: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, f.suligoi@asem.it, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Jiasheng Jiang Subject: Re: Re: [PATCH v2] ASoC: fsi: Add check for clk_enable Date: Wed, 2 Mar 2022 14:25:05 +0800 Message-Id: <20220302062505.46727-1-jiasheng@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: qwCowACHjPjCDR9iPrUDAg--.19038S2 X-Coremail-Antispam: 1UD129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UjIYCTnIWjp_UUUYq7AC8VAFwI0_Xr0_Wr1l1xkIjI8I6I8E 6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28Cjx kF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW8JVW5JwA2z4x0Y4vE2Ix0cI8I cVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z2 80aVCY1x0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAK zVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Jr0_Gr1lOx 8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIF xwACI402YVCY1x02628vn2kIc2xKxwCY02Avz4vE14v_GF1l42xK82IYc2Ij64vIr41l4I 8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AK xVWUGVWUWwC2zVAF1VAY17CE14v26r4a6rW5MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcV AFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8I cIk0rVWrJr0_WFyUJwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14 v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfU59a9DUUUU X-Originating-IP: [124.16.138.126] X-CM-SenderInfo: pmld2xxhqjqxpvfd2hldfou0/ X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 02, 2022 at 12:35:02PM +0800, Kuninori Morimoto wrote: >> +disable_xck: >> + clk_disable(clock->xck); >> +disable_ick: >> + clk_disable(clock->ick); >> +err: >> + return ret; >> } > > I think disable_ick() / disable_xck() order are inverted ? Thanks, I will submit a v3 to solve it. Jiang