Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <dbe84151-e3dc-7a1a-6cb2-2021d8dfb461@oracle.com>
Date:   Tue, 1 Mar 2022 14:07:50 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [PATCH v4 07/10] crash hp: exclude elfcorehdr from the segment
 digest
Content-Language: en-US
To:     Baoquan He <bhe@redhat.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        kexec@lists.infradead.org, ebiederm@xmission.com,
        dyoung@redhat.com, vgoyal@redhat.com, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com,
        robh@kernel.org, efault@gmx.de, rppt@kernel.org,
        konrad.wilk@oracle.com, boris.ostrovsky@oracle.com
References: <20220209195706.51522-1-eric.devolder@oracle.com>
 <20220209195706.51522-8-eric.devolder@oracle.com>
 <YhWxeSG3GfJwOGOV@MiWiFi-R3L-srv>
From:   Eric DeVolder <eric.devolder@oracle.com>
In-Reply-To: <YhWxeSG3GfJwOGOV@MiWiFi-R3L-srv>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N1NRNGFHbzVJdHVuUHdLQVJTVHd4NEN4S0ZaWlVwaUtQZGJ1K1ljejd6SUxm?=
 =?utf-8?B?Y3E3M2JkY3BFczJ5ZDNHbytIR0pjNWN5MXJTWHhHNjhHelg5ZE52U0lmYW5i?=
 =?utf-8?B?RWhTYkdZWVpwTFIvUFlRYTViaWZ6V0dqNVpmcUFQdTI3UkN3aWk0RXJyVmhQ?=
 =?utf-8?B?NlE4N2l5QlpETVBhcjhZcUk2TGRoQnI3RGdVQUZYeEZpb2pzdmJOdktaNVVl?=
 =?utf-8?B?M2JCL1hDMzlFdkJNTGpObXRsNVh3ZHQ1NVR1Z2FJOU85aW10WmNNYUxKRmZ1?=
 =?utf-8?B?NTlzcXl2Y3dIU1llRlVMOTVSNzMzclJ0aU1KaDNSekN5NGg2VENZQ09KczBk?=
 =?utf-8?B?b0tjbFJCZlhQYjVnd0dHT0NVWHZFQlFod1VzTFEraU5KSVdadXExQlZMdnFv?=
 =?utf-8?B?TUx4TC80VGtGVmZVNk8yUXdFZWxSUTNxZDlQWC82RTA1OFlHRVlvSCtmVXZz?=
 =?utf-8?B?aCs0a3FpM1lHdG1uU1JMWTVweElvVzIyN2hURTBTbHhaR1YrZk93RHNZU0w5?=
 =?utf-8?B?TEo5NmYwb2dWcEkwVkgzRmUyVFZ2NW9TNTdHYjVSaUNNaXlVOVFxU0RYaUpZ?=
 =?utf-8?B?NW1zc0VSaVN2aHBUMUNtaFdyM2tvcnZMMnZnWG0rMXBGU09aN1dWamJzK29B?=
 =?utf-8?B?M2U1WFN4aVJOQ1BRUHBOY21zdXNaUDJrN0xTOEJVU1NKSk9VKy9WbzRJSWJj?=
 =?utf-8?B?eWp1Tm1wVjJ2WGVFb0xaTS9Pb3dkVjB4OU00ZzF2MmhNbmdmbGRRU3NrbjU2?=
 =?utf-8?B?V1d2aURtMXhQenY0YWNXUUV4cXErVTBzYWgrNWpXeHZqYm1sYk5Hc3MyNFN4?=
 =?utf-8?B?RXRBQytMNHpnQmlEREN2bWFOMTcvdXBGTVRSc2pZckJRUTRJY0tZV2V6Tlg1?=
 =?utf-8?B?OVp2YkZId2FwRGdRU21jV2xqTFR1S252cm9JeHZsWENBYktkUC92N3R1MmR3?=
 =?utf-8?B?aGxYcGs5a01mNDJGSVJVYjRjbkVMVGJWWWpOSFRoL3V4MDZXWWF4UDJVUUd0?=
 =?utf-8?B?U1JYQllJNFozejR5dytER2drTkQ2OUFIQmpZWUtwN1Z2SXhxQ214S1d5YnpK?=
 =?utf-8?B?Z1dpZnNWNmNlWFZYMEdFV2tudUpscnljTGU4bG9sTVd2ZHlnNnNnVVp6NHJ5?=
 =?utf-8?B?VXp5MHhNUjMrbE81Q25UR0FkUlhYZUlxMGlucDNoMWEySytOQW5lN0taQkpW?=
 =?utf-8?B?OVlBVEpHaHUveUZWRGdGSGs5cGtuQm02b1BJODBaRFB5Ri9mTWV0SnI4WUxL?=
 =?utf-8?B?V1hCdWx4bTdlR0xnZjBjODV4d0lwaXBkT1FSdWw2R24vZTd2dTk1WENnVlVU?=
 =?utf-8?B?cThBY0NnczQwZUkrT0VzcS9sRHFDbkpGaExHKytyMXJLUmxmdzBycC9qTDN1?=
 =?utf-8?B?VGxneUx2Rml0TmpteE5rTHExMlVkVVVQQVRPUS9HV29GSkV6SDB4WTVrZ3pp?=
 =?utf-8?B?eWYya29Ba3BNQ0pOUG5xRUhnZGhzQVBaYW9hbW9CQnY0MHBYL2UrTjlJRDBF?=
 =?utf-8?B?OXZYYW1GcGVYSG1vVDhqU1VmL3N6dkhkeEEwZHJrRXJkaVZBTDV5UzB2S09i?=
 =?utf-8?B?Z3pqVlpUZ25odTZZV1h3aVFPYmVPakxUZEdGcDNTdU9sckVaUHh4M3pHYUNs?=
 =?utf-8?B?d00rVWpGVmdqRWh4QnlEQXRSK3ZQcCttTFJOZFlOV0wyT2tZZ2dUR1NjS0lL?=
 =?utf-8?B?MUs2TGNzbjV1WWxVazVrVFh0RzFXSWE1eDZkK1d4M0Y0ZE5RVWFEWmNJZ3Vq?=
 =?utf-8?B?ZHJiWHVockZVbXhmYmt2NmtEcS94dm5yb1VNM055T0pGS2Q1NFpYVVlFUkhV?=
 =?utf-8?B?UHlmM1o0THZ4NW5pZTVYaVllR2FYZWxhYTNTQ1d2dis2NDdDSW43ZlpBVCtH?=
 =?utf-8?B?TFNod1FHRCsyZmxPZWRkZlgxNU5HTWFmR09ScllqeURpRFdYb2ZmQnh0ZHRU?=
 =?utf-8?B?RHJoYlBIUlU3U2lpOVZZSnk2dFFvRGR2d3N2dENEV0FFOXZzQkhvZU1NVTl2?=
 =?utf-8?B?RnZlZGI0aHFNTXFxK0VJd1B0ZG1NNmFwditUTGtmZXRuMTBSeTBtOGpVbEIw?=
 =?utf-8?B?R3NiTUJsZmFHVHJmQ1hzbSs4NDZtVlBDMmRzbDU0VUZacEtrREhkOGdHeGZj?=
 =?utf-8?B?RWl1YWJjTlROOFV2NVpGcUJrMmR2ajdOZ2M0bk9ZQXdrUFM2eE9QTWtKNXl0?=
 =?utf-8?B?V3h6VERhalB6Q1N6TGlma3ZJb3F3QTNwbStHMDNQR0dwdVdhTFNmSlBZM0Rn?=
 =?utf-8?B?UGphV3JQTWp0MXIzMWtIck94WnJicktsSS9EbW5oTFRNV0NNMW56YjZXTGxz?=
 =?utf-8?Q?9fSzpovKiGG99qVnFS?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7658833f-1390-487e-97f5-08d9fbbf2b7d
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4542.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 20:07:53.8799
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ER0WafbIJ70Nlh74sSC/yjHHgLZXNGjjPPVVrkKi2CV6OMomhGj/ItHiRUQplYZWDVbp54IRG01S9/SnyNYlPVe0Pn7qWg+hainisFx5eIY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2837
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10273 signatures=685966
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0
 adultscore=0 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2201110000 definitions=main-2203010101
X-Proofpoint-GUID: BpKXaHEFUye4FW0hJpwQBudEDj8LHdro
X-Proofpoint-ORIG-GUID: BpKXaHEFUye4FW0hJpwQBudEDj8LHdro
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2/22/22 22:00, Baoquan He wrote:
> On 02/09/22 at 02:57pm, Eric DeVolder wrote:
>> When a crash kernel is loaded via the kexec_file_load syscall, the
>> kernel places the various segments (ie crash kernel, crash initrd,
>> boot_params, elfcorehdr, purgatory, etc) in memory. For those
>> architectures that utilize purgatory, a hash digest of the segments
>> is calculated for integrity checking. This digest is embedded into
>> the purgatory image prior to placing purgatory in memory.
>>
>> Since hotplug events cause changes to the elfcorehdr, purgatory
>> integrity checking fails (at crash time, and no kdump created).
>> As a result, this change explicitly excludes the elfcorehdr segment
>> from the list of segments used to create the digest. By doing so,
>> this permits changes to the elfcorehdr in response to hotplug events,
>> without having to also reload purgatory due to the change to the
>> digest.
> 
> Acked-by: Baoquan He <bhe@redhat.com>
Thank you!
eric

> 
>>
>> Signed-off-by: Eric DeVolder <eric.devolder@oracle.com>
>> ---
>>   kernel/kexec_file.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
>> index 801d0d0a5012..93bb0c0ce66c 100644
>> --- a/kernel/kexec_file.c
>> +++ b/kernel/kexec_file.c
>> @@ -765,6 +765,12 @@ static int kexec_calculate_store_digests(struct kimage *image)
>>   	for (j = i = 0; i < image->nr_segments; i++) {
>>   		struct kexec_segment *ksegment;
>>   
>> +#ifdef CONFIG_CRASH_HOTPLUG
>> +		/* This segment excluded to allow future changes via hotplug */
>> +		if (image->elf_index_valid && (j == image->elf_index))
>> +			continue;
>> +#endif
>> +
>>   		ksegment = &image->segment[i];
>>   		/*
>>   		 * Skip purgatory as it will be modified once we put digest
>> -- 
>> 2.27.0
>>
>