Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp357835pxm; Tue, 1 Mar 2022 23:06:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJyCW7Ar36tG9HD7pjL+aboVyuxIO0m/VwGbuYZm69v0Z5xeuZdzMV6iHTXZDNBvQg07EeKF X-Received: by 2002:a17:90a:a382:b0:1bc:202a:28e8 with SMTP id x2-20020a17090aa38200b001bc202a28e8mr25770858pjp.131.1646204784236; Tue, 01 Mar 2022 23:06:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646204784; cv=none; d=google.com; s=arc-20160816; b=jtNrbOapG/Gkk835GTwio4cp3EiGH7ub3FGb6rGGiGoLCTz58h1Y120emGym4s2YrV 1Qm9CGuM8fQxY8z1xABS0XxjaqDGslKDsoBcW6RU6oH+dz+yinLcBSRtJ4o0mTQOYVTl ZN75DXRIQmWe2lO/BWZBVcCkTAaxzAG9bYmMmeEMXV2aafxo7K3UX46UHwLI22qCXIl4 T0MZ6bjNdmYZ5iqc7HUUicxQOCeoR8urThJ1mUYlUee9c5l60PrZBC4helwCJX1C7Zor atAgivVNdPLp+jP0ilbsbSUYRLY5y/aTwL/sjcmjn4ffHR3zHBZzM0+Z8VqCBbt/uJjU c6Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:feedback-id:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from; bh=p9q/oXfC7BqE/xmoE27mdFqdnF94DBRH5TwQOxX2kVM=; b=T+jpPKgdfnDhaMIMPBnCuQX7MyQXcktk3SeZhj8duv5Zqo4YLSuqvqxsf9Pm4mULX2 w1zqE82pfqUegUZXWFKjaoOqPWEwbmtwhoARhLExJXXNcS0NGUx8RExKiuSk4bwvOmyv sHydg5XFI/euuC/vNK6CAfavHSep5QDkigvax58cS2LJe6bWZLIYsxACvfHjgRlFcZwK iC3h4B/nljCfMZFMBJZklM8A9GyozBnnLdQ4a1Wa40SQcLGf7b381RMadct7ml7R8QH/ QUTmX6gVL3sIffTjamf9j1lA6jgUgg0ZtLy7hoQZWrFxZNCWupj1V/woVD6EO3JvhHGg p+sA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s34-20020a63ff62000000b0036327224371si13906146pgk.10.2022.03.01.23.06.08; Tue, 01 Mar 2022 23:06:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239374AbiCBDie (ORCPT + 99 others); Tue, 1 Mar 2022 22:38:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229911AbiCBDi3 (ORCPT ); Tue, 1 Mar 2022 22:38:29 -0500 Received: from smtpbg152.qq.com (smtpbg152.qq.com [13.245.186.79]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CCC5201B6 for ; Tue, 1 Mar 2022 19:37:44 -0800 (PST) X-QQ-mid: bizesmtp65t1646192242t89gbo78 Received: from localhost.localdomain ( [58.240.82.166]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 02 Mar 2022 11:37:18 +0800 (CST) X-QQ-SSF: 0140000000200060D000B00A0000000 X-QQ-FEAT: dpyQmELDBxF9Prl52JgMRPjgodJe3WWVa84v1DaukhPHZqksTih2wpOdExClV +7SFqNDhjW+FqQE5TPGdcnfwpkQDCWwVA5g6iS1mS1yOOzzImVFQqRCF8bApQXJnOX1/jpN 3xgpc2ogtaCj1Pxnd7a2fNjF0jv1OYicRF+iNmaDMUqnbSTnmBQIabJsSMVPcQsvPawY7Ut XG8+DJkPyI73KXoIiWlozIdvvYkuB+D2H+PFoHCYYtfM1X8dWYZpdmCvXkIgnZpTUmU8OrX TRsNWUqzPg/+G8oCSLJuQjoBwNq4TfE7DtD+EkA74KTT6bNoOn+jETXbv4RNxYJXQzJciIn DW/3rBxedTmCBWIedM= X-QQ-GoodBg: 2 From: Zhen Ni To: ok@artecdesign.ee, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Zhen Ni Subject: [PATCH] USB: host: isp116x: check return value after calling platform_get_resource() Date: Wed, 2 Mar 2022 11:37:16 +0800 Message-Id: <20220302033716.31272-1-nizhen@uniontech.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:uniontech.com:qybgforeign:qybgforeign6 X-QQ-Bgrelay: 1 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Signed-off-by: Zhen Ni --- drivers/usb/host/isp116x-hcd.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c index 8835f6bd528e..8c7f0991c21b 100644 --- a/drivers/usb/host/isp116x-hcd.c +++ b/drivers/usb/host/isp116x-hcd.c @@ -1541,10 +1541,12 @@ static int isp116x_remove(struct platform_device *pdev) iounmap(isp116x->data_reg); res = platform_get_resource(pdev, IORESOURCE_MEM, 1); - release_mem_region(res->start, 2); + if (res) + release_mem_region(res->start, 2); iounmap(isp116x->addr_reg); res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - release_mem_region(res->start, 2); + if (res) + release_mem_region(res->start, 2); usb_put_hcd(hcd); return 0; -- 2.20.1