Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1488c55b-4481-a4fc-a2af-a2bef0b41f83@linaro.org>
Date:   Tue, 1 Mar 2022 05:11:16 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] interconnect: Add stubs for the bulk API
Content-Language: en-US
To:     Georgi Djakov <djakov@kernel.org>
Cc:     bjorn.andersson@linaro.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220301090735.26599-1-djakov@kernel.org>
From:   Alex Elder <elder@linaro.org>
In-Reply-To: <20220301090735.26599-1-djakov@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/1/22 3:07 AM, Georgi Djakov wrote:
> Add stub functions for the bulk API to allow compile testing.
> 
> Signed-off-by: Georgi Djakov <djakov@kernel.org>

I have this patch--almost exactly--sitting in my queue waiting
for another to get accepted.

Thanks Georgi, it looks good to me.

Reviewed-by: Alex Elder <elder@linaro.org>

> ---
>   include/linux/interconnect.h | 36 +++++++++++++++++++++++++++++-------
>   1 file changed, 29 insertions(+), 7 deletions(-)
> 
> diff --git a/include/linux/interconnect.h b/include/linux/interconnect.h
> index f2dd2fc8d3cd..f685777b875e 100644
> --- a/include/linux/interconnect.h
> +++ b/include/linux/interconnect.h
> @@ -38,13 +38,6 @@ struct icc_bulk_data {
>   	u32 peak_bw;
>   };
>   
> -int __must_check of_icc_bulk_get(struct device *dev, int num_paths,
> -				 struct icc_bulk_data *paths);
> -void icc_bulk_put(int num_paths, struct icc_bulk_data *paths);
> -int icc_bulk_set_bw(int num_paths, const struct icc_bulk_data *paths);
> -int icc_bulk_enable(int num_paths, const struct icc_bulk_data *paths);
> -void icc_bulk_disable(int num_paths, const struct icc_bulk_data *paths);
> -
>   #if IS_ENABLED(CONFIG_INTERCONNECT)
>   
>   struct icc_path *icc_get(struct device *dev, const int src_id,
> @@ -58,6 +51,12 @@ int icc_disable(struct icc_path *path);
>   int icc_set_bw(struct icc_path *path, u32 avg_bw, u32 peak_bw);
>   void icc_set_tag(struct icc_path *path, u32 tag);
>   const char *icc_get_name(struct icc_path *path);
> +int __must_check of_icc_bulk_get(struct device *dev, int num_paths,
> +				 struct icc_bulk_data *paths);
> +void icc_bulk_put(int num_paths, struct icc_bulk_data *paths);
> +int icc_bulk_set_bw(int num_paths, const struct icc_bulk_data *paths);
> +int icc_bulk_enable(int num_paths, const struct icc_bulk_data *paths);
> +void icc_bulk_disable(int num_paths, const struct icc_bulk_data *paths);
>   
>   #else
>   
> @@ -112,6 +111,29 @@ static inline const char *icc_get_name(struct icc_path *path)
>   	return NULL;
>   }
>   
> +static inline int of_icc_bulk_get(struct device *dev, int num_paths, struct icc_bulk_data *paths)
> +{
> +	return 0;
> +}
> +
> +static inline void icc_bulk_put(int num_paths, struct icc_bulk_data *paths)
> +{
> +}
> +
> +static inline int icc_bulk_set_bw(int num_paths, const struct icc_bulk_data *paths)
> +{
> +	return 0;
> +}
> +
> +static inline int icc_bulk_enable(int num_paths, const struct icc_bulk_data *paths)
> +{
> +	return 0;
> +}
> +
> +static inline void icc_bulk_disable(int num_paths, const struct icc_bulk_data *paths)
> +{
> +}
> +
>   #endif /* CONFIG_INTERCONNECT */
>   
>   #endif /* __LINUX_INTERCONNECT_H */