Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Mar 2022 23:47:44 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Iouri Tarassov <iourit@linux.microsoft.com>
Cc:     kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com,
        wei.liu@kernel.org, linux-hyperv@vger.kernel.org,
        linux-kernel@vger.kernel.org, spronovo@microsoft.com,
        spronovo@linux.microsoft.com, gregkh@linuxfoundation.org
Subject: Re: [PATCH v3 05/30] drivers: hv: dxgkrnl: Opening of /dev/dxg
 device and dxgprocess creation
Message-ID: <20220301234744.plggauzg4ka5p3tm@liuwe-devbox-debian-v2>
References: <719fe06b7cbe9ac12fa4a729e810e3383ab421c1.1646163378.git.iourit@linux.microsoft.com>
 <419b863b2848b9e86382511a2f0f12cf91065578.1646163378.git.iourit@linux.microsoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <419b863b2848b9e86382511a2f0f12cf91065578.1646163378.git.iourit@linux.microsoft.com>
Precedence: bulk

On Tue, Mar 01, 2022 at 11:45:52AM -0800, Iouri Tarassov wrote:
> - Implement opening of the device (/dev/dxg) file object and creation of
> dxgprocess objects.
[...]
>  static int dxgk_open(struct inode *n, struct file *f)
>  {
> -	return 0;
> +	int ret = 0;
> +	struct dxgprocess *process;
> +
> +	pr_debug("%s %p %d %d",
> +		     __func__, f, current->pid, current->tgid);
> +
> +
> +	/* Find/create a dxgprocess structure for this process */
> +	process = dxgglobal_get_current_process();
> +
> +	if (process) {
> +		f->private_data = process;
> +	} else {
> +		pr_debug("cannot create dxgprocess for open\n");
> +		ret = -EBADF;
> +	}
> +
> +	pr_debug("%s end %x", __func__, ret);

I would normally remove pr_deubg's like this when submitting. It doesn't
provide much information.

> +	return ret;
>  }
>  
[...]
>  
> +int dxgvmb_send_create_process(struct dxgprocess *process)
> +{
> +	int ret;
> +	struct dxgkvmb_command_createprocess *command;
> +	struct dxgkvmb_command_createprocess_return result = { 0 };
> +	struct dxgvmbusmsg msg;
> +	char s[WIN_MAX_PATH];
> +	int i;
> +
> +	ret = init_message(&msg, NULL, process, sizeof(*command));
> +	if (ret)
> +		return ret;
> +	command = (void *)msg.msg;
> +
> +	ret = dxgglobal_acquire_channel_lock();
> +	if (ret < 0)
> +		goto cleanup;
> +
> +	command_vm_to_host_init1(&command->hdr, DXGK_VMBCOMMAND_CREATEPROCESS);
> +	command->process = process;
> +	command->process_id = process->process->pid;
> +	command->linux_process = 1;
> +	s[0] = 0;
> +	__get_task_comm(s, WIN_MAX_PATH, process->process);
> +	for (i = 0; i < WIN_MAX_PATH; i++) {
> +		command->process_name[i] = s[i];
> +		if (s[i] == 0)
> +			break;
> +	}

What's wrong with doing

  __get_task_comm(command->process_name, WIN_MAX_PATH, process->process);

here?

That saves you many bytes on stack.

[...]
> +static char *errorstr(int ret)
> +{
> +	return ret < 0 ? "err" : "";
> +}
> +

This is not used in this patch.

[...]
> diff --git a/drivers/hv/dxgkrnl/misc.h b/drivers/hv/dxgkrnl/misc.h
> index 1ff0c0e28332..433b59d3eb23 100644
> --- a/drivers/hv/dxgkrnl/misc.h
> +++ b/drivers/hv/dxgkrnl/misc.h
> @@ -31,7 +31,6 @@ extern const struct d3dkmthandle zerohandle;
>   * table_lock
>   * core_lock
>   * device_lock
> - * process->process_mutex

Why is this deleted?

Thanks,
Wei.