Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <edee4305-77da-039b-1f07-bcdc5d462666@quicinc.com>
Date:   Wed, 2 Mar 2022 11:06:45 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.2
Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Configure cts sleep pinctrl to
 bias-disable for sc7280-idp
Content-Language: en-CA
To:     <agross@kernel.org>, <bjorn.andersson@linaro.org>,
        <robh+dt@kernel.org>
CC:     <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <msavaliy@qti.qualcomm.com>,
        <mka@chromium.org>, <swboyd@chromium.org>, <dianders@chromium.org>
References: <1644843828-20464-1-git-send-email-quic_vnivarth@quicinc.com>
From:   Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
In-Reply-To: <1644843828-20464-1-git-send-email-quic_vnivarth@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

+Google Reviewers

Hello Reviewers,

We were wondering if you had a chance to review this patch and provide 
any comments.

Thank you,

Vijay/


On 2/14/2022 6:33 PM, Vijaya Krishna Nivarthi wrote:
> WLAN rail was leaking power during RBSC/sleep even after turning BT off.
> Change sleep pinctrl configuration to handle same.
>
> Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
> ---
>   arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> index d623d71..de18319 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> @@ -516,10 +516,10 @@
>   		pins = "gpio28";
>   		function = "gpio";
>   		/*
> -		 * Configure a pull-down on CTS to match the pull of
> -		 * the Bluetooth module.
> +		 * Configure a disable on CTS to lower power usage
> +		 * when BT is turned off.
>   		 */
> -		bias-pull-down;
> +		bias-disable;
>   	};
>   
>   	qup_uart7_sleep_rts: qup-uart7-sleep-rts {