Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Mar 2022 17:09:07 +0800
From:   Huang Rui <ray.huang@amd.com>
To:     "Rafael J. Wysocki" <rafael@kernel.org>,
        "Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>
Cc:     "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Linux PM <linux-pm@vger.kernel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Doug Smythies <dsmythies@telus.net>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Todd Brandt <todd.e.brandt@linux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        "Yuan, Perry" <Perry.Yuan@amd.com>,
        "Meng, Li (Jassmine)" <Li.Meng@amd.com>
Subject: Re: [PATCH 1/3] cpufreq: amd-pstate: Add more tracepoint for AMD
 P-State module
Message-ID: <Yh80MwmHqAXK+PbD@amd.com>
References: <20220223100350.3523826-1-Jinzhou.Su@amd.com>
 <20220223100350.3523826-2-Jinzhou.Su@amd.com>
 <CAJZ5v0iaY3tsNKFXv09Z4wg_2R3+9UsSnqfPBbOYFaqoVS1qCg@mail.gmail.com>
 <BL1PR12MB51447B1235E91A81309190B2F7029@BL1PR12MB5144.namprd12.prod.outlook.com>
 <CAJZ5v0jDbNVEtRiaiUXembZB2r4uxVy3iKO0aTqOJsB0rLpV=A@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJZ5v0jDbNVEtRiaiUXembZB2r4uxVy3iKO0aTqOJsB0rLpV=A@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PT0sq6wk7EB8s/Nc97WSOx+jS7YFtL4OYsCoBlTauggfKrHSSvXMk61IytQU?=
 =?us-ascii?Q?GY0jTMSZCxI2z9S1OLpT3kmLG9Dp0QTS961ON1A4YNiUO4eqPAgPoKkAfFni?=
 =?us-ascii?Q?GsLP4j36ZxZhWVQTMxogNEonaeehtyhd3QQFDMsK7NvMOd8R3hAnLqNGHXTd?=
 =?us-ascii?Q?chk4PYvQz9REaJT23bDj0Lh6/V+dMxcAYeg426nuDYqpa9RxmN0BxL2k8Tkx?=
 =?us-ascii?Q?Ig2sspJcO3balTq2NJnj1AsshfO+Kytt6kECbJVT5kmK3KtUkIUfAQBfWjml?=
 =?us-ascii?Q?UZs4gHxVyNb+Co0z2a1irVeKQliw9NKDCGChg2p2b7UxUpbZTmPZ1UKCdK2v?=
 =?us-ascii?Q?EZSofwcBRnlKq3I+t0Xq7ksOVR4hgeZMuyt0yjX6LUKCMxhHXKeRWyRoGp5m?=
 =?us-ascii?Q?D/yzGCL3yYXajGr9ju5rhp5v2j3o7X/IKPgKoTRJk7fdAWTz5awZPjgAhXKW?=
 =?us-ascii?Q?Sqh90x4fuioWuULFB/54V4amwaQFOMRX9lGd/N2pvt4p7mpyIhBlSDNCbpka?=
 =?us-ascii?Q?TY4PBk3QFtOsMBVAHnZBu80COfBYdkRmlS/cjUiYTfytsByN5s27Zt0Z3Qgx?=
 =?us-ascii?Q?whaKG5w2PpR5oXwiS51ILMksYtmf1Ba7xeN2qHDVf/+kSjh8+d9Fq4Sl3gov?=
 =?us-ascii?Q?LZktIsKF/YnOQ70DyRLRwCy+ZKforYqomvFthNgv/DQItUN+mA/0yAmBPJ+u?=
 =?us-ascii?Q?XAe+S0pQOobTG/478ml10/ifGMY86rJylCc931I96Rgzy+vyMIiLkTEx5bn7?=
 =?us-ascii?Q?tORHlkFEJgSn02W4fbJBX56gPaK3PlbPP5hZHMZhWfMRIkW2mXcFuH6Rgz/I?=
 =?us-ascii?Q?Bwm3fwU7eDRNvJVb2YP+vQ9U350UtcFa/pa8Nwv1tat7EaerkesIqcEdXBca?=
 =?us-ascii?Q?lR/ykbf4iLMhxdlRbND+NMq66xMTfuDgzwMiGupuyceQH0BRluhScJE/pa5e?=
 =?us-ascii?Q?QPQqwbLsQ3Zwo0zSDqiPObhVyPom68AKZhtJ29rw5e4JnoL9JzGiuv9Ekamd?=
 =?us-ascii?Q?/My6TR/7fMrC+Xux3IocdvxzNe5XgkuZK0okNT4cT2K8Qw1d+KQ9Alze71sJ?=
 =?us-ascii?Q?CaTbjCZygn+YaQ1DAB11h/9Ksbouz1QGpcTbr+RN1crXXjhfKiC/iEXCChQW?=
 =?us-ascii?Q?mCfbg8YGnk/UAmEuUCY2ODqO2e4F2Pb9LBUKXpmBLtp0jEFZmGP6b5u0jZiE?=
 =?us-ascii?Q?pazaXNtgCoSjREQ7XoWg7hCvAEvd65b+fSom0ucMQJT3oeYQ3kt3e8/bhV8P?=
 =?us-ascii?Q?LnrqgMIMqB1Y4GkjV7AydFD5uRvJC+gHlp/yOIrr3ZobYp+dprqcGqDSTqXS?=
 =?us-ascii?Q?T6oRAvekuAXm7/DTEQkxkkteTY8vXYRhRGc4U4HlfspLGPijQbmjBmNbYVO+?=
 =?us-ascii?Q?ANOEL2XfDCIARVudyc7WmiSI7tqOzBzEY6nCLMXqx+RBHEk09Uy5QYwLqX/9?=
 =?us-ascii?Q?I6etGCDVktXeZ+cfsJTpiZVd6szYU7IMG/k73WN0RVMqcxfULKoeOXvG08o1?=
 =?us-ascii?Q?YxSZKz0OekFTgAGIRER+kQxBo7+tUl/EdhmRBjY27TJszhlx0nYj+auVIcHU?=
 =?us-ascii?Q?TbD+PbIreAzW6K6I5J3je5QUdfHDVzHlh3T+lTfPVOB+IQbULe2Ssx/4InIX?=
 =?us-ascii?Q?jEX1womAxlFE/TCJz1x+We8=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4a0873b1-c927-4839-dc63-08d9fc2c5c99
X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 09:09:31.6045
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f4oBOikUhwGXkPTduo7fw3crDT2zziHiU+RNq+hL4nUDgD1mZmc6hIdwCemkXC7ZdIH7H8FI3s8CHichfE06tQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0091
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 02, 2022 at 12:07:45AM +0800, Rafael J. Wysocki wrote:
> On Tue, Mar 1, 2022 at 5:05 PM Deucher, Alexander
> <Alexander.Deucher@amd.com> wrote:
> >
> > [AMD Official Use Only]
> >
> > > -----Original Message-----
> > > From: Rafael J. Wysocki <rafael@kernel.org>
> > > Sent: Tuesday, March 1, 2022 10:26 AM
> > > To: Su, Jinzhou (Joe) <Jinzhou.Su@amd.com>
> > > Cc: Rafael J. Wysocki <rjw@rjwysocki.net>; Linux PM <linux-
> > > pm@vger.kernel.org>; Srinivas Pandruvada
> > > <srinivas.pandruvada@linux.intel.com>; Doug Smythies
> > > <dsmythies@telus.net>; Huang, Ray <Ray.Huang@amd.com>; Viresh Kumar
> > > <viresh.kumar@linaro.org>; Todd Brandt <todd.e.brandt@linux.intel.com>;
> > > Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; Sharma, Deepak
> > > <Deepak.Sharma@amd.com>; Deucher, Alexander
> > > <Alexander.Deucher@amd.com>; Du, Xiaojian <Xiaojian.Du@amd.com>;
> > > Yuan, Perry <Perry.Yuan@amd.com>; Meng, Li (Jassmine)
> > > <Li.Meng@amd.com>
> > > Subject: Re: [PATCH 1/3] cpufreq: amd-pstate: Add more tracepoint for AMD
> > > P-State module
> > >
> > > On Wed, Feb 23, 2022 at 11:04 AM Jinzhou Su <Jinzhou.Su@amd.com>
> > > wrote:
> > > >
> > > > Add frequency, mperf, aperf and tsc in the trace. This can be used to
> > > > debug and tune the performance of AMD P-state driver.
> > > >
> > > > Use the time difference between amd_pstate_update to calculate CPU
> > > > frequency. There could be sleep in arch_freq_get_on_cpu, so do not use
> > > > it here.
> > > >
> > > > Signed-off-by: Jinzhou Su <Jinzhou.Su@amd.com>
> > > > Signed-off-by: Huang Rui <ray.huang@amd.com>
> > >
> > > I'm not sure what the second sign-off is for.
> > >
> > > If this is a maintainer's sign-off, it should be added by the maintainer himself
> > > and you should not add it when submitting the patch.
> >
> > Both developers co-worked on the patch.  Isn't that pretty standard when you rework someone else's patch?
> 
> It is, but that's when Co-developed-by should be used.  Otherwise the
> meaning of the second s-o-b is unclear.

Yes.

Joe, can you add below in next V2:

Co-developed-by: Huang Rui <ray.huang@amd.com>

Patch looks good for me, could you please add new patch to describe how to
use the tracer script in Documentation/admin-guide/pm/amd-pstate.rst?

Thanks,
Ray