Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp457204pxm; Wed, 2 Mar 2022 01:51:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJx7u0AAb76UJgl2JifAyM7wpE9azHqnFmsq0gApwAea1a09BpuVIHAlFdeua8UF0xmSgWT+ X-Received: by 2002:a17:907:c16:b0:6da:7d72:1357 with SMTP id ga22-20020a1709070c1600b006da7d721357mr18714ejc.251.1646214675243; Wed, 02 Mar 2022 01:51:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646214675; cv=none; d=google.com; s=arc-20160816; b=LLu8FAYMTDSligX08RrhnhP+wFvjEq9Z2gL4lX8NqbqQ56Tob/2am819UBu+k9fN1c 39Bt20M0Ia+T4OqjvnwfqUCYD6Sz+v8djqgQukHmRYp4xXOYRnitmjKyApf5YTyMUmGA OV6RIH6hPrlzjo5501EC3KQgK1y/jEgkeVARPRpFW88O0nDKAOoooj8HmuXxzTSiRiZq jbMfrWyYRfyCzKAxMUm2h+zTWFeWXHTLlHEGnSTap7/7W4k3BuwZX1AGgCaDRdS+2lqO IJ4+PYh5S3U5RDfn8bpOcapcuiMeO8V9NE3NLgEocgK/jraWrsmJG+4DbKVG/CSE8CnL b1Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=ET15GgI57duVbTvcVtFigSD+iRUjJs12PG+P2LL5kB0=; b=E+bnxp+nLmq2LVlYuqmunMaYruOPR8FFmIhREOxqeflr7hhRh9EzVVL6mX5v7NOkC6 gLziQ//8zlKk2q/e2eHht5UTT9X9q+vCb7hChsxf4e1HHYxHWlvxvD0VxRtwk7EZXeTz uwk8kC4KorZANco4kwj156OTAjQ6h1gFHxxpBFuWCYLgSfIhY8seSlfl3GwURpeGrSBx OjtYS2rF/1Mnh9z99e/9bSK16q8VyrFgY2mSbqk0Jf+JmJiW1L0KbtDjaxiqijIulgM+ Ln4hMbgCNZxpXIFkiiWoe/gvK3u5c76cmbmwqI9G7vgfB/5qiM5/FA3sBSfZ1FUa6UBb wcPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HK4wn6nV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l12-20020a170906794c00b006d7db627954si1651735ejo.313.2022.03.02.01.50.47; Wed, 02 Mar 2022 01:51:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HK4wn6nV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232719AbiCAOtm (ORCPT + 99 others); Tue, 1 Mar 2022 09:49:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231776AbiCAOtl (ORCPT ); Tue, 1 Mar 2022 09:49:41 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E13282715D for ; Tue, 1 Mar 2022 06:48:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646146139; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=ET15GgI57duVbTvcVtFigSD+iRUjJs12PG+P2LL5kB0=; b=HK4wn6nVfF+EeR5PaPB904WkOEp2TKc+CLkBpz4men3pEej9KIRqGea03Zq2A1G4GakGNX UIzgFi4mBjdRxOgSR8DKd5x5OTPcE/8fexQ4Mz5a9+Q7ETg5k+NbPmTSdK8CgAzTcRLgWX l43VAn5M/+TnhTSE3YyqgsJMv5x4wQE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-281-z7946cAUOFeUJBROxtD_Rw-1; Tue, 01 Mar 2022 09:48:53 -0500 X-MC-Unique: z7946cAUOFeUJBROxtD_Rw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1EE821854E21; Tue, 1 Mar 2022 14:48:52 +0000 (UTC) Received: from jtoppins.rdu.csb (unknown [10.22.34.174]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2F90D838BC; Tue, 1 Mar 2022 14:48:49 +0000 (UTC) From: Jonathan Toppins To: intel-wired-lan@lists.osuosl.org, lihong.yang@intel.com Cc: Jocelyn Falempe , Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ice: use msleep instead of mdelay Date: Tue, 1 Mar 2022 09:48:45 -0500 Message-Id: <370e9909d8e00d4a1c8abcd405c321fc41646478.1646146125.git.jtoppins@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use msleep for long delays instead of spinning in the driver. Suggested-by: Jocelyn Falempe Signed-off-by: Jonathan Toppins --- drivers/net/ethernet/intel/ice/ice_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_common.c b/drivers/net/ethernet/intel/ice/ice_common.c index 0e4434e3c290..75860259c6d7 100644 --- a/drivers/net/ethernet/intel/ice/ice_common.c +++ b/drivers/net/ethernet/intel/ice/ice_common.c @@ -1107,7 +1107,7 @@ int ice_check_reset(struct ice_hw *hw) GLGEN_RSTCTL_GRSTDEL_S) + 10; for (cnt = 0; cnt < grst_timeout; cnt++) { - mdelay(100); + msleep(100); reg = rd32(hw, GLGEN_RSTAT); if (!(reg & GLGEN_RSTAT_DEVSTATE_M)) break; @@ -3235,7 +3235,7 @@ ice_set_fc(struct ice_port_info *pi, u8 *aq_failures, bool ena_auto_link_update) if (!status) break; - mdelay(100); + msleep(100); } if (status) -- 2.27.0