Date: Mon, 19 Feb 2007 14:47:36 +0300
From: Oleg Nesterov <oleg@tv-sign.ru>
To: David Howells <dhowells@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
       Mauro Carvalho Chehab <mchehab@infradead.org>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] drivers/media/video/cpia_pp.c: don't use _WORK_NAR
Message-ID: <20070219114736.GA91@tv-sign.ru>
References: <20070218214415.GA4232@tv-sign.ru> <8637.1171885038@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8637.1171885038@redhat.com>
User-Agent: Mutt/1.5.11
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 764
Lines: 28

On 02/19, David Howells wrote:
>
> Oleg Nesterov <oleg@tv-sign.ru> wrote:
> 
> > pp_cam_entry->cb_task need not to be _NOAUTOREL ... because in fact it is
> > never used ???
> 
> That's a remarkably good point.  Did something get deleted since I made my
> modifications?

At first I thought the same. But no, it looks unused as well in 2.6.18.

>                  Perhaps the workqueue stuff in that file should just be
> deleted entirely.

I think yes.

> Acked-By: David Howells <dhowells@redhat.com>

Thanks.

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/