Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yihao Han <hanyihao@vivo.com>
To:     Green Wan <green.wan@sifive.com>, Vinod Koul <vkoul@kernel.org>,
        dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     kernel@vivo.com, Yihao Han <hanyihao@vivo.com>
Subject: [PATCH] dmaengine: sf-pdma: fix platform_get_irq.cocci warning
Date:   Tue,  1 Mar 2022 19:21:39 -0800
Message-Id: <20220302032139.5416-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?caaLdbe7O0g/QgZ3zsqBpqR53sV2En7NOL3cktDxhRxIRiDsOghMeeR450jM?=
 =?us-ascii?Q?EaSEGlyR5zwhVB7c/BeOrL49QoFqNsEQlMYhBasIPDWOF94+7XxIgAWLEk7K?=
 =?us-ascii?Q?1P5lXuLLVjyjN3Po6CJgQcBfbBfazjfClFU5jRvlZKE78F3rv7I7Ng8Km1yQ?=
 =?us-ascii?Q?oZyNxpeFoeR9Zxe0OhbcsLJE+p3eh1UXwM6PCI4pKqOSibTuQLSMYeBGTMqi?=
 =?us-ascii?Q?Kezqj4apCzmitlFcTdpwI9XZqSYTQA+zUQns0C7CreBZZT29EtVYOB/4g248?=
 =?us-ascii?Q?Ncu6i+XOOe38mmR/hjHHnd3LJmKdYbY/Ndf7NRkJl2SGLVsGkDN7GoowdgNA?=
 =?us-ascii?Q?XQXtaq+MjW3CmrM2ZvSDHFIpxnzAoyFExs+IDzYrHdpBU1nw966oNN+cnbB3?=
 =?us-ascii?Q?g3XE7RPnsJXLJ1GOnWr9E3MDEManSGjxCmJSDkSCOKB2EYB+tRxQkNv8sDDH?=
 =?us-ascii?Q?rQIv/eF/s6JFhgWb/+6EAWT1/o8yZjF0VUk8pJflb9DtE34ieqaRNm8moiQ1?=
 =?us-ascii?Q?neZJKEvcya1yd7CHIWy1SexDMBv2CAeL5O7gzNVaO2t8nyEkIeXtDZT+T2rx?=
 =?us-ascii?Q?WrYt2mtDlB9GbIpgXRl1VrbfMe1tDYdzR3QEWb/BrfIjOJ1rEuAdPDIULFJG?=
 =?us-ascii?Q?jjowNQbmAbPikX4VBcL7g2wQibjhsTdXHe9AwkVRSCmn6/XOCwDcmQLEvmwO?=
 =?us-ascii?Q?FZk/nHDiOl691mP7+nFXlrRHhm1cWuXltA6pUq9g495aRfuVg5Hjacu1uhd1?=
 =?us-ascii?Q?E16iK/WcNXymUz8K5fz/6GAfhjL+XYpOl54/CLrflR0gZ8mdWQYboFRAmwgH?=
 =?us-ascii?Q?7VdTPVJiLndeybcXEIXil8Ea6qOOTxHPbPmmM8fJoEYqmnnDIlfgs0+EuQHZ?=
 =?us-ascii?Q?aKsI3tBWfdw4Le3H8eIOVlx/K6kvOKS4+J1jtEXKhrAWn6nYi5R/HggRBjwQ?=
 =?us-ascii?Q?hH4er4lv1Y5g4Mc9td2+U9ShkycGhyIUrb12pFb1cPAFtbwP7aBhFlq3C8dd?=
 =?us-ascii?Q?avs7cAX35sIAHG2B3Lo8vwLdYUxhEmfbx3nbylHl6CB/3lRAwAimCIrJ/GwE?=
 =?us-ascii?Q?iFhU+6qqk44GkfJrXGHABSFmRY4vBdmHgfrymm4U9nKBK8Er2lZVPJ+aB23A?=
 =?us-ascii?Q?bzu6NIkoTcrDClnKCl4z32EQ0fwnfCEkxgdFtJUt0D/9CQM/yXfp6nNc1KCN?=
 =?us-ascii?Q?OHOVV973jhNCbIq98Q/ls9WBn2KADScKVYylHoIXyb3t0hY36EuiGYuwE7bv?=
 =?us-ascii?Q?xvx39ZWXLv6NeLGbJSx3sWiRKLeSBW0Dntgm0+D0e+yimuXwRYEfTPhtWWu/?=
 =?us-ascii?Q?x3EF29FC64v82kmpcE4bUQmVFNtqKr3J/mpsqoYWtHVBipNw3TvORkTmCMha?=
 =?us-ascii?Q?iAkBOrKUHTAazblIW1Q80G94IxGqp5Ckmspy0R4HcWIzYqTL48TkIfvYMfM4?=
 =?us-ascii?Q?vdIVU0UcP5BqQdaJE8qDIWqdyKPNE/CL6OHJrrVkuv3tDcy/DMAGjFzmpK17?=
 =?us-ascii?Q?9ZQmXtr08SYlPobBiyecppljmmdx6lVqXWfaNiOQmx01vn5hJ5HEDYWrHq+l?=
 =?us-ascii?Q?By7iY33FGGMr5Tg4gwHPemeaNHfLc5BKO+pFTlop+Oq/ZlhXhF+7oz0HWWRt?=
 =?us-ascii?Q?o+MblT6GTfWgR7PBeNbVUY8=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b19c6a6e-4540-47a1-ce66-08d9fbfbcfb5
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 03:21:59.1827
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ek647+J7elNidzpjLol2dZoAXof43S/ObjFikd4x247FHMSn1JHWIjQV/VfvqpczXLmiLuNXu3R8DNkGIAUT4g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB2924
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Remove dev_err() messages after platform_get_irq*() failures.
platform_get_irq() already prints an error.

Generated by: scripts/coccinelle/api/platform_get_irq.cocci

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 drivers/dma/sf-pdma/sf-pdma.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/dma/sf-pdma/sf-pdma.c b/drivers/dma/sf-pdma/sf-pdma.c
index f12606aeff87..c2e40849f2aa 100644
--- a/drivers/dma/sf-pdma/sf-pdma.c
+++ b/drivers/dma/sf-pdma/sf-pdma.c
@@ -389,10 +389,8 @@ static int sf_pdma_irq_init(struct platform_device *pdev, struct sf_pdma *pdma)
 		chan = &pdma->chans[i];
 
 		irq = platform_get_irq(pdev, i * 2);
-		if (irq < 0) {
-			dev_err(&pdev->dev, "ch(%d) Can't get done irq.\n", i);
+		if (irq < 0)
 			return -EINVAL;
-		}
 
 		r = devm_request_irq(&pdev->dev, irq, sf_pdma_done_isr, 0,
 				     dev_name(&pdev->dev), (void *)chan);
@@ -404,10 +402,8 @@ static int sf_pdma_irq_init(struct platform_device *pdev, struct sf_pdma *pdma)
 		chan->txirq = irq;
 
 		irq = platform_get_irq(pdev, (i * 2) + 1);
-		if (irq < 0) {
-			dev_err(&pdev->dev, "ch(%d) Can't get err irq.\n", i);
+		if (irq < 0)
 			return -EINVAL;
-		}
 
 		r = devm_request_irq(&pdev->dev, irq, sf_pdma_err_isr, 0,
 				     dev_name(&pdev->dev), (void *)chan);
-- 
2.17.1