Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 1 Mar 2022 18:14:56 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Q1IQ <fufuyqqqqqq@gmail.com>
Cc:     ioana.ciornei@nxp.com, davem@davemloft.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, lyz_cs@pku.edu.cn
Subject: Re: [PATCH] dpaa2 ethernet switch driver: Fix memory leak in
 dpaa2_switch_acl_entry_remove()
Message-ID: <20220301181456.3678a4b0@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
In-Reply-To: <20220301092450.42523-1-fufuyqqqqqq@gmail.com>
References: <20220301092450.42523-1-fufuyqqqqqq@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue,  1 Mar 2022 17:24:50 +0800 Q1IQ wrote:
> @@ -182,6 +183,7 @@ dpaa2_switch_acl_entry_remove(struct dpaa2_switch_filter_block *block,
>  			 DMA_TO_DEVICE);
>  	if (err) {
>  		dev_err(dev, "dpsw_acl_remove_entry() failed %d\n", err);
> +		kfree(cmd_buff);
>  		return err;
>  	}

Same comments apply to this patch as to the other patch you sent.