Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <1646105865-22040-1-git-send-email-baihaowen88@gmail.com>
In-Reply-To: <1646105865-22040-1-git-send-email-baihaowen88@gmail.com>
From:   Josh Don <joshdon@google.com>
Date:   Tue, 1 Mar 2022 14:38:49 -0800
Message-ID: <CABk29NufkSnuN_q+JHFNB=v_cO+VO+QSRLT4UL6=Awrkz8y=8w@mail.gmail.com>
Subject: Re: [PATCH] sched/core: remove unneeded semicolon
To:     Haowen Bai <baihaowen88@gmail.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Benjamin Segall <bsegall@google.com>,
        Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Feb 28, 2022 at 7:37 PM Haowen Bai <baihaowen88@gmail.com> wrote:
>
> Eliminate the following coccicheck warning:
> kernel/sched/core_sched.c:210:2-3: Unneeded semicolon
>
> Signed-off-by: Haowen Bai <baihaowen88@gmail.com>

Thanks,

Reviewed-by: Josh Don <joshdon@google.com>

> ---
>  kernel/sched/core_sched.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/core_sched.c b/kernel/sched/core_sched.c
> index c8746a9..085f188 100644
> --- a/kernel/sched/core_sched.c
> +++ b/kernel/sched/core_sched.c
> @@ -207,7 +207,7 @@ int sched_core_share_pid(unsigned int cmd, pid_t pid, enum pid_type type,
>         default:
>                 err = -EINVAL;
>                 goto out;
> -       };
> +       }
>
>         if (type == PIDTYPE_PID) {
>                 __sched_core_set(task, cookie);
> --
> 2.7.4
>