Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 2 Mar 2022 12:34:57 +0100
From:   Guido =?iso-8859-1?Q?G=FCnther?= <agx@sigxcpu.org>
To:     Liu Ying <victor.liu@nxp.com>
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        robert.foss@linaro.org, linux-imx@nxp.com
Subject: Re: [PATCH] drm/bridge: nwl-dsi: Remove superfluous write to
 NWL_DSI_IRQ_MASK register
Message-ID: <Yh9WYZ5pA/MUyZFx@qwark.sigxcpu.org>
References: <20220216085842.1973868-1-victor.liu@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220216085842.1973868-1-victor.liu@nxp.com>
Precedence: bulk

Hi Liu,
On Wed, Feb 16, 2022 at 04:58:42PM +0800, Liu Ying wrote:
> To initialize register NWL_DSI_IRQ_MASK, it's enough to write it
> only once in function nwl_dsi_init_interrupts().
> 
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
>  drivers/gpu/drm/bridge/nwl-dsi.c | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c
> index af07eeb47ca0..fcc4a2889ad4 100644
> --- a/drivers/gpu/drm/bridge/nwl-dsi.c
> +++ b/drivers/gpu/drm/bridge/nwl-dsi.c
> @@ -333,17 +333,13 @@ static int nwl_dsi_config_dpi(struct nwl_dsi *dsi)
>  
>  static int nwl_dsi_init_interrupts(struct nwl_dsi *dsi)
>  {
> -	u32 irq_enable;
> -
> -	nwl_dsi_write(dsi, NWL_DSI_IRQ_MASK, 0xffffffff);
> -	nwl_dsi_write(dsi, NWL_DSI_IRQ_MASK2, 0x7);
> -
> -	irq_enable = ~(u32)(NWL_DSI_TX_PKT_DONE_MASK |
> -			    NWL_DSI_RX_PKT_HDR_RCVD_MASK |
> -			    NWL_DSI_TX_FIFO_OVFLW_MASK |
> -			    NWL_DSI_HS_TX_TIMEOUT_MASK);
> +	u32 irq_enable = ~(u32)(NWL_DSI_TX_PKT_DONE_MASK |
> +				NWL_DSI_RX_PKT_HDR_RCVD_MASK |
> +				NWL_DSI_TX_FIFO_OVFLW_MASK |
> +				NWL_DSI_HS_TX_TIMEOUT_MASK);
>  
>  	nwl_dsi_write(dsi, NWL_DSI_IRQ_MASK, irq_enable);
> +	nwl_dsi_write(dsi, NWL_DSI_IRQ_MASK2, 0x7);

Works fine here. I thought it was due to some hw quirk but can't find
any note in it so:

Reviewed-by: Guido G?nther <agx@sigxcpu.org>

Thanks,
 -- Guido

>  
>  	return nwl_dsi_clear_error(dsi);
>  }
> -- 
> 2.25.1
>