Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp597523pxm; Wed, 2 Mar 2022 05:04:58 -0800 (PST) X-Google-Smtp-Source: ABdhPJyLm2M5fnm3d4K3gnEjQ5P0PHlcZPSlf7B7rHGHqCYFOjy6xt9nU13EoZs2rga6XSN67x8d X-Received: by 2002:a17:902:b18d:b0:151:7456:4f77 with SMTP id s13-20020a170902b18d00b0015174564f77mr11550261plr.41.1646226298681; Wed, 02 Mar 2022 05:04:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646226298; cv=none; d=google.com; s=arc-20160816; b=LvxY9uqFS1x3OO2c1kP7NVtEoReNvd/6C4MLdEFs8tdKqUXTu58oo0hOvN3L5OF8i3 qPt6U1/4uwx4fW6h8wzeuIh7erVkTyT2Zb79/+4vAuYKkyX5fKr6TpCKJh0ru18oF9Si qYhlyyRx5DgXYfD1SRYx7WQgX9LGFQtpEBFcbCKlQ/dKTb4kF8GKphP2MOsN/sKzK383 BCD9WkfUoRQjvhCZtf/kWECipB4QYo/atVrAT3XJS/eETNMMYEOLfkkSeYFDHTGLRUCu m2wVrAtU6b2jvRT7FmGfh+y0cO8QA8OAILz+uNBTylwUES4m3ILaLi+UqZH4VUkN1jnj 9B1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=ZafyWrCRm6FANBOmjYAs3BX8tOsbMPnovvLplgzFND4=; b=m6IrDPGsskULosoVsBRJJSQNL02XEafHBFg9T/lMX+gmGy7IpZeUsMj9JYSmaBFymo 3u27nO5UXtsfXg01GHLUh2raTjXbqyEgpQl65rbs+vmj1CkHTEkFGq7gmV0xjCrx3Wwp 4yE4Q/3YVS4/dT4qPCIVjx2EpQABPviBk64c1nCikjBqi5VyCRM54JObc7q7Ult2cJs1 Ws8FvtN2934anBMoKfcVllTe98XX21EbnB9DjIr9xCe1bEkRZ/y9JVHnLLHTd14EQPYx c29G/Q3obfBvMYMJlkBLVIr9aTzR9ND76QbiDOcWClfrMUGtqbtaFJk2AQb7l/wKU207 RNgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="cK/CT4+c"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j12-20020a056a00130c00b004e15b4a7d4dsi14906651pfu.26.2022.03.02.05.04.38; Wed, 02 Mar 2022 05:04:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="cK/CT4+c"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238865AbiCBBXu (ORCPT + 99 others); Tue, 1 Mar 2022 20:23:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238805AbiCBBXt (ORCPT ); Tue, 1 Mar 2022 20:23:49 -0500 Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [IPv6:2607:f8b0:4864:20::112d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 040CE4B841 for ; Tue, 1 Mar 2022 17:23:07 -0800 (PST) Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-2d07ae0b1bfso1064057b3.6 for ; Tue, 01 Mar 2022 17:23:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZafyWrCRm6FANBOmjYAs3BX8tOsbMPnovvLplgzFND4=; b=cK/CT4+cjNdaqB/bq6onYRvRuaBZiEQDxJZG3nZzbEWSoC22iV0dPOwDBcGV9HX56D ND6Dj+1FAVJ3cyJqxC6tzp37/UegCdsU6f3uc8/xmd7dASF2LgPnKUagTPDKHP/8NHNt 3BARM+d3uKUnKHohwayXHbVwzBTXlm1BpUQrQt3KRLGma2vsLHEwWwMc85X7sJMUZ7T1 V94yzxg+1k1xKAlHHYEtYsLFkXDyZTJIaESXgLOgP0zOsJPOttKrGFC1hJafHCDD+vB1 TbO/XqsMj+UevbYicLmvXG93/GnrSdajRVKMNZ2RI/vhaedDbO3UM1TeVmiVun/eh8fs RnUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZafyWrCRm6FANBOmjYAs3BX8tOsbMPnovvLplgzFND4=; b=XzA/TNUSBhY/dXACz6BmMPOsgQ4sZji33afuyfcNDGa6t8wUl0y0db5smVsVBsnDnU jv6ju9OxWsJiLUA+fD3h2J/0EKp/ANgsnUyW13spNczdnrzbu/GPMnUGxPIX91tCwqlu 5uWajSyNzhebUIjcJ2eSI7ASS9iyx2cBgBxnZKnHRQA0bk0+NiaCLaeqoAOH1Fux5o+b rmWSuvqXQO+ucUZuJGmVaZ5QLLINsch6thquqkuZuGbm6GQDERiDecXECX/CIoGk9qIi N6tXjWCOLxjLe+LZNs5KiqwZum9tvktor/bS6eqiq8jObG0G1B6ZgsYPTC+49vXXGAxk TxbQ== X-Gm-Message-State: AOAM5304zg+hAbfvhn5gpTPEHX/BKghUwwBV/IxsrgVYzd+PbDxTGUFa R7k6X6llnb2Orc34imQc8jeqRY+LZV0t+RxfRseM6g== X-Received: by 2002:a81:6a0a:0:b0:2d0:c144:4be4 with SMTP id f10-20020a816a0a000000b002d0c1444be4mr28608461ywc.332.1646184185795; Tue, 01 Mar 2022 17:23:05 -0800 (PST) MIME-Version: 1.0 References: <1646133431-8948-1-git-send-email-lena.wang@mediatek.com> In-Reply-To: <1646133431-8948-1-git-send-email-lena.wang@mediatek.com> From: Eric Dumazet Date: Tue, 1 Mar 2022 17:22:54 -0800 Message-ID: Subject: Re: [PATCH net v2] net: fix up skbs delta_truesize in UDP GRO frag_list To: lena wang Cc: Paolo Abeni , "David S. Miller" , Jakub Kicinski , Matthias Brugger , Willem de Bruijn , Daniel Borkmann , Dongseok Yi , wsd_upstream@mediatek.com, netdev , LKML , Linux ARM , linux-mediatek@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-18.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 1, 2022 at 3:23 AM lena wang wrote: > > The truesize for a UDP GRO packet is added by main skb and skbs in main > skb's frag_list: > skb_gro_receive_list > p->truesize += skb->truesize; > > > > Fixes: 53475c5dd856 ("net: fix use-after-free when UDP GRO with shared fraglist") > Signed-off-by: lena wang > Acked-by: Paolo Abeni > --- > change since v1: > 1) add the fix tag. > 2) add net subtree to the subject > --- > --- > net/core/skbuff.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Eric Dumazet