Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3466cb33-7f5c-7b57-85f8-387e93516432@kapsi.fi>
Date:   Wed, 2 Mar 2022 14:31:46 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.4.1
Subject: Re: [PATCH v4 1/9] dt-bindings: host1x: Add iommu-map property
Content-Language: en-US
To:     Robin Murphy <robin.murphy@arm.com>, thierry.reding@gmail.com,
        jonathanh@nvidia.com, joro@8bytes.org, will@kernel.org,
        robh+dt@kernel.org, krzysztof.kozlowski@canonical.com
Cc:     linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org,
        iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Mikko Perttunen <mperttunen@nvidia.com>
References: <20220301161455.4037062-1-cyndis@kapsi.fi>
 <20220301161455.4037062-2-cyndis@kapsi.fi>
 <4a748c85-4fdb-0c10-19d8-0379b9e42ab5@arm.com>
From:   Mikko Perttunen <cyndis@kapsi.fi>
In-Reply-To: <4a748c85-4fdb-0c10-19d8-0379b9e42ab5@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 3/1/22 20:12, Robin Murphy wrote:
> On 2022-03-01 16:14, cyndis@kapsi.fi wrote:
>> From: Mikko Perttunen <mperttunen@nvidia.com>
>>
>> Add schema information for specifying context stream IDs. This uses
>> the standard iommu-map property.
>>
>> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
>> ---
>> v3:
>> * New patch
>> v4:
>> * Remove memory-contexts subnode.
>> ---
>>   .../bindings/display/tegra/nvidia,tegra20-host1x.yaml        | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git 
>> a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml 
>> b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml 
>>
>> index 4fd513efb0f7..0adeb03b9e3a 100644
>> --- 
>> a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml 
>>
>> +++ 
>> b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml 
>>
>> @@ -144,6 +144,11 @@ allOf:
>>           reset-names:
>>             maxItems: 1
>> +        iommu-map:
>> +          description: Specification of stream IDs available for 
>> memory context device
>> +            use. Should be a mapping of IDs 0..n to IOMMU entries 
>> corresponding to
> 
> Nit: maybe "context IDs 0..n" for maximum possible clarity?

I left it at "IDs" since there is no "context ID" or similar concept in 
the hardware, so I thought to leave it just as a kind of an 'abstract ID 
as used in iommu-map property'.

> 
> Either way, though, I'm happy that if the simplest and most 
> straightforward approach works, then it's the best choice.

I am happy as well, this is certainly much cleaner than the mess in the 
downstream driver :)

> 
> Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> 
> Cheers,
> Robin.

Thanks!
Mikko

> 
>> +            usable stream IDs.
>> +
>>         required:
>>           - reg-names