Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp650615pxm; Wed, 2 Mar 2022 06:00:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJx+I0XWRm/1AeuYYl4GE6NNQNeB0Q52AU3zH3qj4l1rnGCn17kdMPGEe3Y+k+YElPtg6Yn7 X-Received: by 2002:a05:6402:430d:b0:415:c176:3fc0 with SMTP id m13-20020a056402430d00b00415c1763fc0mr2196840edc.358.1646229603033; Wed, 02 Mar 2022 06:00:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646229603; cv=none; d=google.com; s=arc-20160816; b=kpi3nUMpinP1jvGFJH67U9jWu5wl5AfDvQSzHSzeFetXPi4EFWV/WKEkBnkIQbVHWl AFLlu+v7wTo4S/uJKRLwG80ZUC7+ZoRWUMSGAIOqh655+2G80CfBY+eLi123jIkfePe0 9e0cC+s6S24YTH1sq9/klulXY8n9KsOpPqiGaBOmwVGxIWgGPaoUl35kmAJvHt20H4vX +/BKqh5aeTyU/s/Bjp525LSUUyZLc4h3zRXCHnjibkbGI+rWdytRpEX8idcVhqGRLqcx bnRW+rMnJ4+PfOJDs+QHj4v2usI0bt1PJQFLujJZ9PLiuLV0tNq5JyHLVfHSdr+670Z7 spZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature:dkim-signature; bh=81XLZdJTxsdo7/bRz3kjmDMEOLKe7jESLpZCe4VnvqE=; b=jsxlUK3rGUxOdcVZxQwHNYCBD/0yiYT1zJ2S0/XgJwn7WIK9a0rT7Y3axraRh7sNnq mMJN5/Ya0+xBN60B8cFXFNg/3fKs5E3NdowLPwHQf1CHMZb7sdgfGUzktOv3ynKzbhHM BtWzDTlSrwuzi017tWtoclV+xxj2M/blk5+cMyYd2f1sCJCiDnZrs/p3thpcleGTnPGR KX8pxHjmF9PDrRaEBzubX+5HNBdpYj93xgUbS8SzUvjtuYkBLDYV5nWzjCwedXdBScIS rf5GOS36/rnPaAHIm9Zk1887lHlvEQ9Pg2kAbfjogQzNseepS8zMyIZxo5iyZ5othg/A ewTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=k8yt4iAj; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=O5TZ4vye; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hz5-20020a1709072ce500b006da81f8bd5esi166245ejc.232.2022.03.02.05.59.38; Wed, 02 Mar 2022 06:00:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=k8yt4iAj; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519 header.b=O5TZ4vye; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240373AbiCBJKf (ORCPT + 99 others); Wed, 2 Mar 2022 04:10:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240366AbiCBJKb (ORCPT ); Wed, 2 Mar 2022 04:10:31 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53A35BB095 for ; Wed, 2 Mar 2022 01:09:48 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 0B4C91F37E; Wed, 2 Mar 2022 09:09:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1646212187; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=81XLZdJTxsdo7/bRz3kjmDMEOLKe7jESLpZCe4VnvqE=; b=k8yt4iAjrQQOy+X00UrbEW9jP81lB3Iz7a2gsj07TWUjIeTK6th5Ipx+rL3GpjzUuFmNTv C/sUk98K6kJq7EEBDTycvBNL1C1f+0pH5g1q7/KpFHaRKvdGd0AbW6c1q9mvNY9U+yHDX1 VunrrQBvhA61XEsVXfyBF/2emNDG+SY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1646212187; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=81XLZdJTxsdo7/bRz3kjmDMEOLKe7jESLpZCe4VnvqE=; b=O5TZ4vyelRYzLxvybbc1EJqpJc5z5JYo9vkXbIgG6evYkD5ZwkPuwNJCuM2yRLsuxbKvMv cXZFecWBVm87V1DA== Received: from pobox.suse.cz (pobox.suse.cz [10.100.2.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id EC2FEA3B83; Wed, 2 Mar 2022 09:09:46 +0000 (UTC) Date: Wed, 2 Mar 2022 10:09:46 +0100 (CET) From: Miroslav Benes To: Zong Cao cc: jpoimboe@redhat.com, peterz@infradead.org, mingo@kernel.org, bp@suse.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] objtool: Fix memory leak in objtool_create_backup In-Reply-To: <20220301163651.50346-1-cz18811105578@gmail.com> Message-ID: References: <20220301163651.50346-1-cz18811105578@gmail.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, 2 Mar 2022, cz18811105578@gmail.com wrote: > From: Zong Cao > > The error handling branch did not properly free the memory before > return, which would cause memory leak. yes, but objtool exits immediately in those cases so this is not really needed in the end. Regards Miroslav