Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp658123pxm; Wed, 2 Mar 2022 06:06:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJygpnlq3onWbh6h+OyK+KEPF7OFtsSXZW3C688a4yhMUeNWIlvdujy/WuHefHnUpuQz+70k X-Received: by 2002:a50:fa95:0:b0:413:8489:b483 with SMTP id w21-20020a50fa95000000b004138489b483mr22519904edr.34.1646229981176; Wed, 02 Mar 2022 06:06:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646229981; cv=none; d=google.com; s=arc-20160816; b=zrp6BJkmU9oMOQEFHYMX5DS1dRbf5rTeZVwI3G79kokP4MuAp3u8WSw9zUgJraOh/L deIgvsnhOx63wW3LXgnPRjXEVZ4VIHQio/xMgNwBgpugsZzc2cN0tPUPzQWPRJYsdp/A EPf3oGJ1UUIxzcZc3aXrR2bNydUKIN68pAiPfBmED+sPqg82UC5b+YJYuV1OVLzMXL4N 79yr8p2BpsWVj9QxGKD32trIR+Rzms303Y3lj209adU8WKkawpm5tBNo3dqO6pU4VxPG n2CeGf972hrz51FSvbsxuvlAHGFOS+/0yFQ/ZissdD71KgEPIorKAhZPB8cXYbCtqO5j 8KRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7SdohgjdZwr8XTSeKb1Wfr0MU6JR/xVezniOJDAD0D8=; b=ujlH1Nao1CB3mnBHSyQCpty/sKd/6SphcjHiNQk4pqu9mtCXn+T1bOgThZJlzMTjAI 3AbHLCisDDeu4ZXd8MSWzV834PnTjjJP7oF9xBzb5N4Jk3yVhNFzzE0xBtQC01d2w+iZ oWC18FdnUuRrqR4BT7K0COZeoWMj1bvlpnmAtyFB2KlzZaCFc6SA+XIuVboh74nh9CUF qd8wOTicoaSJiHQQExmLHJfJDuiQlo/dezRK+Z4etuM6tGlCTnhSHyL8B67g0Xmpj0gP hG3sYTyRAZoprG3jvLxL5VgXVqLI+dT8o6xVN746yph8suKan6v84l/j6TN+RDeGjFpq BkCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sbdUZEy5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z8-20020a170906814800b006d6e100c3c0si3565239ejw.14.2022.03.02.06.05.56; Wed, 02 Mar 2022 06:06:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sbdUZEy5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242323AbiCBNpU (ORCPT + 99 others); Wed, 2 Mar 2022 08:45:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236210AbiCBNpQ (ORCPT ); Wed, 2 Mar 2022 08:45:16 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AD8F5C347 for ; Wed, 2 Mar 2022 05:44:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 102F5603E0 for ; Wed, 2 Mar 2022 13:44:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D05BC004E1; Wed, 2 Mar 2022 13:44:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646228672; bh=7SdohgjdZwr8XTSeKb1Wfr0MU6JR/xVezniOJDAD0D8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sbdUZEy5XWy9rag6+3KL0fKGXtDHwJbOs58Xoe1Y/Il9vAAzHO5wrJYKdcwelbc1q BMnnpOmqKSwlv+cw/jKa3gdKliTrZF9HnwgT995w/R0yDaBuxar5n0Gut+vwTa7+OW 8QGikadkhVEeivYvv12FpuYwWDne5f32adLp8zePja/q3EiAEj6csKS9J7aro2qt8L bmCVTS0nDWPmAlA3QfKIUNvvcqFu0W4YFtn6ReNmfRGqkzKw1v6cfpUi7trfL/CL06 wbumDzA5RDt26Fpcn00WI9M/1ALSxsM0mFXmpK+qiXAFZwZegDLYsN1KIXIDveajzZ XO9xZiaZmm2UQ== Date: Wed, 2 Mar 2022 13:44:27 +0000 From: Mark Brown To: Miaoqian Lin Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: fsl: Fix error handling in pcm030_fabric_probe Message-ID: References: <20220301075351.31691-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zPKg93Nv3+dx0TgJ" Content-Disposition: inline In-Reply-To: <20220301075351.31691-1-linmq006@gmail.com> X-Cookie: All men have the right to wait in line. X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zPKg93Nv3+dx0TgJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 01, 2022 at 07:53:48AM +0000, Miaoqian Lin wrote: > This will call twice platform_device_put() > if both platform_device_add() and snd_soc_register_card() fails. > Fix it by using goto label to avoid duplicating the error code logic. This doesn't apply against current code, please check and resend. --zPKg93Nv3+dx0TgJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmIfdLsACgkQJNaLcl1U h9DSmggAgh1dqp4/bgEI+eYNLVecexRuzd1XFEdwTsACPSdAnD3VV5YWjgHO2p5/ SAVJpJ9YQFWEtlCG+wA+LHiEv4BwzBCk0ga7fCzfju5x4PaNh2WyQ9hu2ZjyAHu5 9mHMiKGa2zhEUz8K7yrEEg/diJKIYAi5C+9HwjjJMj7M+N5OF//sW2Oso5zaiC7L j/wVzr1lvjnkkF0lNdBEUhPM6AIptIRmq5bXGraLaBda23wNrC2pXQEcumpXjzRF e1Ru2AfhkpDS+0RmXtrZOpiAm2AsDfjlU21QCC51c1JrxLikvrTsrc24QBoDJtN/ mpMt7ItjjJ7ryuxZDCThtJQLAj2WhQ== =l523 -----END PGP SIGNATURE----- --zPKg93Nv3+dx0TgJ--