Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220302082145.12028-1-linmiaohe@huawei.com>
In-Reply-To: <20220302082145.12028-1-linmiaohe@huawei.com>
From:   Muchun Song <songmuchun@bytedance.com>
Date:   Wed, 2 Mar 2022 17:04:15 +0800
Message-ID: <CAMZfGtXPS1SOKC2AnNEmcVqtsVgX6Vmm++FfjcFrZyLAAJ369g@mail.gmail.com>
Subject: Re: [PATCH] mm/huge_memory: make is_transparent_hugepage() static
To:     Miaohe Lin <linmiaohe@huawei.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Matthew Wilcox <willy@infradead.org>,
        Yang Shi <shy828301@gmail.com>, william.kucharski@oracle.com,
        Hugh Dickins <hughd@google.com>, Peter Xu <peterx@redhat.com>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Mar 2, 2022 at 4:22 PM Miaohe Lin <linmiaohe@huawei.com> wrote:
>
> It's only used inside the huge_memory.c now. Don't export it and make
> it static. We can thus reduce the size of huge_memory.o a bit.
>
> Without this patch:
>    text    data     bss     dec     hex filename
>   32319    2965       4   35288    89d8 mm/huge_memory.o
>
> With this patch:
>    text    data     bss     dec     hex filename
>   32042    2957       4   35003    88bb mm/huge_memory.o
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Reviewed-by: Muchun Song <songmuchun@bytedance.com>

Thanks.