Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp662350pxm; Wed, 2 Mar 2022 06:10:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJyJRZPG1IJ22iXwOfZ4VUyNYlYqeBQyE/BXS0NkYY2LrCwBHSJcwIvXjCWTDgLI+DgbRYZU X-Received: by 2002:a17:90a:7884:b0:1be:ef64:2212 with SMTP id x4-20020a17090a788400b001beef642212mr5230948pjk.53.1646230220659; Wed, 02 Mar 2022 06:10:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646230220; cv=none; d=google.com; s=arc-20160816; b=Fmf3J5ORhxSccIEiIDVzWo5kNIO8L8SkYks3FQQLr0d34XgDMfO8F6hblZISbhl9Od DBgl9ULDB1HfxPcPKhZbMP1KusGx/LUIZkVppKQMuJIpLbGDONWcQYyaEeF+zxLweyWk /ndQsto4Ox2fD1skHy8T9Up+sJpBk8bsSQW4ceu3pG6i0SVX1m6xUQIkTuCo5akcq6H/ lbq72tGju3v46pgKWLXOyVOP0erv3cjUHZ0zFxteKJ60E1E0zEo0sJISLPrBf3EnJXrJ gqNpM9eERvpqpv+qz+U3bWjRTye27EvY1z0a/xm9mIh1Sn7YJVC2KFAkj3IpkvRHNvup WEVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=GJ2BhPTfVAxkP4FcHPOJE11vP5WKDPDbfIXXkA1bkvQ=; b=AYjBENPitCcZhRs8MAnOPEhSlBn3QmhsUGFfYT+zp8iooZlegvF8mblU2gUhj+bVrB u57TA8GmI0e1DIwFcHkyyDQomZumsGbncvwAeXCpWP6JHFW1Be/quIm01ongb8+YgaVn gRfQA4ua6AN23l0AJ/pfegD+JFene5wBwd2WOH67+E1P4b/oSU6ibi8dHD7rc7Y3rrDw Qlj+U8F6MjQExs6nWuHS83RspY7fOPfA1wwIvJQbBakkxWdN0rdTKrEoWyzsTIwN84Ba CTNjxXuHr+mUSjoZCiloFgGhE5nhclF36KV8yohqAb8opHoTqZD8ggZYMmro1QS+RWtx Qcjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=v34sa9cO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k72-20020a636f4b000000b003757999bfcdsi15183333pgc.404.2022.03.02.06.10.00; Wed, 02 Mar 2022 06:10:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=v34sa9cO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241009AbiCBK0q (ORCPT + 99 others); Wed, 2 Mar 2022 05:26:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240979AbiCBK0k (ORCPT ); Wed, 2 Mar 2022 05:26:40 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4ECECAD122 for ; Wed, 2 Mar 2022 02:25:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GJ2BhPTfVAxkP4FcHPOJE11vP5WKDPDbfIXXkA1bkvQ=; b=v34sa9cOoRhiCgFv6PAn5chOli bf3v6w2iR3antJq4oO9ETRdLX8YnN2RsO/KhSNP+rjoK9HFnHmg42G1QHASBoxKsQRFCJTGycdpcE w+sxMImLufEnUFD4zvYdgc6visCeWclv8SWhtPHYT4MklQY8aJr8A6lUXZLTL/BFZDUp8SIUkpA/u KIBybGXLlKdgHP32fWOr9XAMGehiG34aufidEGK4XfnpdZXQD1RW/ZTMtW6/QydMAck7PfeQ1X16s tcYAZNjCF2zdfKOwzbI/heQ6YAB3PLitLdlwPgR7ToFKuObkp1F2Imc9Z3OaNXYUud7zOJ6bZy+Ne o/mKE23g==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPMAj-00AUKf-V5; Wed, 02 Mar 2022 10:25:30 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 66E0530018E; Wed, 2 Mar 2022 11:25:29 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 2872F321EE6E0; Wed, 2 Mar 2022 11:25:29 +0100 (CET) Date: Wed, 2 Mar 2022 11:25:29 +0100 From: Peter Zijlstra To: Masami Hiramatsu Cc: x86@kernel.org, joao@overdrivepizza.com, hjl.tools@gmail.com, jpoimboe@redhat.com, andrew.cooper3@citrix.com, linux-kernel@vger.kernel.org, ndesaulniers@google.com, keescook@chromium.org, samitolvanen@google.com, mark.rutland@arm.com, alyssa.milburn@intel.com, mbenes@suse.cz, rostedt@goodmis.org, alexei.starovoitov@gmail.com, naveen.n.rao@linux.vnet.ibm.com Subject: Re: [PATCH v2 15/39] x86/ibt,kprobes: Fix more +0 assumptions Message-ID: References: <20220224145138.952963315@infradead.org> <20220224151322.892372059@infradead.org> <20220228150705.aab2d654b973109bab070ffe@kernel.org> <20220228232513.GH11184@worktop.programming.kicks-ass.net> <20220301114905.e11146ad69d6e01998101c3b@kernel.org> <20220302091150.21daa1b3f153a98206ee8d9a@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220302091150.21daa1b3f153a98206ee8d9a@kernel.org> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 02, 2022 at 09:11:50AM +0900, Masami Hiramatsu wrote: > > But if you really want/need to retain that, then yes, we need that > > else branch unconditionally :/ > > Thank you, That's what I ended up doing in the latest version; I realized that irrespective of symbol size, it is required when symbols overlap, as per the case mentioned by Naveen. https://lkml.kernel.org/r/20220301200547.GK11184@worktop.programming.kicks-ass.net