Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220301132623.GA19995@vscode.7~> <CAJ8uoz2y2r1wS3_sSgZ8jC2fkiyNCW_q4oQdc_JYe2bKO4NoJA@mail.gmail.com>
 <CAJ+HfNiXD_T4qdA7hMep0ncTDnPCNdtV74F8P_oTWb=2ZVoG+Q@mail.gmail.com> <20220302090603.GA12386@vscode>
In-Reply-To: <20220302090603.GA12386@vscode>
From:   Magnus Karlsson <magnus.karlsson@gmail.com>
Date:   Wed, 2 Mar 2022 10:08:19 +0100
Message-ID: <CAJ8uoz3LDVFDXyGjhqaHiyL5=fCPJKrFNyjA7LQVv8x-VX2ZTw@mail.gmail.com>
Subject: Re: [PATCH bpf] libbpf: unmap rings when umem deleted
To:     lic121 <lic121@chinatelecom.cn>
Cc:     =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn.topel@gmail.com>,
        bpf <bpf@vger.kernel.org>,
        Magnus Karlsson <magnus.karlsson@intel.com>,
        Jonathan Lemon <jonathan.lemon@gmail.com>,
        Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <kafai@fb.com>,
        Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Jesper Dangaard Brouer <hawk@kernel.org>,
        Network Development <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Mar 2, 2022 at 10:06 AM lic121 <lic121@chinatelecom.cn> wrote:
>
> On Wed, Mar 02, 2022 at 09:48:33AM +0100, Bj=C3=B6rn T=C3=B6pel wrote:
> > On Wed, 2 Mar 2022 at 08:29, Magnus Karlsson <magnus.karlsson@gmail.com=
> wrote:
> > > On Tue, Mar 1, 2022 at 6:57 PM lic121 <lic121@chinatelecom.cn> wrote:
> > [...]
> > > > Signed-off-by: lic121 <lic121@chinatelecom.cn>
> >
> > In addition to Magnus' comments; Please use your full name, as
> > outlined in Documentation/process/5.Posting.rst.
>
> Thanks for the review Bj=C3=B6rn.
> Magnus, please let me know if you can correct the full name when you
> apply the patch? Otherwise I can create a MR in libxdp repo. Thanks

I will add it.

Thanks: Magnus

> full name: Cheng Li
>
> >
> > Cheers!
> > Bj=C3=B6rn