Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 02 Mar 2022 11:04:06 +0100
Message-ID: <s5hee3koell.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Zhen Ni <nizhen@uniontech.com>
Cc:     frattaroli.nicolas@gmail.com, lgirdwood@gmail.com,
        broonie@kernel.org, tiwai@suse.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: rockchip: i2s_tdm: fix runtime pm imbalance on error
In-Reply-To: <20220302100019.22891-1-nizhen@uniontech.com>
References: <20220302100019.22891-1-nizhen@uniontech.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 02 Mar 2022 11:00:19 +0100,
Zhen Ni wrote:
> 
> pm_runtime_get_sync() increments the runtime PM usage counter even the
> call returns an error code. Thus a pairing decrement is needed on the
> error handling path to keep the counter balanced.
> 
> Signed-off-by: Zhen Ni <nizhen@uniontech.com>

Better to use a new function pm_runtime_resume_and_get().


thanks,

Takashi

> ---
>  sound/soc/rockchip/rockchip_i2s_tdm.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/rockchip/rockchip_i2s_tdm.c b/sound/soc/rockchip/rockchip_i2s_tdm.c
> index 5f9cb5c4c7f0..4691a76b499d 100644
> --- a/sound/soc/rockchip/rockchip_i2s_tdm.c
> +++ b/sound/soc/rockchip/rockchip_i2s_tdm.c
> @@ -1739,8 +1739,10 @@ static int __maybe_unused rockchip_i2s_tdm_resume(struct device *dev)
>  	int ret;
>  
>  	ret = pm_runtime_get_sync(dev);
> -	if (ret < 0)
> +	if (ret < 0) {
> +		pm_runtime_put(dev);
>  		return ret;
> +	}
>  	ret = regcache_sync(i2s_tdm->regmap);
>  	pm_runtime_put(dev);
>  
> -- 
> 2.20.1
> 
> 
>