Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   SeongJae Park <sj@kernel.org>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     sj@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] mm/damon/sysfs: Fix missing error code in damon_sysfs_attrs_add_dirs()
Date:   Wed,  2 Mar 2022 11:26:25 +0000
Message-Id: <20220302112625.7345-1-sj@kernel.org>
In-Reply-To: <20220302111120.24984-1-jiapeng.chong@linux.alibaba.com>
Precedence: bulk

On Wed, 2 Mar 2022 19:11:20 +0800 Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:

> The error code is missing in this code scenario, add the error code
> '-ENOMEM' to the return value 'err'.
> 
> Eliminate the follow smatch warning:
> 
> mm/damon/sysfs.c:1647 damon_sysfs_attrs_add_dirs() warn: missing error
> code 'err'.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Good eye, thank you!

Reviewed-by: SeongJae Park <sj@kernel.org>

Andrew, please fold this patch into
mm-damon-implement-a-minimal-stub-for-sysfs-based-damon-interface.patch[1].

[1] https://www.ozlabs.org/~akpm/mmotm/broken-out/mm-damon-implement-a-minimal-stub-for-sysfs-based-damon-interface.patch


Thanks,
SJ

> ---
>  mm/damon/sysfs.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
> index 32a9d21c0db5..0eca71163924 100644
> --- a/mm/damon/sysfs.c
> +++ b/mm/damon/sysfs.c
> @@ -1643,8 +1643,10 @@ static int damon_sysfs_attrs_add_dirs(struct damon_sysfs_attrs *attrs)
>  	attrs->intervals = intervals;
>  
>  	nr_regions_range = damon_sysfs_ul_range_alloc(10, 1000);
> -	if (!nr_regions_range)
> +	if (!nr_regions_range) {
> +		err = -ENOMEM;
>  		goto put_intervals_out;
> +	}
>  
>  	err = kobject_init_and_add(&nr_regions_range->kobj,
>  			&damon_sysfs_ul_range_ktype, &attrs->kobj,
> -- 
> 2.20.1.7.g153144c