Received: by 2002:a05:6a10:9afc:0:0:0:0 with SMTP id t28csp752017pxm; Wed, 2 Mar 2022 07:49:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJzqQbj42IFoPsIu+pyqRk2P7wSNtY6TKrH8+RX6Hmimh56izGpQnOqJemRdg0Bvz8aS7JIL X-Received: by 2002:a65:4cc4:0:b0:373:d441:f999 with SMTP id n4-20020a654cc4000000b00373d441f999mr26260626pgt.387.1646236139824; Wed, 02 Mar 2022 07:48:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1646236139; cv=none; d=google.com; s=arc-20160816; b=svzbCUd7CPkWPPAz2ATGB+B4poTv559GTCdRvVYHIC2bUcB96oaiaPjGp8AlER3AOH Traj/sBol7LPROI7gBTeB//PVDfrmJrtM46jGDp7zh/F+Bfry2wETs1VWvYD35n+wWvj Na6MDSkwVHLaGVTO3E+0AvHJYK+7ywFUVznDFFovZiPNeACPuIub8PHRoFw0r/Slux6d 9ohLetHzQxlYUjfpQAdZ5seAULosF4kcXJk3RsPQmavWC+uEVpR6hNNzRxzJvj34YNeW tfi5psPSq4tLuN05zX6CgPMpTghy3vtPkV+NxIIj24o3AGHQo8GHwc9+L10Vx/I7py30 485Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=mmI3oezzHWmjR+czFohDD4ftUJI2wkgVegnPTHNylpQ=; b=xd8IDY0ZhzBiT+lRERvmqD9TjlAEeORD2wUr41JR0ukDsbVtQbebu51/O817HDrV/m qTjIfYM44E8JIbI99NG5aQhne3RAK6v2l1nHN68mHLH0x+mEyRlOoYh3Gt7vLU6Kc1o0 sooo3uKlEG5KuyZgWDZj1nS6KQNrEhRgnSlTgwhDE76sUVJLeDxa6Y5MxTOVzS44/Vj4 z+rFf4J6THHNYbmPtOd5rwZiQ9G/GKWA/9nvzcChvkqk8uUJNwREWTLXuiA+ex/vPF5e 5JXQUHZINHndhHS1iLo2lF7hfmkyihhhqK4qQt+xoA88E3OpZkXn5QwWb+XpuK/lSgJ5 Ppxw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h12-20020a170902f70c00b0015171dbc23dsi7362932plo.113.2022.03.02.07.48.42; Wed, 02 Mar 2022 07:48:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241040AbiCBKiJ (ORCPT + 99 others); Wed, 2 Mar 2022 05:38:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235525AbiCBKiH (ORCPT ); Wed, 2 Mar 2022 05:38:07 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 54BE0517CC; Wed, 2 Mar 2022 02:37:24 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1BF4D139F; Wed, 2 Mar 2022 02:37:24 -0800 (PST) Received: from e123427-lin.home (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CA33C3F70D; Wed, 2 Mar 2022 02:37:22 -0800 (PST) From: Lorenzo Pieralisi To: Rob Herring , Jingoo Han , Bjorn Helgaas , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Jisheng Zhang , Gustavo Pimentel Cc: Lorenzo Pieralisi , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] PCI: dwc: Fix integrated MSI Receiver mask reg setting during resume Date: Wed, 2 Mar 2022 10:37:08 +0000 Message-Id: <164621741211.30934.17302961993458445211.b4-ty@arm.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20211226074019.2556-1-jszhang@kernel.org> References: <20211226074019.2556-1-jszhang@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 26 Dec 2021 15:40:19 +0800, Jisheng Zhang wrote: > If the host which makes use of the IP's integrated MSI Receiver losts > power during suspend, we call dw_pcie_setup_rc() to reinit the RC. But > dw_pcie_setup_rc() always set the pp->irq_mask[ctrl] as ~0, so the mask > register is always set as 0xffffffff incorrectly, thus the MSI can't > work after resume. > > Fix this issue by moving pp->irq_mask[ctrl] initialization to > dw_pcie_host_init(), so we can correctly set the mask reg during both > boot and resume. > > [...] Applied to pci/dwc, thanks! [1/1] PCI: dwc: Fix integrated MSI Receiver mask reg setting during resume https://git.kernel.org/lpieralisi/pci/c/84edd0090e Thanks, Lorenzo